From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 18A4A3856DD0 for ; Wed, 25 May 2022 23:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18A4A3856DD0 Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-255-lNtsF_KdPOug8ImHRHiJSA-1; Wed, 25 May 2022 19:39:01 -0400 X-MC-Unique: lNtsF_KdPOug8ImHRHiJSA-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-300531a6574so26389617b3.8 for ; Wed, 25 May 2022 16:39:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YanGwct7hgtOLS3+77LKreNNQz6EavvIlfNOFQ0cLIA=; b=ME3fxgTUXeQQ83CkaSEM4Vd0Pz2jwGTmPvIIPMm2ZhQzQods3h0ALHur5l3eHm29HN klvLNkatty/9+N9yhs0YhgKeTPkFLjR9Gxoh2x9uDdq6ROduEm/wISm0b9QGdG68IgQV KSTg/Ad+PMT89T97oG+gB3D/8ZAiR67H0nc+tYMI7jkqwF1Jzy6SfudF154lh/FHcSkl 1cdDxo22lNz2RdpY2NhSxfbhetg3MWlFyiT42z6+neDyuXJ3rVdnfXlGJZ/51ayltREV ZBTDC2IT43ul8SBy7GVwi+wlj4EH8C2OtSJ1qOkjvfQhXpI0p1cgtMGG7Qr5OiJOHRmB tjPQ== X-Gm-Message-State: AOAM533A0BvKO12e0/EbGxVWKJUeOO7MZzezhVGU1C9dXFX5crFHQKdG nmX/sVJVFF0JU1PQkgVqfrjon4oWGn1H0Tjil8J1VKg6top8TZ7stDcZPe7snQpdV09fsdr29Cf /irwm8aaTEpd0l0kuMpYn3zcrMgVmLJY= X-Received: by 2002:a0d:df4a:0:b0:2ff:29c7:124e with SMTP id i71-20020a0ddf4a000000b002ff29c7124emr36499269ywe.346.1653521941158; Wed, 25 May 2022 16:39:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCQzWCFBPO23bUUTf1gqKcbsLWZuwlqZ/IHWv5P9OOJ7OQUbUrrBGMGfamUaJse4L+thr8EiP+fTu702AtTXo= X-Received: by 2002:a0d:df4a:0:b0:2ff:29c7:124e with SMTP id i71-20020a0ddf4a000000b002ff29c7124emr36499258ywe.346.1653521940991; Wed, 25 May 2022 16:39:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Thu, 26 May 2022 00:38:49 +0100 Message-ID: Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix std::span pretty printer To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 23:39:04 -0000 On Thu, 26 May 2022 at 00:34, Jonathan Wakely wrote: > > On Wed, 25 May 2022 at 21:29, Fran=C3=A7ois Dumont via Libstdc++ > wrote: > > > > Hi > > > > Here is a patch to fix std::span pretty printer in versioned > > namespace mode. > > > > Note that there is still a problem with std::atomic after this pat= ch. > > > > got: $13 =3D std::atomic> (empty) =3D {get() = =3D 0x0} > > FAIL: libstdc++-prettyprinters/cxx20.cc print spe Does this fix it? --- a/libstdc++-v3/python/libstdcxx/v6/printers.py +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py @@ -1734,6 +1734,7 @@ class StdAtomicPrinter: impl =3D val['_M_impl'] self.shptr_printer =3D SharedPointerPrinter(typename, impl) self.children =3D self._shptr_children + self.typename =3D self.typename.replace(self.value_type.ta= g, typ) def _shptr_children(self): return SmartPtrIterator(self.shptr_printer.pointer) I'll test it with a versioned-namespace build tomorrow. > > > > libstdc++: [_GLIBCXX_INLINE_VERSION] Fix std::span pretty printer > > > > libstdc++-v3/ChangeLog: > > > > * python/libstdcxx/v6/printers.py (StdSpanPrinter.__init__= ): > > Strip typename from version namespace. > > > > Tested under Linux x86_64 _GLIBCXX_INLINE_VERSION mode. > > > > Ok to commit ? > > OK, thanks.