From: Jonathan Wakely <jwakely@redhat.com>
To: Matthias Kretz <m.kretz@gsi.de>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH 0/3] Improve and document stdx::simd testsuite
Date: Thu, 24 Jun 2021 14:12:53 +0100 [thread overview]
Message-ID: <CACb0b4kEPodODuv-N_QazhzCaUbH=MuNviQOtEkUm1iqpYc49g@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4=ZhggUpdiD61sJoaQ=ZNreNMqG=SmiJqGfpM-purZ_jg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Wed, 23 Jun 2021 at 16:46, Jonathan Wakely wrote:
>
> On Tue, 8 Jun 2021 at 09:57, Matthias Kretz <m.kretz@gsi.de> wrote:
> >
> > As discussed a long time ago on IRC, this improves (i.e. decreases by default)
> > the verbosity of make check-simd, gives more verbosity options, and finally
> > documents how the simd testsuite is used and how it works. In addition, after
> > PR98834 was resolved, remove the -fno-tree-vrp workaround.
> >
> > Tested on x86_64-linux (and more).
>
> Great, thanks, I'm about to push all 3 patches to trunk.
I've pushed this fix for some typos in the new README.md
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 2455 bytes --]
commit 07ba52849ffca26a3d461f94921b23a9cdbaea7f
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu Jun 24 13:49:19 2021
libstdc++: Fix typos and markdown errors in new simd/README.md
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
* testsuite/experimental/simd/README.md: Fix typos.
diff --git a/libstdc++-v3/testsuite/experimental/simd/README.md b/libstdc++-v3/testsuite/experimental/simd/README.md
index db0d71f8d43..b82453df403 100644
--- a/libstdc++-v3/testsuite/experimental/simd/README.md
+++ b/libstdc++-v3/testsuite/experimental/simd/README.md
@@ -11,7 +11,7 @@
### `target_list`
Similar to dejagnu target lists: E.g.
-`target_list="unix{-march=sandybridge,-march=native/-ffast-math,-march=native/-ffinite-math-only}"
+`target_list="unix{-march=sandybridge,-march=native/-ffast-math,-march=native/-ffinite-math-only}"`
would create three subdirs in `testsuite/simd/` to run the complete simd
testsuite first with `-march=sandybridge`, then with `-march=native
-ffast-math`, and finally with `-march=native -ffinite-math-only`.
@@ -21,7 +21,7 @@
This variable can be set to a path to a file which is equivalent to a dejagnu
board. The file needs to be a valid `sh` script since it is sourced from the
-`scripts/check_simd` script. It's purpose is to set the `target_list` variable
+`scripts/check_simd` script. Its purpose is to set the `target_list` variable
depending on `$target_triplet` (or whatever else makes sense for you). Example:
```sh
@@ -52,7 +52,7 @@
`power7` which always uses the flags `-mcpu=power7` and `-static` when
compiling tests and prepends `$HOME/bin/run_on_gccfarm gcc112` to test
executables. In `target_list` you can now use the name `power7`. E.g.
-`target_list="power7 power7/-ffast-math"` or it's shorthand
+`target_list="power7 power7/-ffast-math"` or its shorthand
`target_list="power7{,-ffast-math}"`.
@@ -109,7 +109,7 @@
influencing the set of tests to generate and whether the test driver should
expect a failure.
-Then the test must at least `#include "bits/verify.h", which provides `main`
+Then the test must at least `#include "bits/verify.h"`, which provides `main`
and declares a `template <typename V> void test()` function, which the test has
to define. The template parameter is set to `simd<T, Abi>` type where `T` and
`Abi` are determined by the type and ABI subset dimensions.
prev parent reply other threads:[~2021-06-24 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 8:57 Matthias Kretz
2021-06-08 8:58 ` [PATCH 1/3] libstdc++: Remove -fno-tree-vrp after PR98834 was resolved Matthias Kretz
2021-06-08 8:59 ` [PATCH 2/3] libstdc++: Improve output verbosity options and default Matthias Kretz
2021-06-08 8:59 ` [PATCH 3/3] libstdc++: Document simd testsuite Matthias Kretz
2021-06-23 15:46 ` [PATCH 0/3] Improve and document stdx::simd testsuite Jonathan Wakely
2021-06-24 13:12 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4kEPodODuv-N_QazhzCaUbH=MuNviQOtEkUm1iqpYc49g@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=m.kretz@gsi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).