From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 483C93858C39 for ; Fri, 13 Jan 2023 14:17:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 483C93858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673619443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bI385P2Z1y+v/uPwRsjOufqZd1vwwtySayoBEfET+Po=; b=UV8KJpq6J6PGfYSsjtJg4PaSeT8vcbYyL0QBeO/dD+PBVTdoy7AUt2979O+4vRuKP1ZFcw GHrGjkY7lU1TIEsTGaPT0ibmiEkg9kytV3nlg1sQ2TJnJma79HfG7CGErvX1sB5MqhE+Lk 1EwkNiY6cp8lvDi/l0q63nie4QVam3s= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-387-0EjZVjM2Mlu2XTuf00Qjxw-1; Fri, 13 Jan 2023 09:17:22 -0500 X-MC-Unique: 0EjZVjM2Mlu2XTuf00Qjxw-1 Received: by mail-lj1-f199.google.com with SMTP id c18-20020a2ebf12000000b00279a72705feso5624686ljr.12 for ; Fri, 13 Jan 2023 06:17:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bI385P2Z1y+v/uPwRsjOufqZd1vwwtySayoBEfET+Po=; b=5lACzRIaoZ+VBEKkGcQzqZo9PBxo+sMXNd9s3+EntzG9nhEl36+CcykbIjVKnnKyqQ OTKyat5Mt4D+JzfdD4G6bnwcglDh++TFEPMGwdbaq9NERqxzFkPoeJJodU9dn9sqAHvv Lvh31o82QKJeZYTLZ1Z+0/GIFVO7TihvPgRMs3/u9sYrzKtHpkkKrfUbdvipeKjOl359 N814rcIAcziJQUXnmCf84tFs5X8ZLsaoKhHr8/fbvBpw3oJ8w7FZd9ZKqDgG+E3d8VYX N2A6wMZLixVg8+SiKDJU5d5Wq7ROfa/kOH9g2TnbnXRBh1k6B3si1Iz2CpmPbQW0PQ0r RvTQ== X-Gm-Message-State: AFqh2kpLYJijB1fJ/uRU+mG/5gddSkQiAyUQ8eNcFomwXNyWmSMeN8vu zPd7zPzr0fwD+izwEaDdpwFneWpRc+t48yzvGYuvw6n7pgMvTDKa8Xg/Nh+6foSzEJu+GROVyvb jXTxFVTkilNtuxGG/KOHJ9XpiYyQbb6k= X-Received: by 2002:ac2:5b41:0:b0:4b5:5f2b:ddf6 with SMTP id i1-20020ac25b41000000b004b55f2bddf6mr3147405lfp.17.1673619441474; Fri, 13 Jan 2023 06:17:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXt1kbmOjEsUS0lmNl9Pd6f342JmK1BSnI77ZwP3iKzIEvGKzmdLB2YZLfw2oc5M+JKGsmifzR1JR+SGVvk6tBo= X-Received: by 2002:ac2:5b41:0:b0:4b5:5f2b:ddf6 with SMTP id i1-20020ac25b41000000b004b55f2bddf6mr3147400lfp.17.1673619441091; Fri, 13 Jan 2023 06:17:21 -0800 (PST) MIME-Version: 1.0 References: <20230110100305.1420589-1-arsen@aarsen.me> <86mt6q4ajt.fsf@aarsen.me> In-Reply-To: <86mt6q4ajt.fsf@aarsen.me> From: Jonathan Wakely Date: Fri, 13 Jan 2023 14:17:09 +0000 Message-ID: Subject: Re: [PATCH 1/2] libstdc++: Enable string_view in freestanding To: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= Cc: Jonathan Wakely , "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 10 Jan 2023 at 16:31, Arsen Arsenovi=C4=87 via Libstdc++ wrote: > > Hi Jonathan, > > Jonathan Wakely writes: > > > Sorry for the top post. > > > > -#define __cpp_lib_string_contains 202011L > > +#if _GLIBCXX_HOSTED > > + // This FTM is not hosted as it also implies matching > > support, > > + // and is omitted from the freestanding subset. > > +# define __cpp_lib_string_contains 202011L > > +#endif // HOSTED > > > > That should say "not freestanding", right? > > Whoops, yes. Here's the fixed-up patch. Tested powerpc64le-linux and pushed to trunk, thanks!