From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BF7B73858D20 for ; Thu, 7 Sep 2023 16:28:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF7B73858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694104138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JO444y1Sq9y/PpfQqDUtqGO+0J1tbLeRrxluF3JrWCY=; b=fk8YN2zKtIr4JMz0HqARxWJT0m6RfZzSfrq3GHBhfc1ItzUs8FD0XABvSCaNJG8KPT8jKM bpeyQFvOxJ86HHoKBQosDXGrGVAPsyIXPyQVC4wh8WlD8RKfi/SnD2lvSJyoZZJScnWUSN XWkx9AZN/hP8J8TRpsJZgMd+8mW3zG8= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-546-TihnKbUHNTqZIRWDRcKlNA-1; Thu, 07 Sep 2023 12:28:56 -0400 X-MC-Unique: TihnKbUHNTqZIRWDRcKlNA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ba1949656bso14120911fa.0 for ; Thu, 07 Sep 2023 09:28:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694104135; x=1694708935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JO444y1Sq9y/PpfQqDUtqGO+0J1tbLeRrxluF3JrWCY=; b=CwJJcxRUcUk1DpxucOWFDy8dozLV7vNDi4MRSmghTLkIIMBxytp2i7LtF0KI8o61FD 6Z5F09ROKo4PpyRGQ/YWvNpVB0KyaqPydXcZA1tZ1HagIA3AwLXIpX4EN7iXSinnFx+V 32YZ1SOW1gyrb/ltpqFkqkmjRMArA/5vQIN/NcS9p78of+EZDlBgiuIXlH7tZfxQTxP3 qHATjf1dvOSY6pBCkgJwG94O/VcJBlnLOcVuQ9rHLyunLauSiw/x8tpMBbgNYry0vCZZ 49ShBPzMnX/E0/rEgFDLtXJk4SnO7vWUjstcRjhGTR5htZ8s0s6Zq8ud4Kv2mu/C9WCE kyTA== X-Gm-Message-State: AOJu0YwJWvB1l3smGUc1WmXgntiAjXSOAnECYWQJeRTit5HEzWatZwh5 1klGoRjIlnXR7SlmprUywyoPhFRQyp9GMWx/zm6F9uKJUMcZQCC1NLKkNCdfzt/FlwOs14tqmjZ ycKopFz3POzDqw4iEfb7PEv3XQi1stMw= X-Received: by 2002:a2e:9c10:0:b0:2bc:b70d:9cb5 with SMTP id s16-20020a2e9c10000000b002bcb70d9cb5mr4941891lji.33.1694104135418; Thu, 07 Sep 2023 09:28:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWKBA7m3x2AOrZkS2QmReJJSZa/rteTrcK9W6c+utGSmz1b2dTZSK5UaCRq6KKPgXYG/W8ZbFGszNeND+HMkw= X-Received: by 2002:a2e:9c10:0:b0:2bc:b70d:9cb5 with SMTP id s16-20020a2e9c10000000b002bcb70d9cb5mr4941885lji.33.1694104135130; Thu, 07 Sep 2023 09:28:55 -0700 (PDT) MIME-Version: 1.0 References: <86leeb9jtz.fsf@aarsen.me> In-Reply-To: From: Jonathan Wakely Date: Thu, 7 Sep 2023 17:28:44 +0100 Message-ID: Subject: Re: [PATCH] libstdc++ Add cstdarg to freestanding To: "Paul M. Bendixen" Cc: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 18 Aug 2023 at 20:14, Paul M. Bendixen wro= te: > > Hi > Jonathan, I just went over the proposal again as well as [compliance], wh= ich Arsen mentioned ( https://wg21.link/compliance ) don't seem to mention = either or . Those headers were freestanding in C++17. They're not present in C++20 and C++23, but we support C++17 and earlier standards. In GCC 12 and were both installed when you built the library with --disable-hosted-libstdcxx, so the fact they're no longer installed for a freestanding build in GC 13 is a regression. Please do include them. > > Shouldn't I just stick to the ones we know are in? > > (Still working on figuring out how to do the change log thing) > > Best regards > Paul > > Den ons. 16. aug. 2023 kl. 18.50 skrev Paul M. Bendixen : >> >> Yes, the other files are in another committee proposal, and I'm working = my way through the proposals one by one. >> Thank you for the feedback, I'll update and resend >> /Paul >> >> Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenovi=C4=87 : >>> >>> >>> Jonathan Wakely writes: >>> >>> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ >>> > wrote: >>> >> >>> >> P1642 includes the header cstdarg to the freestanding implementation= . >>> >> This was probably left out by accident, this patch puts it in. >>> >> Since this is one of the headers that go in whole cloth, there shoul= d be no >>> >> further actions needed. >>> > >>> > Thanks for the patch. I agree that should be freestanding, >>> > but I think and were also missed from the >>> > change. Arsen? >>> >>> Indeed, we should include all three, and according to [compliance], >>> there's a couple more headers that we should provide (cwchar, cstring, >>> cerrno, and cmath, but these are probably significantly more involved, >>> so we can handle them separately). >>> >>> As guessed, the omission was not intentional. >>> >>> If you could, add those two to the patch as well, edit Makefile.am and >>> regenerate using automake 1.15.1, and see >>> https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. >>> >>> Thank you! Have a lovely day :-) >>> >>> [compliance]: https://eel.is/c++draft/compliance >>> >>> > Also, the patch should change include/Makefile.am as well (the .in >>> > file is autogenerated from that one). >>> > >>> > >>> >> This might be related to PR106953, but since that one touches the pa= rtial >>> >> headers I'm not sure >>> >>> The headers mentioned in this PR are provided in freestanding, >>> partially, in 13 already, indeed. >>> >>> >> /Paul M. Bendixen >>> >> >>> >> -- >>> >> =E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92/=E2=80= =A2 =E2=80=A2 =E2=88=92/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2=88=92 = =E2=80=A2 =E2=80=A2 =E2=80=A2/=E2=80=A2/=E2=88=92 =E2=80=A2/=E2=88=92 =E2= =80=A2 =E2=80=A2/=E2=80=A2 =E2=80=A2/=E2=88=92 =E2=80=A2 =E2=80=A2 =E2=88= =92/=E2=80=A2/=E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2= =E2=88=92 >>> >> =E2=80=A2/=E2=88=92 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92/=E2=80= =A2 =E2=88=92/=E2=80=A2 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/= =E2=80=A2 =E2=88=92 =E2=80=A2 =E2=88=92 =E2=80=A2 =E2=88=92/=E2=88=92 =E2= =80=A2 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92 =E2=88=92/=E2=88=92 =E2=88= =92// >>> >>> >>> -- >>> Arsen Arsenovi=C4=87 >> >> >> >> -- >> =E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92/=E2=80=A2 = =E2=80=A2 =E2=88=92/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2=88=92 =E2= =80=A2 =E2=80=A2 =E2=80=A2/=E2=80=A2/=E2=88=92 =E2=80=A2/=E2=88=92 =E2=80= =A2 =E2=80=A2/=E2=80=A2 =E2=80=A2/=E2=88=92 =E2=80=A2 =E2=80=A2 =E2=88=92/= =E2=80=A2/=E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2=E2=88= =92 =E2=80=A2/=E2=88=92 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92/=E2=80=A2 = =E2=88=92/=E2=80=A2 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2= =80=A2 =E2=88=92 =E2=80=A2 =E2=88=92 =E2=80=A2 =E2=88=92/=E2=88=92 =E2=80= =A2 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92 =E2=88=92/=E2=88=92 =E2=88=92// > > > > -- > =E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92/=E2=80=A2 =E2= =80=A2 =E2=88=92/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2=88=92 =E2=80= =A2 =E2=80=A2 =E2=80=A2/=E2=80=A2/=E2=88=92 =E2=80=A2/=E2=88=92 =E2=80=A2 = =E2=80=A2/=E2=80=A2 =E2=80=A2/=E2=88=92 =E2=80=A2 =E2=80=A2 =E2=88=92/=E2= =80=A2/=E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2=E2=88=92= =E2=80=A2/=E2=88=92 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92/=E2=80=A2 =E2= =88=92/=E2=80=A2 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2=80= =A2 =E2=88=92 =E2=80=A2 =E2=88=92 =E2=80=A2 =E2=88=92/=E2=88=92 =E2=80=A2 = =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92 =E2=88=92/=E2=88=92 =E2=88=92//