From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 69C643858D35 for ; Wed, 1 Feb 2023 17:19:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69C643858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675271965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f1QCDN5D6l4XH+owqkCrRv6izvws5Z3/OO2VP/+r3/M=; b=GKlPK0py0KdluNdv4j+JrLnF2Xk8Cmqa0C3v2P6BLVcEILJOR8SmguPvtG0dXHERJK9Sx0 Fm8GaP57OvpROiAmEElqAfp9jEGvg4UdKAXDV8w5BubuqQztFKacprrxcYZLSgwFSypNNY rn/p9vD5z1W4Q0IwrTg2xuJ+R1Fb3GM= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-64-mpSbHO6vNHaYc6p3hSEKNQ-1; Wed, 01 Feb 2023 12:19:23 -0500 X-MC-Unique: mpSbHO6vNHaYc6p3hSEKNQ-1 Received: by mail-lj1-f198.google.com with SMTP id s22-20020a2eb8d6000000b002905bd2a7b1so2628576ljp.9 for ; Wed, 01 Feb 2023 09:19:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f1QCDN5D6l4XH+owqkCrRv6izvws5Z3/OO2VP/+r3/M=; b=c4GudCxKGoCUSgieDtnD78BtWj6UuHnCtH5qEMGEVxc8RTNr6loisdi7rcFU96Debe o+lzx8upgFkIDzZ7KmykYvpUOM6F+O2n+eUBPG+1HcYZPzVr1eJ8MPwpGOiNLTxRc1xZ 9iSCG6Rog8ZU2Z5grD7vzarIGa0md2Du5/kXLeHo8MwBS8VxygwrDNnpP+DVyJ/seysC 4EeNqzAeXAOJcITTyn0qIezeCCb00XGXDIM4XsPuUgg7R7VlFPjwIMExqppcoU47USA4 ZE00QEt9jGkA383MyhKMY56fQFWbeFnJgidsF10kz1J/atqWmg6N5Sn5LtAZm8eSjFFX Anog== X-Gm-Message-State: AO0yUKXTMTEzWasG90/NCG0RF0dH/hamdDmYnRXPC344/bZtpNcHehQP 5zs1EOArCNp5LttykNzarIIkkoltcz8um+7SsHTZB6Un8FQ/T7EWVyf5BT1NUO59cIcJyZuTBaG Y+uU11rJ//oX/pmt7RFtdiorZjGec6dg= X-Received: by 2002:a05:6512:74c:b0:4d8:58f0:b530 with SMTP id c12-20020a056512074c00b004d858f0b530mr589673lfs.2.1675271961099; Wed, 01 Feb 2023 09:19:21 -0800 (PST) X-Google-Smtp-Source: AK7set8+Pf/eEqM6AyHuzbMNJpDRwykFM2iPXd5qtoUH7J4qtuZqaANC70c3G4AEne+p6P9+IsIn7P0A3mYA0EaOC9k= X-Received: by 2002:a05:6512:74c:b0:4d8:58f0:b530 with SMTP id c12-20020a056512074c00b004d858f0b530mr589669lfs.2.1675271960860; Wed, 01 Feb 2023 09:19:20 -0800 (PST) MIME-Version: 1.0 References: <20230201143831.BDA3A20423@pchp3.se.axis.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 1 Feb 2023 17:19:09 +0000 Message-ID: Subject: Re: [PATCH] libstdc++ testsuite: Correct S0 in std/time/hh_mm_ss/1.cc To: Hans-Peter Nilsson Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 1 Feb 2023 at 16:01, Jonathan Wakely wrote: > > On Wed, 1 Feb 2023 at 14:38, Hans-Peter Nilsson via Libstdc++ > wrote: > > > > Tested cris-elf and native x86_64-pc-linux-gnu. > > Ok to commit? > > OK, thanks. We could add the [[no_unique_address]] attribute to the _M_ss member, so that it takes no space when it's an empty struct. That would save a byte in hh_mm_ss for cris-elf and targets like that, but as this type isn't meant to be used for storage, I don't think we should bother. People shouldn't be using this as a data member, just creating it on the stack and then discarding it.