From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 421B2385703F for ; Mon, 14 Nov 2022 14:13:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 421B2385703F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668435209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KMRmOI2qDQnvGJfV2njK3m0yfk8D75zZCCnDeWY0TmI=; b=Ztusvo/YN6+wV8eN2Kj/4gPTZ9IalgqXEno5A+FsZ0J51u66pXb5mDgEsI/2wXu169k3e8 G/NWKIddiMYoCqmKFJuv02Q9fYE2HllhhlQIjIl4Lqw2cFsPdAYjoQkgxPnfYTlVEisBdQ 4FkKph+kGGMCqejslGvUE0eaJRreHeY= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-592-1ASLHYKOOtSTjFCjgLOAxg-1; Mon, 14 Nov 2022 09:13:28 -0500 X-MC-Unique: 1ASLHYKOOtSTjFCjgLOAxg-1 Received: by mail-ej1-f72.google.com with SMTP id xc12-20020a170907074c00b007416699ea14so5477568ejb.19 for ; Mon, 14 Nov 2022 06:13:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KMRmOI2qDQnvGJfV2njK3m0yfk8D75zZCCnDeWY0TmI=; b=lguVAV9XM9EgXrgBKOn2t49+kdEohNNtM2QKFt8Bh5GZATDEe9+x3IEFSLHTl1pDtw 8YnTEXLwDYuDd75fT/NOfGB7R6vbIQvYLoEfVwfDK9LJIr1XhJCrKBPJMUCVD/KrJ9Ua XNGU/q8K+ToJliLjvZ6sZN5xxiJEHtPGYD9a/AcvESBTHLlFcSkpJH6CTw8iZ26WhadB caitdcHhicHvIzifocK/idgfYEsalKYj/4B/gafVKIa/1YbRktbYdc0i2HWVAgCSObrF 5Fp50a4SktNQhF6RbdqwR5C4Dwi2nGorkuc0LT++me1/qrnjp450PCFkv1h/1abNTP3J TAJg== X-Gm-Message-State: ANoB5pkS+9cjXZsP/+mrIQNPW4UQKzUIpW0rSUnoxnA5jptDKAYgbgbD tkkn7zXgSVDA/64zJYgpIxr1Hbj5pJtyDaQqoxhNaNJGISuS/YiENSEokkMy7xUIJ+JMsFD/iH5 h58hJ+lJqYF2LMlbFttXcZ4PTLEiOafw= X-Received: by 2002:aa7:cf08:0:b0:461:a09b:aaf2 with SMTP id a8-20020aa7cf08000000b00461a09baaf2mr11022207edy.328.1668435207447; Mon, 14 Nov 2022 06:13:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf6g4cRcXZxrvO085JQ5hS07ih+L44wnO9akIyDqYn+ODvwtFSVDor1ZSdLZZBph1HCdmlppuIf8R8dNfQMI1Yo= X-Received: by 2002:aa7:cf08:0:b0:461:a09b:aaf2 with SMTP id a8-20020aa7cf08000000b00461a09baaf2mr11022187edy.328.1668435207198; Mon, 14 Nov 2022 06:13:27 -0800 (PST) MIME-Version: 1.0 References: <20221113180527.2907744-1-arsen@aarsen.me> <86wn7xvfj1.fsf@aarsen.me> In-Reply-To: <86wn7xvfj1.fsf@aarsen.me> From: Jonathan Wakely Date: Mon, 14 Nov 2022 14:13:16 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories To: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 14 Nov 2022 at 13:20, Arsen Arsenovi=C4=87 wrote: > > Hi, > > Jonathan Wakely writes: > >> This looks simple, and more consistent with what we already do. Does > >> it solve your issue? > > It does work; though, if I was more daring I'd have said that it's fine > without checking, too, since it does the same operation on the same > directory ;) > > Was the omission of the mkdir $(DESTDIR)$(toolexeclibdir) intentional? It's the first thing the recipe does: install-data-local: gdb.py @$(mkdir_p) $(DESTDIR)$(toolexeclibdir) That's why I'm suggesting to do the same thing for the debug dir. > I only see TELD/debug in your revision of the patch. Chances are, it > gets created elsewhere (my test was just install-target-libstdc++-v3, so > not even the full install), but it might be worth being conservative > about it. > > Thanks, > -- > Arsen Arsenovi=C4=87