From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E97083858C66 for ; Thu, 12 Jan 2023 12:05:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E97083858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673525115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0NT5PR8pPUdrbjTxl3KeAqsXaZP6RfNDMFexoL752vw=; b=Rm63apHx88tjRcJ8IasVOWRpnc4q5LMuJ/IBxQiPxz8QUSmW76wKkR5fhntFrfIMre0z0m tbT06NHfgy62Q3lTZfmSPaH25NC1797f8sd8wJsl4JcbtZTQfeWb/jN4W6XCrKi/zAi56D HnIWAHDew5m6Bf1Ztegg7skDfIjacGo= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-30-TIQtTd0VMum15958hzvkWQ-1; Thu, 12 Jan 2023 07:05:14 -0500 X-MC-Unique: TIQtTd0VMum15958hzvkWQ-1 Received: by mail-lf1-f69.google.com with SMTP id bq3-20020a056512150300b004b9c5dff97bso6924635lfb.17 for ; Thu, 12 Jan 2023 04:05:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0NT5PR8pPUdrbjTxl3KeAqsXaZP6RfNDMFexoL752vw=; b=xRSe+lkWjgTEvEfTzXw8EHJ6ZYsYbzy3HZ1cWGoVBQWXc94TrNHwR1ZAzgrLOkw0cx 3X2xGNio+eblpHTDGnTuFJ6earALlS+z2Ut4aIz8qxnKi1cC82edvNFA7Ym9tbeW7fyG rrP7S3ngZJe9fN/EDoNgxtbVPG/ZWI9nZiEA87H7wFJg68FV28URFoMGwVCH2d5cOvNp 1r9ELOyqVTxTYvmCIPDWJtF7IO4S720wG1ylT5EKRrvUdk1GlXhtqEVBy+EuTcOhOVNp bA8F19OddR9oDP3vLOIKQ8c/o2z7LJzpsebyAxJ4vkLysT/ed5CwJDXP82cqz8/KLLie UXEA== X-Gm-Message-State: AFqh2kqCvmhiqANv8ejVdGIZmBubNr/ng1LK2jlCx7v2VVavQy0byFMe x/yQ+wFFsrX37HOuMbDPkmrazV1IfMkRDjO1OOPE13/rKCrQVzpDRdSkx29COqKj1EFH/ru7iNE qSorEuKO5PGQ5CThYnAewNXENlJNVaGg= X-Received: by 2002:a05:651c:384:b0:27f:e894:685a with SMTP id e4-20020a05651c038400b0027fe894685amr2104578ljp.444.1673525113010; Thu, 12 Jan 2023 04:05:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXushTMOSToYwegpXhc1V29dD+yJNsNlUNvwougxYnwQPg5PRfScbkhuB/4ntLRwtMmXz1WbGklGXihDGzfw0Pk= X-Received: by 2002:a05:651c:384:b0:27f:e894:685a with SMTP id e4-20020a05651c038400b0027fe894685amr2104574ljp.444.1673525112858; Thu, 12 Jan 2023 04:05:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Thu, 12 Jan 2023 12:05:01 +0000 Message-ID: Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Adapt to_chars/from_chars symbols To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 28 Nov 2022 at 20:44, Fran=C3=A7ois Dumont wrote: > > On 28/11/22 19:35, Jonathan Wakely wrote: > > > > On Mon, 28 Nov 2022 at 06:07, Fran=C3=A7ois Dumont via Libstdc++ wrote: >> >> This patch is fixing those tests: >> >> 20_util/to_chars/float128_c++23.cc >> std/format/formatter/requirements.cc >> std/format/functions/format.cc >> std/format/functions/format_to_n.cc >> std/format/functions/size.cc >> std/format/functions/vformat_to.cc >> std/format/string.cc >> >> Note that symbols used in for __ibm128 and __iee128 are unteste= d. > > > We don't need to do this for those symbols, the ALT128 config is incompat= ible with versioned namespace. If you're using the versioned namespace, you= don't need backwards compatibility with the old long double ABI. > > > > > Here is the simplified patch then. > > libstdc++: [_GLIBCXX_INLINE_VERSION] Add to_chars/from_chars symbols = export > > libstdc++-v3/ChangeLog > > * include/std/format [_GLIBCXX_INLINE_VERSION](to_chars): Ada= pt __asm symbol > specifications. > * config/abi/pre/gnu-versioned-namespace.ver: Add to_chars/fr= om_chars symbols > export. > > Ok to commit ? I still don't understand why the linker script change is needed, but I can investigate that myself later. OK for trunk, thanks.