From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Implement ranges::join_with_view from P2441R2
Date: Tue, 4 Oct 2022 12:37:58 +0100 [thread overview]
Message-ID: <CACb0b4kTi0xng0t9TerTAe_iW5vzNaMfPdbpvT7WdFj+V8DHWA@mail.gmail.com> (raw)
In-Reply-To: <20221004011115.2009591-1-ppalka@redhat.com>
On Tue, 4 Oct 2022 at 02:11, Patrick Palka via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> Tested on x86_64-pc-linux-gnu, does this look OK for trunk? FWIW using
OK, thanks.
> variant<_PatternIter, _InnerIter> in the implementation means we need to
> include <variant> from <ranges>, which increases the preprocessed size
> of <ranges> by 3% (51.5k vs 53k). I suppose that's an acceptable cost?
Yeah, I don't think we want to reimplement a lightweight std::variant,
because that would just add even more code.
As I mentioned on IRC, maybe we could optimize the compilation time
for some of the visitation using P2637R0, but that can be done later.
next prev parent reply other threads:[~2022-10-04 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 1:11 Patrick Palka
2022-10-04 11:37 ` Jonathan Wakely [this message]
2022-10-04 14:08 ` Patrick Palka
2022-10-04 14:38 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4kTi0xng0t9TerTAe_iW5vzNaMfPdbpvT7WdFj+V8DHWA@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).