From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 08CD1385480C for ; Thu, 17 Aug 2023 23:30:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08CD1385480C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692315028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PZvzvfTR28FdqYXYs0Wr5+XJWE0COuUHhhOmF6K/xKM=; b=T7HF6YjvhH8WrwuMQALfSe0Ma3x0LWbclGxVmNcE51HGYKKoWJO5c9Jj1so5dpev/6heNx deQTq02mMIWskYIF0vDViRYhyRY+5Pcye55qEx5f4LvyO9liaUmz6tNdBbb2xAi38+pnCy 0gg13KZsMJTd3XMrBz93n5HW5+04+Gs= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-rxIof8ZqNZOzpucxw1aRiA-1; Thu, 17 Aug 2023 19:30:26 -0400 X-MC-Unique: rxIof8ZqNZOzpucxw1aRiA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ba0f144938so3669381fa.3 for ; Thu, 17 Aug 2023 16:30:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692315025; x=1692919825; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PZvzvfTR28FdqYXYs0Wr5+XJWE0COuUHhhOmF6K/xKM=; b=FkVclCBDUu22OIWzyMS+oiiGugQvyPYM3/aAF/F9WjlUGAi5FeFmJ2mKg+VFpiU5sM /gkqMCaaKtIBuo80GN7bg/y0TGo5l5iP/Kb4egbFuDVeCaSdRbmpq0nkwvQTPs3nuoG1 yiqzaH5uKTzb+3oWnRmcyzOzJJtvGTvmwGnMj3ONYoPesgrmxsbgqW/1HKwyV9Fq/U2/ omiFwUzoXtCr2gkyV/LuTZKxp8ttPqDTDR2XAmu0NvHFqDJZQhUXHqC7vvyaEiz21SCR DCgVsSGbF6eKiiKrAu17yK7PDt5mOtJXS4j2O2ooLjYEPlt2VPFBwDDpUI1hmNmyZKFC p79A== X-Gm-Message-State: AOJu0YyK0Y1oPbH0uvOgg9YAKDpjOJLqlQWqAqHPGN50OWqxDVLq8uwt 3JarDG7BsbyVnPKV7vwFrk4tMPO6DvrrFwJINX4MF3kDRXOOXeCtX4nBqkf8wmilzSRpnnVCust x19VKWOmywOtmGbaesnJeo9doYLVu/zo= X-Received: by 2002:a2e:80c7:0:b0:2b6:e2aa:8fbc with SMTP id r7-20020a2e80c7000000b002b6e2aa8fbcmr563559ljg.8.1692315025359; Thu, 17 Aug 2023 16:30:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEA3B92CtNxL2DRQUayfnxqNZ94CaAV7JZutFvOPZa74mp8SNLuAHXxgUHsAUS2MlILgyuRPwPbFGOFSU7fekM= X-Received: by 2002:a2e:80c7:0:b0:2b6:e2aa:8fbc with SMTP id r7-20020a2e80c7000000b002b6e2aa8fbcmr563547ljg.8.1692315024979; Thu, 17 Aug 2023 16:30:24 -0700 (PDT) MIME-Version: 1.0 References: <20230817203237.1131595-1-jwakely@redhat.com> <20230817231932.EEB372041D@pchp3.se.axis.com> In-Reply-To: <20230817231932.EEB372041D@pchp3.se.axis.com> From: Jonathan Wakely Date: Fri, 18 Aug 2023 00:30:14 +0100 Message-ID: Subject: Re: [committed] libstdc++: Reuse double overload of __convert_to_v if possible To: Hans-Peter Nilsson Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 18 Aug 2023 at 00:20, Hans-Peter Nilsson wrote: > > > Date: Thu, 17 Aug 2023 21:32:29 +0100 > > From: Jonathan Wakely via Gcc-patches > > > Tested x86_64-linux. Pushed to trunk. > > Does the below typo imply that for x86_64-linux, > "__DBL_MANT_DIG__ =3D=3D __LDBL_MANT_DIG__" is false and the > code is actually untested? Yes, but I thought I'd tested it on a suitable cross-compiler last week. I've reverted it for now (at r14-3310-gb860e657802b96) and will retest next week. > > > libstdc++-v3/ChangeLog: > > > > * config/locale/generic/c_locale.cc (__convert_to_v): Reuse > > double overload for long double if possible. > > Breakage for cris-elf: > > libtool: compile: /auto/cris-elf/gccobj/./gcc/xgcc -shared-libgcc -B/aut= o/cris-elf/gccobj/./gcc -nostdinc++ -L/auto/cris-elf/gccobj/cris-elf/libstd= c++-v3/src -L/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/src/.libs -L/auto/= cris-elf/gccobj/cris-elf/libstdc++-v3/libsupc++/.libs -nostdinc -B/auto/cri= s-elf/gccobj/cris-elf/newlib/ -isystem /auto/cris-elf/gccobj/cris-elf/newli= b/targ-include -isystem /auto/gcc/newlib/libc/include -B/auto/cris-elf/gcco= bj/cris-elf/libgloss/cris -L/auto/cris-elf/gccobj/cris-elf/libgloss/libnosy= s -L/auto/gcc/libgloss/cris -B/auto/cris-elf/pre/cris-elf/bin/ -B/auto/cris= -elf/pre/cris-elf/lib/ -isystem /auto/cris-elf/pre/cris-elf/include -isyste= m /auto/cris-elf/pre/cris-elf/sys-include -I/auto/gcc/libstdc++-v3/../libgc= c -I/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/include/cris-elf -I/auto/cr= is-elf/gccobj/cris-elf/libstdc++-v3/include -I/auto/gcc/libstdc++-v3/libsup= c++ -std=3Dgnu++98 -fno-implicit-templates -Wall -Wextra -Wwrite-strings -W= cast-qual -Wabi=3D2 -fdiagnos > tics-show-location=3Donce -ffunction-sections -fdata-sections -frandom-s= eed=3Dc++locale.lo -g -O2 -fimplicit-templates -c c++locale.cc -o c++locale= .o > c++locale.cc: In function 'void std::__convert_to_v(const char*, _Tp&, io= s_base::iostate&, int* const&) [with _Tp =3D long double; ios_base::iostate= =3D ios_base::iostate; __c_locale =3D int*]': > c++locale.cc:192:49: error: expected primary-expression before ')' token > 192 | __convert_to_v(__s, __d, __err, __c_locale); > | ^ > make[5]: *** [Makefile:881: c++locale.lo] Error 1 > make[5]: Leaving directory '/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/s= rc/c++98' > > (Formally, a commit in the range ee40bdbfb07c..aad83d61d2e9 > but this one seems pretty clear.) > > In the context: > __convert_to_v(const char* __s, long double& __v, > ios_base::iostate& __err, const __c_locale&) throw() > > So, __c_locale" appears to be the type(def) and you're > missing a parameter name. :) > > brgds, H-P >