From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 27EFF3858D39 for ; Wed, 20 Sep 2023 09:32:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27EFF3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695202339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8xpmgx7fq4DCJMa9GXEVnWaFddGAtMUjt2DC3JM2AZU=; b=NSVUKxXWpC+IotZIt+N4HEMWt3bbXCF7PTfLXj0+A+jJLnzUgSdkaK+J1DmrDJklYKcCoX AI32GG8DxMw8kzbH/hKVPFsVFQVRBgtJBP2OaUICX2NxN8Pp8jWfhkGEDxXkuU8SeanAGL ZtAeuokRE4npOeUWHla/fOJLQNyGxXw= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-NKjDa9wzM0O1a6GaiAVuaQ-1; Wed, 20 Sep 2023 05:32:18 -0400 X-MC-Unique: NKjDa9wzM0O1a6GaiAVuaQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2bfeaf8cc4bso52777541fa.0 for ; Wed, 20 Sep 2023 02:32:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695202336; x=1695807136; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8xpmgx7fq4DCJMa9GXEVnWaFddGAtMUjt2DC3JM2AZU=; b=Q5YygnRK3Oda4pi/z8U/aPaEs5UuTWeSsrCCWETh28FU6WVF8Zd3OVfncA/3RbGcbI opAgNGuGyvW+fKYMZV/nS6euBwYcD1FoRUjBSNASyWlnmPhrLJlY2hnjh4U6BP6iFvDk R8tK0usMVq3RH9lTyZgixmcYJ8a0dOqc2QPOJP3Y9F0/77TJFQ1O7+QURZXrwlDJ0vaE 6eep+FBPoNaiNmLlxRbdkDQj8xc7zRFkgQHb/UgqObUMT2fWQqDIQ7dTqVRhBcPI07up Kqbi7eGeAi7iU76a7WwpDBrdBzzuFAsO8ZJcpifORo1Soj9oiwssT01V7DV95malIGQj UREQ== X-Gm-Message-State: AOJu0YzXt82LFCrlH9lFcHR9Ln/qIzsZRyh9B1PprWQXGip5ErSS9o3e pASvqVu6EgTIoplzRBeq/oxCh3VLFQYNthjmkwIAqPJ0lWB8/BwVNAIgJL/A1V8qxzMamevFA8l 8pL+bL9wyuqjCnEqfEeevayOgIjMYKK0= X-Received: by 2002:a2e:a0d6:0:b0:2c0:a0c:be7 with SMTP id f22-20020a2ea0d6000000b002c00a0c0be7mr1737367ljm.8.1695202336745; Wed, 20 Sep 2023 02:32:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLDSLVACVOFNU8ccpwj7w1epa2OpWr/D7AU3ysGtdoYNggJBdpNRGnH/byedOFxyDzzpZLwJccdmRNddeMBNw= X-Received: by 2002:a2e:a0d6:0:b0:2c0:a0c:be7 with SMTP id f22-20020a2ea0d6000000b002c00a0c0be7mr1737338ljm.8.1695202336342; Wed, 20 Sep 2023 02:32:16 -0700 (PDT) MIME-Version: 1.0 References: <55f0212a-f8d3-aa9e-8788-f5165484ac6c@gmail.com> In-Reply-To: <55f0212a-f8d3-aa9e-8788-f5165484ac6c@gmail.com> From: Jonathan Wakely Date: Wed, 20 Sep 2023 10:32:05 +0100 Message-ID: Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 20 Sept 2023 at 05:51, Fran=C3=A7ois Dumont via Libstdc++ wrote: > > libstdc++: Remove std::constract_violation from versioned namespace Spelling mistake in contract_violation, and it's not std::contract_violation, it's std::experimental::contract_violation > > GCC expects this type to be in std namespace directly. Again, it's in std::experimental not in std directly. Will this change cause problems when including another experimental header, which does put experimental below std::__8? I think std::__8::experimental and std::experimental will become ambiguous. Maybe we do want to remove the inline __8 namespace from all experimental headers. That needs a bit more thought though. > > libstdc++-v3/ChangeLog: > > * include/experimental/contract: > Remove _GLIBCXX_BEGIN_NAMESPACE_VERSION/_GLIBCXX_END_NAMESPACE_VERSI= ON. This line is too long for the changelog. > > It does fix 29 g++.dg/contracts in gcc testsuite. > > Ok to commit ? > > Fran=C3=A7ois