From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EEF1D385840C for ; Wed, 30 Nov 2022 11:57:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEF1D385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669809442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rfMox2wirotGqEeSl1G11+JxPHK5PPJ64KRCkvIpuuE=; b=II2FvIzEE/isE6ZVEy+/7/bnSPDy0LRT8IVP2S5BrzcV/FuTk3Xhk6g9ElBhrVdf3spTXQ RrXMmTBVNEtEIpA4f9opTfGVNEGvvKgby+hxh/+yKU46QvpIIpwSfRjtjSdRA0jSIKJrRp +0gHwxk63MTHWebuTaPB+Wvd2vQSOR8= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-675-mqteVbUmMn2M3LjseZ8eKg-1; Wed, 30 Nov 2022 06:57:18 -0500 X-MC-Unique: mqteVbUmMn2M3LjseZ8eKg-1 Received: by mail-ed1-f69.google.com with SMTP id t4-20020a056402524400b004620845ba7bso9585507edd.4 for ; Wed, 30 Nov 2022 03:57:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rfMox2wirotGqEeSl1G11+JxPHK5PPJ64KRCkvIpuuE=; b=69ZalunZuJ8rjq8LctvEwcv0xmSo0NcLAY2AtwXVE+tDHSExlNNbQswER++FLBi07T 91H4OqabGoSkJVYtUV3AdLWkehxstrtiOJCcVLouf6r4PangRimIyq+5RnZZG7Q1ymB8 bb38CG4K8EvmVz6Vu75bK69LLiNtuBV2V0WNVkNvq8lsr4yuOz0kLcfl0wcmzhcpkBIB e6wOPKOlTG5WW8b1S0zu96yY3DYMAgs3DpE3QRK/i8sZ12/9eLKGfHczquZzo8e6FVjI chu3pk70hSI2acZ6JD9IchV/JkhiFNvgFNjDYxA2TtA/v3MTcHvidC/nkc34RO2tNGhJ 7anA== X-Gm-Message-State: ANoB5pnzZ7b9rCf1ZOZbWqxdWPzgLlNGLkxBshxYgsHy3XyLZoiqyZyB UWGS4LowNUxFHNmdyd3avFiPM5PtZgVJ51sKHUqyZzdeJ3tPPmeHg9hAUtZv3fluFv12aLopeeN AEEy6SRylOAmWOSYb/K8zktO6VcMCht8= X-Received: by 2002:a05:6402:2912:b0:46a:c132:8a25 with SMTP id ee18-20020a056402291200b0046ac1328a25mr22961220edb.205.1669809437644; Wed, 30 Nov 2022 03:57:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf6yQfvmKpZBAP/FRzra/hlwjs82obZJcQpL4GGWsHKYo3cM33rIRf1zVrbd8grSnbv3T9N4d6GNlUId/6+VXXs= X-Received: by 2002:a05:6402:2912:b0:46a:c132:8a25 with SMTP id ee18-20020a056402291200b0046ac1328a25mr22961212edb.205.1669809437518; Wed, 30 Nov 2022 03:57:17 -0800 (PST) MIME-Version: 1.0 References: <20221129214107.25572-1-gcc@hazardy.de> In-Reply-To: From: Jonathan Wakely Date: Wed, 30 Nov 2022 11:57:06 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Add error handler for To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: =?UTF-8?B?QmrDtnJuIFNjaMOkcGVycw==?= , gcc-patches@gc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000005dc24205eeaece4a" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000005dc24205eeaece4a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely wrote: > > > On Wed, 30 Nov 2022 at 06:04, Fran=C3=A7ois Dumont via Libstdc++ < > libstdc++@gcc.gnu.org> wrote: > >> Good catch, then we also need this patch. >> > > Is it worth printing an error? If we can't show the backtrace because of > an error, we can just print nothing there. > > We also need to pass an error handler to the > __glibcxx_backtrace_create_state call in formatter.h. > > Now that I look at this code again, why do we need the _M_backtrace_full > member? It's always set to the same thing, why can't we just call that > function directly? > Oh right, I remember now ... because otherwise the libstdc++.so library needs the definition of __glibcxx_backtrace_full. > And I think we should use threaded=3D1 for the > __glibcxx_backtrace_create_state call. > > So like the attached patch. > > > --0000000000005dc24205eeaece4a--