From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8950D3840911 for ; Tue, 13 Dec 2022 09:50:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8950D3840911 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670925036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ptBdzfVs2jX/sC5ugFjNBGxv+9p0uPq573BvITlxeVQ=; b=HJd1RlpGCzpf7eb8m3kd9okZpbmtvBFv2EywZLDnolPpDtxRaWNk07nVdLmAyFqYdk6X+o mk2naiPf3m2PsvFhvO4VAQ1Az6031iTMDGWdgDRgUC5qkoz4vZPfWr9IhhB99R1RCCJz/B fX39IhMw2VKH7CC93+mILfYTGaS4lz4= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-662-FksqQuxUOjqzaQC3Jkxa5Q-1; Tue, 13 Dec 2022 04:50:35 -0500 X-MC-Unique: FksqQuxUOjqzaQC3Jkxa5Q-1 Received: by mail-oo1-f70.google.com with SMTP id j2-20020a4a7502000000b0049bdd099de9so4758056ooc.0 for ; Tue, 13 Dec 2022 01:50:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ptBdzfVs2jX/sC5ugFjNBGxv+9p0uPq573BvITlxeVQ=; b=fntUfyRN0nSOdZSvea+Zo048eXDOLbqhFatDKwRlO6eBsUcAU4H/dpiy3uEM0yDG+S F2PGqHP+7+SN6GKIm4/tHXkOvaCiBImNb4lQXN+vj1AbOnbkiYsHLICLN7pIMYXhoQgW CMIU9e34Q3TuO5o/eW/mxdlsOZsq0234+0s+XsuH9RmN8NBqqvUl7v8MzFTqpuFz4TLp Nf/KK5T3VtXm2Gjmo1hd6N85Yuvx+u9N586Gl0P4e0WL9dNGNE8QtfZ6tgFPCAS0wDAw qmrPHDHnXnrcrg0/wPQnxtr70w2jCUQneeWMspTFFdMVE9H+F7TnwCa18rQwfqra3+8j JHBA== X-Gm-Message-State: ANoB5pkXvfxj4TxwlLYkUnnL330ywPus5fxs+4DS3ks7NhUUmhUcSTx8 fxZ2cRjn6LtyWbH47s3Kcf/6HyXikANutOBDCsVRBr1PRvsR5hxA7SLurkkJ9iTKm4Av4qZ7x7y AZCU0AV2v4SJaf5eb+v7D89OSe+f4MGg= X-Received: by 2002:a05:6808:1315:b0:354:4a36:aa32 with SMTP id y21-20020a056808131500b003544a36aa32mr128289oiv.15.1670925034416; Tue, 13 Dec 2022 01:50:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf6sa/MO993WduSCUFFZ8dP34MJmBoNc4WpuHzRW0k6AlImXPRHOHXP/9FpE/X3McjXY7KaF9A31ioij+r1WFTk= X-Received: by 2002:a05:6808:1315:b0:354:4a36:aa32 with SMTP id y21-20020a056808131500b003544a36aa32mr128287oiv.15.1670925034158; Tue, 13 Dec 2022 01:50:34 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Tue, 13 Dec 2022 09:50:23 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Update backtrace-rename.h To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 13 Dec 2022 at 09:44, Jakub Jelinek wrote: > > Hi! > > When writing the r13-4629 commit log I've realized that libsanitizer > isn't the only place which nowadays renames libbacktrace symbols, > libstdc++ does that too. > > Ok for trunk if this passes bootstrap/regtest? OK, thanks. When we move the backtrace symbols from libstdc++_libbacktrace.a into libstdc++.so we probably want to look into removing the symbols we don't actually use. Renaming them to our private namespace is good, but not including them in the library at all would be better. > 2022-12-13 Jakub Jelinek > > * src/libbacktrace/backtrace-rename.h (backtrace_uncompress_zstd): > Define. > > --- libstdc++-v3/src/libbacktrace/backtrace-rename.h.jj 2022-09-01 09:37:58.452624676 +0200 > +++ libstdc++-v3/src/libbacktrace/backtrace-rename.h 2022-12-13 10:41:14.551699599 +0100 > @@ -16,6 +16,7 @@ > #define backtrace_syminfo __glibcxx_backtrace_syminfo > #define backtrace_uncompress_lzma __glibcxx_backtrace_uncompress_lzma > #define backtrace_uncompress_zdebug __glibcxx_backtrace_uncompress_zdebug > +#define backtrace_uncompress_zstd __glibcxx_backtrace_uncompress_zstd > #define backtrace_vector_finish __glibcxx_backtrace_vector_finish > #define backtrace_vector_grow __glibcxx_backtrace_vector_grow > #define backtrace_vector_release __glibcxx_backtrace_vector_release > > Jakub >