From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 981303857B92 for ; Sat, 16 Dec 2023 16:40:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 981303857B92 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 981303857B92 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702744835; cv=none; b=pMI41bVEJRNX/e7SI+cIzav8YoFhhRmiBcngSzBkrbwxBs/up8EmE5oKv7IPlrM8q688GGISd4MyzdECluwTHV1mENvbOER2C/xuNEg5txnUfSzBZ0ppzmjWSrd9lEM0By+XQWiEnMSyg2Ov9nvk76OdRFaUJEqkJeljQen7nv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702744835; c=relaxed/simple; bh=rggOJOQKIlNkxmgJVP1LM0KypkPDekVwkS+jiBCFk+w=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=pXukK05l84/iS0z+ettX4F7kvgRGot6e/A567OGt3yW+v0xJM7XxPxcoCYLSISvHjFxAiY/DPRhl+RM61XA3qMMJaWfZ4BclTTTVWBjPkXgPjy/RnrQcyyHN1CLV6xm4JZ9xPEmF5FHejc9Uy89qrcFe7t+nmeZx5D6zc9FwEuY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702744834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hdTRLA7Y694hIfphwZwQHfs867fqjp+NJcV4eEewbTw=; b=gX81iogChKNI0PPsIjuh0KMmpi5nmBh+uN8QHX/SYGxCLyCBB2SUvmI8+q0eAO0dvDGcW4 P3dq9gNoQU+dw7Nrp7feQEf4+yzoXPz5tqGlqh2MNGUVu6T33vYioLmMgqB2aDOsE/O1E9 RFOMJ7n8TLf4YxzDHcIYylUil4ke4n4= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-yIXx4UHhO_qjN2uW9O4FBg-1; Sat, 16 Dec 2023 11:40:32 -0500 X-MC-Unique: yIXx4UHhO_qjN2uW9O4FBg-1 Received: by mail-yb1-f199.google.com with SMTP id 3f1490d57ef6-dbcda1ff95bso1429961276.3 for ; Sat, 16 Dec 2023 08:40:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702744832; x=1703349632; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hdTRLA7Y694hIfphwZwQHfs867fqjp+NJcV4eEewbTw=; b=SwA+IaayTHvnWMHpt/tMX01fk8nXk9wfKiK3pg7Z2s9i5lKZmYB9E35/DrxZR2YbEB bPRT4GaDGf6irPZ7WSNLmuSnoNCqf0kYP6a6+91+QcaiMeqNClPtKjvC9Rgsdr44/osP nYeiXyhz5jWwT6R/0ej+PZ3rXxIE+A6JOLdvXIuxk0AgkhzwnPU9FJ1xY8+yPw7s4whT /LJhBKXuVrcaba+vOA2/ycjPLH6C8tK7desZR3fRs5Xhku4FK3Dkvpfinel8nd3QjEAL vPaQjof3j1JZcpWmy7jmvZB1hdRO3zppCkGnrp4F233Y9YeAM+u+9NXCUJkJmZHwyFLz V2lg== X-Gm-Message-State: AOJu0YxUHMntPEvnVjEdAg7x4YOBKj9B+pNVAQLUi9tUc5KBIuoYklNC b/FkHobWkegqNJzQxoETM5NJracInMNIzmvanO+Sw7Q/EZeVy/zLG+VWKCNlaR7GIGgPfLjnncw 9dZyuwpXAOX2YojsreFwHY9I7dhwTHu8= X-Received: by 2002:a25:644:0:b0:dbc:eb39:4896 with SMTP id 65-20020a250644000000b00dbceb394896mr2071806ybg.65.1702744832071; Sat, 16 Dec 2023 08:40:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKbJDrmQ59bzcB6GM38/DeKgzMRI814jZtKDrWquArPKeH1bejRXebuGkiywo/XhaaQinQZSGF77QQbL6jUmI= X-Received: by 2002:a25:644:0:b0:dbc:eb39:4896 with SMTP id 65-20020a250644000000b00dbceb394896mr2071805ybg.65.1702744831814; Sat, 16 Dec 2023 08:40:31 -0800 (PST) MIME-Version: 1.0 References: <20231024020424.699427-1-kmatsui@gcc.gnu.org> <20231207051513.969952-1-kmatsui@gcc.gnu.org> <72a53d86-b4d8-4321-9e75-fe1f16099887@redhat.com> In-Reply-To: <72a53d86-b4d8-4321-9e75-fe1f16099887@redhat.com> From: Jonathan Wakely Date: Sat, 16 Dec 2023 16:40:15 +0000 Message-ID: Subject: Re: [PATCH v26 00/23] Optimize type traits compilation performance To: Jason Merrill Cc: Ken Matsui , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 10 Dec 2023 at 18:19, Jason Merrill wrote: > > On 12/7/23 00:11, Ken Matsui wrote: > > This patch series optimizes type traits compilation performance by > > implementing built-in type traits and using them in libstdc++. > > > > Changes in v26: > > > > * Rebased on top of trunk. > > * Moved is_function_v under is_const_v. > > * Isolated patches for is_const, is_volatile, is_pointer, and > > is_unbounded_array, which contain performance regression, from > > this patch series since they are not ready for review yet. > > I've applied all the compiler patches, with a few small tweaks, > including this one as a separate commit. One other was a formatting > fix, the lats was using TYPE_PTRDATAMEM_P for CPTK_IS_MEMBER_OBJECT_POINTER. > > I'm leaving the library patches for library folks to apply. I've reviewed all the library patches in v26 and they are all OK for trunk. Please push (or Patrick can do so). Thanks, Ken! Great work, I'm really happy to see this land in GCC trunk. +Reviewed-by: Jonathan Wakely