From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C625D385780A for ; Tue, 11 Oct 2022 19:42:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C625D385780A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665517320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0rUwalI1dpy7ScHg2kAs+hl6MAIsmPFEdrL5/Y5qoO8=; b=UDrzZ7UnIuNuy/muQkYqzlu1jjVbffBiLZUhqiG+nTnZBP0qOMNLEvUTcP8T3g8qBQdqST jdT31F1ZQD1bLSRjDO/MhsgaSn8Ep1+yr5MZNqUuVBXodAcl1V5tYBYC+LAELu3r1ZMbKq RmNYb2rMmPKCpf5N4f/Lgn9jg3bpLoA= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-363-Ell3XS2CMRarxf8DSyyhdA-1; Tue, 11 Oct 2022 15:41:52 -0400 X-MC-Unique: Ell3XS2CMRarxf8DSyyhdA-1 Received: by mail-qt1-f198.google.com with SMTP id g21-20020ac87d15000000b0035bb6f08778so9755875qtb.2 for ; Tue, 11 Oct 2022 12:41:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0rUwalI1dpy7ScHg2kAs+hl6MAIsmPFEdrL5/Y5qoO8=; b=rBNXPC/oK7M+z/upzrBbMlrQODLkZSl71fRdaBhKiviKDZti0AE1zie1LwWJM+avG+ H9ZA42QYPww6oTHw5f6u9g8YaEnMGD14ovbO7448XFCAaXWnS4zVVPtGmKacsGKP3/qL 5mOb2iArfViVY9h+KkH3duf8ULaDIXxB+190I3R1Qx5Y9IhZFZL1wzPQz49+twmk49Yz i485GaBLfXPgECfUdcHk7xLcbN5afQafc5M6F8DcEsiIzFyKZm6jyAQeIiWipkaMRLfc ycR7YR6DDjh+77trLMi15u6nwcSX2Ioi1PbmO7DMITjVM6SlsBfsGUgAS+zK2+EskpTv d0Mw== X-Gm-Message-State: ACrzQf0VxlzZKvMeG+gND8j6dHFr4PodAs/IWTqZBpZXmJBeD/gXzaub OX5EDM4O8jpChwbCDBzPP5NUmWRhRFoBSJU8GF5Hlj55ffHW8DAvoe97WJsT8idEawQajws9uM/ vlnOKvuN3qAo/oY+Tf3QfnPlCHIQcTq8= X-Received: by 2002:a05:620a:13f2:b0:6ec:597f:eda6 with SMTP id h18-20020a05620a13f200b006ec597feda6mr9326784qkl.287.1665517311664; Tue, 11 Oct 2022 12:41:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6nzIF8M1hWPasBcRXZ1RYPYVlsYw5IIDLd445P7iEPLzJIUYT1mPhlIYWV4JBhOER/rUGOwUrTn/q4skbOkwg= X-Received: by 2002:a05:620a:13f2:b0:6ec:597f:eda6 with SMTP id h18-20020a05620a13f200b006ec597feda6mr9326773qkl.287.1665517311457; Tue, 11 Oct 2022 12:41:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Tue, 11 Oct 2022 20:41:40 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Allow emergency EH alloc pool size to be tuned [PR68606] To: "libstdc++" Cc: David Edelsohn , GCC Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000b7dd2605eac777f5" X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000b7dd2605eac777f5 Content-Type: text/plain; charset="UTF-8" On Tue, 11 Oct 2022 at 19:58, Jonathan Wakely wrote: > > > > On Tue, 11 Oct 2022, 19:38 David Edelsohn via Libstdc++, wrote: >> >> This patch seems to have broken bootstrap on AIX. It seems to assume >> methods that aren't guaranteed to be defined. > > > > It doesn't use anything that wasn't already used by that file. > > I have no idea how it ever compiled if it doesn't now, but I'll take a look. The problem was inconsistent namespace qualification. The __scoped_lock type is always present on AIX even for the single-threaded multilib, but the code wasn't referring to the correct __scoped_lock type consistently. Fixed like so. Bootstrapped on x86_64-linux with --disable-threads (I'm still waiting for the AIX build, but the symptom and cure are the same as for --disable-threads on other targets). Pushed to trunk. --000000000000b7dd2605eac777f5 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l94lzhx80 Y29tbWl0IDIzYzNjYmFlZDM2ZjZkMmYzYTdhNjRmNmViZGE2OTMyOTcyMzUxNGIKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBUdWUgT2N0IDExIDIw OjE5OjA4IDIwMjIKCiAgICBsaWJzdGRjKys6IEZpeCBib290c3RyYXAgZm9yIC0tZGlzYWJsZS10 aHJlYWRzIGJ1aWxkIFtQUjEwNzIyMV0KICAgIAogICAgVGhlIF9fc2NvcGVkX2xvY2sgdHlwZSBz aG91bGQgYmUgdXNlZCB1bnF1YWxpZmllZCBzbyB0aGF0IHdlIGFsd2F5cwogICAgcmVmZXIgdG8g cG9vbDo6X19zY29wZWRfbG9jaywgd2hpY2ggbWlnaHQgYmUgdGhlIGR1bW15IGZhbGxiYWNrCiAg ICBpbXBsZW1lbnRhdGlvbi4KICAgIAogICAgVGhlIF9fbXV0ZXggYW5kIF9fc2NvcGVkX2xvY2sg dHlwZXMgaW4gPGV4dC9jb25jdXJyZW5jZS5oPiBhbHJlYWR5IHdvcmsKICAgIGZpbmUgd2l0aG91 dCBfX0dUSFJFQURTIGJlaW5nIGRlZmluZWQsIGJ1dCB0aGF0IGhlYWRlciBpc24ndCBpbmNsdWRl ZCBhdAogICAgYWxsIHVubGVzcyBfR0xJQkNYWF9IT1NURUQgIT0gMC4gVGhlIGZhbGxiYWNrIGlt cGxlbWVudGF0aW9uIHNob3VsZCBiZQogICAgdXNlZCBmb3IgISBfR0xJQkNYWF9IT1NURUQgaW5z dGVhZCBvZiBmb3IgIWRlZmluZWQgX19HVEhSRUFEUy4KICAgIAogICAgbGlic3RkYysrLXYzL0No YW5nZUxvZzoKICAgIAogICAgICAgICAgICBQUiBib290c3RyYXAvMTA3MjIxCiAgICAgICAgICAg ICogbGlic3VwYysrL2VoX2FsbG9jLmNjIChwb29sKTogQ2hhbmdlIHByZXByb2Nlc3NvciBjb25k aXRpb24KICAgICAgICAgICAgZm9yIHVzaW5nIF9fbXV0ZXggZnJvbSBfX0dUSFJFQURTIHRvIF9H TElCQ1hYX0hPU1RFRC4KICAgICAgICAgICAgKHBvb2w6OmFsbG9jYXRlKTogUmVtb3ZlIG5hbWVz cGFjZSBxdWFsaWZpY2F0aW9uIHRvIHVzZQogICAgICAgICAgICBwb29sOjpfX3Njb3BlZF9sb2Nr IGluc3RlYWQgb2YgX19nbnVfY3h4OjpfX3Njb3BlZF9sb2NrLgoKZGlmZiAtLWdpdCBhL2xpYnN0 ZGMrKy12My9saWJzdXBjKysvZWhfYWxsb2MuY2MgYi9saWJzdGRjKystdjMvbGlic3VwYysrL2Vo X2FsbG9jLmNjCmluZGV4IDUwZGMzN2MwZDljLi44MWI4YTE1NDhjNiAxMDA2NDQKLS0tIGEvbGli c3RkYysrLXYzL2xpYnN1cGMrKy9laF9hbGxvYy5jYworKysgYi9saWJzdGRjKystdjMvbGlic3Vw YysrL2VoX2FsbG9jLmNjCkBAIC0xNDUsNyArMTQ1LDcgQEAgbmFtZXNwYWNlCiAJY2hhciBkYXRh W10gX19hdHRyaWJ1dGVfXygoYWxpZ25lZCkpOwogICAgICAgfTsKIAotI2lmZGVmIF9fR1RIUkVB RFMKKyNpZiBfR0xJQkNYWF9IT1NURUQKICAgICAgIC8vIEEgc2luZ2xlIG11dGV4IGNvbnRyb2xs aW5nIGVtZXJnZW5jeSBhbGxvY2F0aW9ucy4KICAgICAgIF9fZ251X2N4eDo6X19tdXRleCBlbWVy Z2VuY3lfbXV0ZXg7CiAgICAgICB1c2luZyBfX3Njb3BlZF9sb2NrID0gX19nbnVfY3h4OjpfX3Nj b3BlZF9sb2NrOwpAQCAtMjM2LDcgKzIzNiw3IEBAIG5hbWVzcGFjZQogCiAgIHZvaWQgKnBvb2w6 OmFsbG9jYXRlIChzdGQ6OnNpemVfdCBzaXplKSBub2V4Y2VwdAogICAgIHsKLSAgICAgIF9fZ251 X2N4eDo6X19zY29wZWRfbG9jayBzZW50cnkoZW1lcmdlbmN5X211dGV4KTsKKyAgICAgIF9fc2Nv cGVkX2xvY2sgc2VudHJ5KGVtZXJnZW5jeV9tdXRleCk7CiAgICAgICAvLyBXZSBuZWVkIGFuIGFk ZGl0aW9uYWwgc2l6ZV90IG1lbWJlciBwbHVzIHRoZSBwYWRkaW5nIHRvCiAgICAgICAvLyBlbnN1 cmUgcHJvcGVyIGFsaWdubWVudCBvZiBkYXRhLgogICAgICAgc2l6ZSArPSBvZmZzZXRvZiAoYWxs b2NhdGVkX2VudHJ5LCBkYXRhKTsK --000000000000b7dd2605eac777f5--