public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Detlef Vollmann <dv@vollmann.ch>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
	gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] libstdc++: Move closing brace outside #endif [PR104866]
Date: Fri, 11 Mar 2022 15:12:36 +0000	[thread overview]
Message-ID: <CACb0b4kgeUwBqUuPY900tYf8qfiKip9ocS-q4qUOn-EGnZ8i+w@mail.gmail.com> (raw)
In-Reply-To: <4b5afc64-39f6-db5a-c6ba-144af10c698a@vollmann.ch>

On Fri, 11 Mar 2022 at 14:28, Detlef Vollmann wrote:
>
> Hi Jonathan,
>
> On 3/10/22 22:11, Jonathan Wakely wrote:
>
> > Tested x86_64-linux, pushed to trunk.
>
> Thanks.
> With this and the other fix I was able to build the complete
> libstdc++ for AVR based on AVR Libc 2.0 (plus some ad hoc
> AVR header fixes) from git master 5e28be89.

Nice. I finally figure out that I need to use --enable-libstdcxx *not*
--enable-libstdc++-v3 to build for AVR, and now I get errors due to
EOVERFLOW being undefined. Is that what you fixed?

We should make that work. Arguably, all values of std::errc should
exist, even if the OS <errno.h> doesn't provide a constant. We could
define the missing ones ourselves, choosing numbers > 1000 (and hope
the OS uses small numbers for its own errno values).

>
> And a small example with pmr::string and pmr::vector worked :-)

Great!


  reply	other threads:[~2022-03-11 15:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 21:11 Jonathan Wakely
2022-03-11 14:27 ` Detlef Vollmann
2022-03-11 15:12   ` Jonathan Wakely [this message]
2022-03-11 15:21     ` Jonathan Wakely
2022-03-11 15:35     ` Detlef Vollmann
2022-03-11 17:59       ` Jonathan Wakely
2022-03-11 19:24         ` Detlef Vollmann
2022-03-14  9:57           ` Detlef Vollmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACb0b4kgeUwBqUuPY900tYf8qfiKip9ocS-q4qUOn-EGnZ8i+w@mail.gmail.com \
    --to=jwakely@redhat.com \
    --cc=dv@vollmann.ch \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).