From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6CEFE385781C for ; Fri, 11 Mar 2022 15:12:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6CEFE385781C Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-470-l6b_iZYjOS-jRWSdsBYaVw-1; Fri, 11 Mar 2022 10:12:47 -0500 X-MC-Unique: l6b_iZYjOS-jRWSdsBYaVw-1 Received: by mail-yb1-f200.google.com with SMTP id b12-20020a056902030c00b0061d720e274aso7534966ybs.20 for ; Fri, 11 Mar 2022 07:12:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/X3mm+tPXEj+0zru6MBdyRxt21AwCfcBJ8yEoQrvHOU=; b=LbPnVdaAb/AjlWQFX/MVz3nd31E2HfOMMTJjpOWKsQKNw3+Es7vAL0SWlwof60G6gu PYIB9W3GU4XddYcsDX9T2NPC2dX8H4ArXIXVSHlxHRN7/cKwXI4qnmgjtRPVd6c5gK1S iuvmwxo92933UmuvcI82M5AnAORlbD319ly5OpN8F3fTxpGCRnzkCGaM2sCUGP28bC7T cZcjP3w6FQEX+GKYsp5S6MP5Hz8qdTDLDDuZuIgoIPjyE71C8kltoCU+aXcsQSvfKA+/ Lz5EOYExMejxd6Yz1BOnGjZ3/lniXlL6mhqOGKs2u7iQvtewwgrOjVgqfo99zW7P+7NP or0A== X-Gm-Message-State: AOAM531g6hHvMt0cqvYz2oU4OXIx8hGPEvNJmJCni7jJySorv5ZXnv+j RVQvAUqu6cFwxgFGbZFb5Q76xFEF/1MNDiJsU0dnAKjAVVs1iS9UdE8aqy1SXlpVGXDy/91R3zm CynSnT0YUZiXPtfIPdDRjlM+irix8GCI= X-Received: by 2002:a0d:f883:0:b0:2d0:ee66:5f97 with SMTP id i125-20020a0df883000000b002d0ee665f97mr8437531ywf.313.1647011567387; Fri, 11 Mar 2022 07:12:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJx9h2i2AtpfQmrOcUobKhS3zQGjkFVFtJLp5BdNV46Y+a6ADrg5LlKhMtb4XEBUOfJkUvIIdiy5YAZzid7u2rg= X-Received: by 2002:a0d:f883:0:b0:2d0:ee66:5f97 with SMTP id i125-20020a0df883000000b002d0ee665f97mr8437510ywf.313.1647011567139; Fri, 11 Mar 2022 07:12:47 -0800 (PST) MIME-Version: 1.0 References: <20220310211107.1757824-1-jwakely@redhat.com> <4b5afc64-39f6-db5a-c6ba-144af10c698a@vollmann.ch> In-Reply-To: <4b5afc64-39f6-db5a-c6ba-144af10c698a@vollmann.ch> From: Jonathan Wakely Date: Fri, 11 Mar 2022 15:12:36 +0000 Message-ID: Subject: Re: [committed] libstdc++: Move closing brace outside #endif [PR104866] To: Detlef Vollmann Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 15:12:53 -0000 On Fri, 11 Mar 2022 at 14:28, Detlef Vollmann wrote: > > Hi Jonathan, > > On 3/10/22 22:11, Jonathan Wakely wrote: > > > Tested x86_64-linux, pushed to trunk. > > Thanks. > With this and the other fix I was able to build the complete > libstdc++ for AVR based on AVR Libc 2.0 (plus some ad hoc > AVR header fixes) from git master 5e28be89. Nice. I finally figure out that I need to use --enable-libstdcxx *not* --enable-libstdc++-v3 to build for AVR, and now I get errors due to EOVERFLOW being undefined. Is that what you fixed? We should make that work. Arguably, all values of std::errc should exist, even if the OS doesn't provide a constant. We could define the missing ones ourselves, choosing numbers > 1000 (and hope the OS uses small numbers for its own errno values). > > And a small example with pmr::string and pmr::vector worked :-) Great!