From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 137EA3858D26 for ; Sat, 5 Nov 2022 14:01:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 137EA3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667656881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2F3S1CkJzWFjPe4puWpMlgypU/VeBSLCK3xzScTgeYQ=; b=D9SEXt6OZbIc8TcNTFWo5thWzkQ7qril/f1k0RCngkW4KCoUd7MtwYOfny6dZhiUkJpG8r iOwx4s5UuCA8bEHnGsQwyP5bLxaPckTFDXxwYuYENKVV9M61/vRlSB7RNfhVFN5GJPscP7 oLGGHcATAxM7lXNlYjatXl1HGjW+n0c= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-572-WsrBarTBOuWSsmn66hq50g-1; Sat, 05 Nov 2022 10:01:20 -0400 X-MC-Unique: WsrBarTBOuWSsmn66hq50g-1 Received: by mail-ej1-f70.google.com with SMTP id hd11-20020a170907968b00b0078df60485fdso4810720ejc.17 for ; Sat, 05 Nov 2022 07:01:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2F3S1CkJzWFjPe4puWpMlgypU/VeBSLCK3xzScTgeYQ=; b=4PWfBFUMdFSBUQwERyWYVAHpR6RDIPMmoJ+J9EQs2Qy3EBQX23ERsSR6MrC+prbaq0 xFXJN5wOB6TmRJmBqQwF39gycfl/+J4xd3ttrIGagegAmTOEwIwcaNSDqgEOw1lI8rdZ ytXd1lIVnQEYKow7DSUlsyppfazl4kOcu1Jg7mshaxTCkadHqSk2DJJQRXP5GTex7Q2y JsGLUhuOTwIKrDwU4TrRCnl87cFUZslvGExX85pI3JmSwUYu4icNEgRrZJaHR4fLK6kB u+ZFZMJaqQ2pvtE71rq3bj/KFDZ+BCS7RAFzwcwqfVtkCPsryvkY+ZFZP1XXpQOkYvg7 gLYQ== X-Gm-Message-State: ACrzQf0+wBERk9vQuw+nvB0fkP7TPK5FICqgImcZqvHU94LJxhY4pwn2 ebSUZgBCPRxLJA+PqYvtktdC+VS8TwV3QX2AUYXjQJivMvNY88R5osnb4+Xyufm/e+hnUMEonQh AP1SBBBU5KftIJP+KqnFd/x2ApAwab2A= X-Received: by 2002:a05:6402:50d4:b0:461:e349:56b2 with SMTP id h20-20020a05640250d400b00461e34956b2mr41358432edb.17.1667656879335; Sat, 05 Nov 2022 07:01:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Dw5VWbkCFxQyg7sMDWqeqgoo+cqyKMxWCYSac8KGK/dhtYKL7mmaiU/I7bvpFKBusByJOn+FIDCEGBWufhLM= X-Received: by 2002:a05:6402:50d4:b0:461:e349:56b2 with SMTP id h20-20020a05640250d400b00461e34956b2mr41358403edb.17.1667656879057; Sat, 05 Nov 2022 07:01:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Sat, 5 Nov 2022 14:01:08 +0000 Message-ID: Subject: Re: [PATCH v3] libstdc++: fix pointer type exception catch [PR105387] To: Jakob Hasse Cc: "libstdc++@gcc.gnu.org" , gcc-patches , Ivan Grokhotkov , Alexey Lapshin , Anton Maklakov X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 11 Oct 2022 at 16:05, Jakob Hasse via Libstdc++ wrote: > > Hello, is there any update regarding the patch PR105387 for bug 105387? W= e've been waiting for some time now, but the bugzilla bug is still open: ht= tps://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105387. If there is any issue = with the patch (besides the ones we discussed before), please let us know. = If there's no chance to integrate that patch, we would also like to know, t= o make decisions on how to handle the patch internally. Thanks for your patience. I'm going to push this patch. I've had to adjust the tests slightly, it should use 0 not nullptr so it can be tested with -std=3Dc++98, and 18_support/execption_ptr is about std::exception_ptr not catching pointers, so is the wrong place for the new test. But I can take care of those and push it. > > Thanks, and All the Best, > Jakob Hasse > ________________________________ > From: Jonathan Wakely > Sent: Wednesday, May 25, 2022 5:18 PM > To: Jakob Hasse > Cc: libstdc++@gcc.gnu.org ; gcc-patches ; Anton Maklakov ; Ivan Grokho= tkov > Subject: Re: [PATCH v3] libstdc++: fix pointer type exception catch [PR10= 5387] > > [External: This email originated outside Espressif] > > On Wed, 25 May 2022 at 03:30, Jakob Hasse via Libstdc++ > wrote: > > > > Hello, > > > > two weeks ago I submitted the second version of the patch PR105387 for = the bug 105387. Now I added a pointer-to-member exception test just to make= sure that it doesn't break in case RTTI is enabled. The test is disabled i= f RTTI is disabled. I didn't receive any feedback so far regarding the seco= nd version of the patch. Is there any issue preventing acceptance? > > Just a lack of time to review it properly. > > It's on my list. > > > > > > I ran the conformance tests on libstdc++v3 by running > > make -j 18 check RUNTESTFLAGS=3Dconformance.exp > > > > Results for the current version (only difference is the added pointer-t= o-member test): > > > > Without RTTI before applying patch: > > =3D=3D=3D libstdc++ Summary =3D=3D=3D > > > > # of expected passes 14560 > > # of unexpected failures 5 > > # of expected failures 95 > > # of unsupported tests 702 > > > > Without RTTI after applying patch: > > =3D=3D=3D libstdc++ Summary =3D=3D=3D > > > > # of expected passes 14562 > > # of unexpected failures 5 > > # of expected failures 95 > > # of unsupported tests 703 > > > > With RTTI before applying patch: > > =3D=3D=3D libstdc++ Summary =3D=3D=3D > > > > # of expected passes 14598 > > # of unexpected failures 2 > > # of expected failures 95 > > # of unsupported tests 683 > > > > With RTTI after applying patch: > > =3D=3D=3D libstdc++ Summary =3D=3D=3D > > > > # of expected passes 14602 > > # of unexpected failures 2 > > # of expected failures 95 > > # of unsupported tests 683 > > > > Given that the pointer-to-member test is disabled when RTTI is disabled= , the results look logical to me. > > >