From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5E3C13856DD0 for ; Fri, 20 May 2022 09:03:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E3C13856DD0 Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-8-CL3Z8kH_MMaTtZKZbXEQzg-1; Fri, 20 May 2022 05:03:52 -0400 X-MC-Unique: CL3Z8kH_MMaTtZKZbXEQzg-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-2f4dfd09d7fso67450117b3.0 for ; Fri, 20 May 2022 02:03:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bt+wFzy/Gw33GkMLm3vdk71NxsvXbSY5fO1ziZdd9WQ=; b=Nq0hmhV1NSx0YrgWJEZOBjzg4Kv8EpHrmbkDx64vBU+zfxjGSjEVY/R71RJqZW9OrC H7cmhm8UW60uCZ1tvTHgAEt81qngVchlGBvlhV9CCwgQ9CvpEBUM1Sd5EmDFb4QYt6an bRZ2uGYxYEBz8Xi+ORIBrrqJBu3m2KmA7CC5koD6i8OAF2q+3ULQTTcVLAxT493BAAC9 V/cksJP8Ua0y8mpXoWQumQOmPaHT2nxxiVQ5CK6CwoDkST4Nd+2Nn0EPayTDR7AFlrc4 flGlgTbMDEC7FoUvwRPDUUKNAQDC/2c50ebMSTy/IY196mS/hWKufOgftgpFIKPsFjsG o9vQ== X-Gm-Message-State: AOAM5307sdLv070uKiALjuiUkByHj/+4WTu//FW2+wst5n7A8JfYY1NE kGa/6td9LKFFJDjqIxxV5Bjfz0ZUaAyawwU+bYnKDwZJkpHlW/g/qorP0Z/rgfCQW3YCmP2MDJz nd7h7rldBOVvXRotcZG1Ia0Qwnpgh+Gk= X-Received: by 2002:a25:d04e:0:b0:64e:b1f3:7a71 with SMTP id h75-20020a25d04e000000b0064eb1f37a71mr8536580ybg.404.1653037432383; Fri, 20 May 2022 02:03:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8pYC2DCmyEaB+G/+sBOBa8l85uWf9dZkiC1T4O6tzT5O3VXx0J0Gyj84o5BbvQ37OFK9wYoHgrjdMZLn/onI= X-Received: by 2002:a25:d04e:0:b0:64e:b1f3:7a71 with SMTP id h75-20020a25d04e000000b0064eb1f37a71mr8536567ybg.404.1653037432218; Fri, 20 May 2022 02:03:52 -0700 (PDT) MIME-Version: 1.0 References: <20220520021933.7CE782042B@pchp3.se.axis.com> In-Reply-To: <20220520021933.7CE782042B@pchp3.se.axis.com> From: Jonathan Wakely Date: Fri, 20 May 2022 10:03:40 +0100 Message-ID: Subject: Re: [PATCH] libstdc++-v3: Set 26_numerics/random/n.b.d./op./values.cc timeout-factor to 3 To: Hans-Peter Nilsson Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000f2e0d005df6dc49c" X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 09:03:57 -0000 --000000000000f2e0d005df6dc49c Content-Type: text/plain; charset="UTF-8" On Fri, 20 May 2022 at 03:20, Hans-Peter Nilsson via Libstdc++ wrote: > > Also, how about shortening those test-suite file-paths? > They're path sort-of overlong for any git (and ChangeLog) > commit-line limit. 1/2 :-) Yes, they're silly. I like what libc++ does, i.e. name the testsuite directories after the [stable.name] tags in the standard. They have std/rand/rand.dis/rand.dist.bern/rand.dist.bern.negbin (for some reason they use "rand.dis" instead of "rand.dist" for the third component there, which is not what the standard has, https://eel.is/c++draft/rand.dist.bern.negbin shows the subclause hierarchy). That's still quite unwieldy, so we could remove the repetition and use 26_numerics/rand/dist/bernoulli/negbin/. The problem now is that it gets quite cryptic, so finding the tests for the negative_binomial_distribution is a bit harder if you don't know where to look (but git grep solves that in less than a second). > > Ok to commit (without renaming)? I'm OK with the timeout factor, but we could also solve it differently so that it doesn't take nearly 5 minutes, as in the attached patch. The testDiscreteDist function can be parametrized with the number of iterations to perform. Would you rather do that? --000000000000f2e0d005df6dc49c Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l3e7rgbq0 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjZfbnVtZXJpY3MvcmFuZG9tL25l Z2F0aXZlX2Jpbm9taWFsX2Rpc3RyaWJ1dGlvbi9vcGVyYXRvcnMvdmFsdWVzLmNjIGIvbGlic3Rk YysrLXYzL3Rlc3RzdWl0ZS8yNl9udW1lcmljcy9yYW5kb20vbmVnYXRpdmVfYmlub21pYWxfZGlz dHJpYnV0aW9uL29wZXJhdG9ycy92YWx1ZXMuY2MKaW5kZXggZGRhNmY0M2IyNTQuLmEzMTIwNDAx ZDA5IDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvdGVzdHN1aXRlLzI2X251bWVyaWNzL3JhbmRv bS9uZWdhdGl2ZV9iaW5vbWlhbF9kaXN0cmlidXRpb24vb3BlcmF0b3JzL3ZhbHVlcy5jYworKysg Yi9saWJzdGRjKystdjMvdGVzdHN1aXRlLzI2X251bWVyaWNzL3JhbmRvbS9uZWdhdGl2ZV9iaW5v bWlhbF9kaXN0cmlidXRpb24vb3BlcmF0b3JzL3ZhbHVlcy5jYwpAQCAtMjYsNiArMjYsMTQgQEAK ICNpbmNsdWRlIDxmdW5jdGlvbmFsPgogI2luY2x1ZGUgPHRlc3RzdWl0ZV9yYW5kb20uaD4KIAor Ly8geyBkZy1vcHRpb25zICItRFNJTVVMQVRPUl9URVNUIiB7IHRhcmdldCBzaW11bGF0b3IgfSB9 CisKKyNpZmRlZiBTSU1VTEFUT1JfVEVTVAorIyBkZWZpbmUgQVJHUyAxMDAsIDEwMDAKKyNlbHNl CisjIGRlZmluZSBBUkdTCisjZW5kaWYKKwogdm9pZCB0ZXN0MDEoKQogewogICB1c2luZyBuYW1l c3BhY2UgX19nbnVfdGVzdDsKQEAgLTM0LDE4ICs0MiwxOCBAQCB2b2lkIHRlc3QwMSgpCiAKICAg c3RkOjpuZWdhdGl2ZV9iaW5vbWlhbF9kaXN0cmlidXRpb248PiBuYmQxKDUsIDAuMyk7CiAgIGF1 dG8gYm5iZDEgPSBzdGQ6OmJpbmQobmJkMSwgZW5nKTsKLSAgdGVzdERpc2NyZXRlRGlzdChibmJk MSwgW10oaW50IG4pCi0JCSAgIHsgcmV0dXJuIG5lZ2F0aXZlX2Jpbm9taWFsX3BkZihuLCA1LCAw LjMpOyB9ICk7CisgIHRlc3REaXNjcmV0ZURpc3Q8QVJHUz4oYm5iZDEsIFtdKGludCBuKQorCQkJ IHsgcmV0dXJuIG5lZ2F0aXZlX2Jpbm9taWFsX3BkZihuLCA1LCAwLjMpOyB9ICk7CiAKICAgc3Rk OjpuZWdhdGl2ZV9iaW5vbWlhbF9kaXN0cmlidXRpb248PiBuYmQyKDU1LCAwLjMpOwogICBhdXRv IGJuYmQyID0gc3RkOjpiaW5kKG5iZDIsIGVuZyk7Ci0gIHRlc3REaXNjcmV0ZURpc3QoYm5iZDIs IFtdKGludCBuKQotCQkgICB7IHJldHVybiBuZWdhdGl2ZV9iaW5vbWlhbF9wZGYobiwgNTUsIDAu Myk7IH0gKTsKKyAgdGVzdERpc2NyZXRlRGlzdDxBUkdTPihibmJkMiwgW10oaW50IG4pCisJCQkg eyByZXR1cm4gbmVnYXRpdmVfYmlub21pYWxfcGRmKG4sIDU1LCAwLjMpOyB9ICk7CiAKICAgc3Rk OjpuZWdhdGl2ZV9iaW5vbWlhbF9kaXN0cmlidXRpb248PiBuYmQzKDEwLCAwLjc1KTsKICAgYXV0 byBibmJkMyA9IHN0ZDo6YmluZChuYmQzLCBlbmcpOwotICB0ZXN0RGlzY3JldGVEaXN0KGJuYmQz LCBbXShpbnQgbikKLQkJICAgeyByZXR1cm4gbmVnYXRpdmVfYmlub21pYWxfcGRmKG4sIDEwLCAw Ljc1KTsgfSApOworICB0ZXN0RGlzY3JldGVEaXN0PEFSR1M+KGJuYmQzLCBbXShpbnQgbikKKwkJ CSB7IHJldHVybiBuZWdhdGl2ZV9iaW5vbWlhbF9wZGYobiwgMTAsIDAuNzUpOyB9ICk7CiB9CiAK IGludCBtYWluKCkK --000000000000f2e0d005df6dc49c--