From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B8E3D38930D4 for ; Mon, 9 Aug 2021 10:34:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8E3D38930D4 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-j_BCmHz8Mv-B_lOZLLVLNQ-1; Mon, 09 Aug 2021 06:34:39 -0400 X-MC-Unique: j_BCmHz8Mv-B_lOZLLVLNQ-1 Received: by mail-wr1-f69.google.com with SMTP id r17-20020adfda510000b02901526f76d738so5225776wrl.0 for ; Mon, 09 Aug 2021 03:34:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5en0ayQt3zwcO8vY4eRgkwDjKEO2H7Ay586c6/Yu3pA=; b=isc8OMlDLw6MAXJbisIo+hymPoiq47Sf5CjudCJ9g5qJsJLKQ4FXZoq+ZRWpNsgCSi XqP43sBrzYAvSThcq4/u/AjsvI4uUVkYzMW/jpzyE67dtjKesZOdkj7gHmSHrTM0KwH2 xaRaK5rWvLmxUcYRSckkwtQs1KLphQpHLy33H/3JDZXd4W3QcyBFMmCQvsQ5m954yHzD sP0hY43+yUeNLt/KgT9QUTJu1S3Tb6xFvaFitkO7KfoSyZhaOTvlAM3f22gYrljoKoik zICjj7L6E+DbnMs+1WAYKEW8gAyB1ANoBbT1ut5Dr0fYxUinbN5U13394gvwuxmNNeTr ddvQ== X-Gm-Message-State: AOAM530qyUiG8qfObRQRC3DePp7Haz98PEjfy+gNupIeHAOeaoBba0Oo BHBqifqP0KAAp3oAJwsy40+flWeH3JylzPleFrPwpr8cdxVQIp+i8NMaOkDwzfKRKRE/Ul7V/+z Sne26HL/DFPyUh4UieCIdgtkUO1Amnz4= X-Received: by 2002:adf:d091:: with SMTP id y17mr24766722wrh.311.1628505278221; Mon, 09 Aug 2021 03:34:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwm5oiJFJEQFcEZwOCtWHL+MMciYSESXXDr8s5v2JeMb+velZtPi3JRBgGdi4CnKXJ3HaROIbzFl6hM5IoM240= X-Received: by 2002:adf:d091:: with SMTP id y17mr24766709wrh.311.1628505278060; Mon, 09 Aug 2021 03:34:38 -0700 (PDT) MIME-Version: 1.0 References: <6edc763b-e463-a676-0232-7b2193fb403b@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Mon, 9 Aug 2021 11:34:27 +0100 Message-ID: Subject: Re: [PATCH] Avoid allocator operator== in _Safe_container To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Aug 2021 10:34:43 -0000 On Mon, 9 Aug 2021 at 11:33, Jonathan Wakely wrote: > > On Mon, 9 Aug 2021 at 11:26, Fran=C3=A7ois Dumont via Libstdc++ > wrote: > > > > Some newly introduced tests in > > 23_containers/unordered_map/cons/default.cc revealed that we are forcin= g > > the allocator type to have a operator=3D=3D. > > All allocators are required to have operator=3D=3D so that should not be = a > problem. What is the error? OK, I see it. I just forgot to define operator=3D=3D and operator!=3D for the custom allocator in that new test, and that should be added.