From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2334F385B521 for ; Wed, 22 Mar 2023 19:47:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2334F385B521 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679514429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U3LykPJ5InMLuhD8b8+uMqoJSHOHS0NyTasTRTW2ZBs=; b=SC5gL02crlN5d6lQJBQlDKKFlFHszzDRl6ZqaOlW2mM0AV2ipDpOSTno+sBn92q7SV/l5h mNZqz9ESkDjGMteXcja6j6KceBfHnIVKPn6B2k4ohM1QIV7lT3rYsCCL7GXBZYfvwXKu/g bh1mc4I4GSLHs6keaUzgZNCgaEEKVu0= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-6wHZzAJ-OsGbvUZ9T7xjaw-1; Wed, 22 Mar 2023 15:47:00 -0400 X-MC-Unique: 6wHZzAJ-OsGbvUZ9T7xjaw-1 Received: by mail-lj1-f198.google.com with SMTP id bd12-20020a05651c168c00b00299aa611a59so5354896ljb.20 for ; Wed, 22 Mar 2023 12:47:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679514419; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U3LykPJ5InMLuhD8b8+uMqoJSHOHS0NyTasTRTW2ZBs=; b=M1gs+L2VwIeqI3mnY7bhx/DZgCXnTRnBZbYUVO3KOTHsGoKNdXIUGBzLSGP/kOOajy mkggUiIASY7ESXtfVCCvtMfo1VQm/RV6hd152RoSNsUZ3vZOKVsPCBeAdk2JpTKWE+Au JVdGVWPxX6n1IQLcTcoq8cmI+35kazCKfSrIEmRXgRAl1UQju5R9s14J/Y2N4CiMyFNd i67lj4sDdjVY/sWrw6tGOwshC9j8mI5gUlWIENn37AfGQlShxuF4FfljVI8nsEyjoQ2u 1HnRfnNvdsTv3zAGTY7JuMKTkF/uO6bivhgavPFjG/Rm8fNpIxZg1U+6YZRDCO5nzP6y 3Qug== X-Gm-Message-State: AO0yUKU/csrjHMIyWMYLu4m/HpJgkI77gFP9PDv6Kw3xOsd2OM7DF5G8 2727mLPBJeNTYycuItHy8sKtxtASMg5hdhfdd7kou/iZZ/XP967Wqzxw0ZWki6F0CVAxk70rUW4 aYEqSOiNXVU6iNty4h4t4tovvH5qdQcc= X-Received: by 2002:a05:651c:4c9:b0:299:6e0e:3a1b with SMTP id e9-20020a05651c04c900b002996e0e3a1bmr1725903lji.4.1679514419200; Wed, 22 Mar 2023 12:46:59 -0700 (PDT) X-Google-Smtp-Source: AK7set9NdsKpMw2aSDGqroB8/Rh7Rdg9AQvEdDmKUKGTClooMvCvmTFZguqC1nk+lse+yqzOzLuPc7MxZbzKlQ12Hbc= X-Received: by 2002:a05:651c:4c9:b0:299:6e0e:3a1b with SMTP id e9-20020a05651c04c900b002996e0e3a1bmr1725889lji.4.1679514418853; Wed, 22 Mar 2023 12:46:58 -0700 (PDT) MIME-Version: 1.0 References: <20230322175003.408005-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 22 Mar 2023 19:46:47 +0000 Message-ID: Subject: Re: [committed] libstdc++: Add missing __cpp_lib_format macro to To: =?UTF-8?Q?Daniel_Kr=C3=BCgler?= Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000054ce2a05f7826c01" X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000054ce2a05f7826c01 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 22 Mar 2023 at 17:59, Daniel Kr=C3=BCgler wrote: > Am Mi., 22. M=C3=A4rz 2023 um 18:53 Uhr schrieb Jonathan Wakely via > Libstdc++ : > > > > Tested powerpc64le-linux, pushed to trunk. > > > > -- >8-- > > > > libstdc++-v3/ChangeLog: > > > > * include/std/version (__cpp_lib_format): Define. > > * testsuite/std/format/functions/format.cc: Check it. > > --- > > libstdc++-v3/include/std/version | 1 + > > .../testsuite/std/format/functions/format.cc | 15 +++++++++++++++ > > 2 files changed, 16 insertions(+) > > > > diff --git a/libstdc++-v3/include/std/version > b/libstdc++-v3/include/std/version > > index 25ebfc3e512..a19c39c6cdd 100644 > > --- a/libstdc++-v3/include/std/version > > +++ b/libstdc++-v3/include/std/version > > @@ -277,6 +277,7 @@ > > #define __cpp_lib_constexpr_utility 201811L > > #define __cpp_lib_constexpr_vector 201907L > > #define __cpp_lib_erase_if 202002L > > +#define __cpp_lib_format 202106L > > Shouldn't the value be 202207L? (This of-course of your conforming > completeness) > > Well spotted! The historical values listed in SD-6 are included in a comment in : // 201907 Text Formatting, Integration of chrono, printf corner cases. // 202106 std::format improvements. // 202110 Fixing locale handling in chrono formatters, generator-like types. // 202207 Encodings in localized formatting of chrono, basic-format-string. #define __cpp_lib_format 202106L The libstdc++ support only got as far as 202106 so far :-) (We actually do implement the support for generator-like types from P2418R2 and the std::basic_format_string change from P2508R1, but can't bump the value to 202207 until the other changes are supported too.) I might still find time to finish P2372R3 and P2419R2 for GCC 13, but no promises. --00000000000054ce2a05f7826c01--