From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B2D9B3858C3A for ; Mon, 11 Oct 2021 21:04:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2D9B3858C3A Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-nQW29LJqMHy_5d1g-5Ne0w-1; Mon, 11 Oct 2021 17:04:14 -0400 X-MC-Unique: nQW29LJqMHy_5d1g-5Ne0w-1 Received: by mail-ua1-f69.google.com with SMTP id m40-20020ab05a6b000000b002c9d69624b0so8304011uad.1 for ; Mon, 11 Oct 2021 14:04:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BgxUCnqHg2eK50CWNtFvZ8T/mUmAL7fFbaQ0KL9dcnE=; b=tFrsO4S3c8hsST2pxriZ6QG0lZUg6gap0wPN1FnrOsMVEzUwtZGA4NZt9iV91H23eD 3rC0tf+heXYLGQFXaPrAnh6AitRIiyiulHPlp0hRVClnotOXP70TeCF4DNLOKF5JAbJI dFYZCBMiMEqFlqeiP2DwhZNQyGShUVAMrzbhVMjoGGKWz0XDsiK8Go9tgYvviVqgpSbx 0foLeRXHQ+Y1KYaTco3y1a0cTwV/1T3QfHLdqtoAh6Fw/JqyyVNxt6zjIhjQ4K0UQqV2 NR65pPt5f7tl+tJIlaEMyEhKCMHZA/j7xCeoLHWqrGya9F0uhZNxyx1wfioveSyDNLC6 H11A== X-Gm-Message-State: AOAM530U3y0kFhobFUHCt4+nkdqr/rHe8PxGsUkbbUXrZGusfUJfsS5G 6Ihf2atTAgCdbs5+PPkquCK7m+AintM+vCwgId01rcBvE71Mq90VgqJBpE7WctKyuUjBcSGAYlT hdzILZkq/kI3KT05PBHWVBkoy3cT6iec= X-Received: by 2002:ab0:5bdc:: with SMTP id z28mr17539132uae.35.1633986254413; Mon, 11 Oct 2021 14:04:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYG787IBX8Rs3oz3moV7zNHy2U1yOjFcUsmDoeySsRrzhJNWqKQi25DnbaWQWBpuVGMRP24OTfQ3DGiBty/1o= X-Received: by 2002:ab0:5bdc:: with SMTP id z28mr17539109uae.35.1633986254212; Mon, 11 Oct 2021 14:04:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 11 Oct 2021 22:04:03 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Fix compare_three_way for constexpr and Clang To: Paul Keir Cc: "gcc-patches@gcc.gnu.org" , "libstdc++@gcc.gnu.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2021 21:04:18 -0000 On Mon, 11 Oct 2021 at 20:48, Jonathan Wakely wrote: > > On Fri, 20 Aug 2021 at 21:19, Paul Keir wrote: > > > > Hi, > > > > The current compare_three_way implementation makes provision for consta= nt evaluation contexts (avoiding reinterpret_cast etc.), but the approach f= ails with Clang; when it compares two const volatile void pointers: "compar= ison between unequal pointers to void has unspecified result". I include a = fix and test. > > > > Could someone commit the attached patch for me? > > Sorry for dropping the ball on this again. I've applied the patch > locally and I'm testing it now. Unless I'm mistaken, you do not have a > copyright assignment on file with the FSF, is that right? Are you able > to certify that you have the right to submit this to GCC, as described > at https://gcc.gnu.org/dco.html ? P.S. patches should not touch the ChangeLog file. It was always wrong, because it usually makes the patch fail to apply. Since we moved to Git the ChangeLog files are automatically generated from the Git commits anyway, so are never touched as part of the commit. The changelog entry is still needed, but should be in the Git commit message not as a patch against the actual ChangeLog file. > > Also, if GCC is failing to diagnose the invalid comparisons here then > that should be reported to bugzilla as a c++ "accepts-invalid" bug.