From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3218B3858D28 for ; Wed, 30 Nov 2022 12:31:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3218B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669811495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IPn005UvdgD8jiGI43ScPIX8hfdXC1GSt/P0VYnhPwk=; b=GmeEew5IgRth1vS7W0X08TFdISKaWUE1L/fRaDnPOp2vgtTw3F9nSwgZ5gXAZ3G7m3p8W7 ZVovRDNc3Cm0W44Nv3qhdThYzcEctS2jDTBMXY0kuIsy3MyBICXEi9kuCyDLJmn6Y84lid m0IXFya4rtg96m9kxyfdYJpW6N1mI3s= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-251-xgPeatAiNDCDqApH3Sn9ow-1; Wed, 30 Nov 2022 07:31:32 -0500 X-MC-Unique: xgPeatAiNDCDqApH3Sn9ow-1 Received: by mail-ej1-f72.google.com with SMTP id sa20-20020a1709076d1400b007bbe8699c2eso7469652ejc.6 for ; Wed, 30 Nov 2022 04:31:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IPn005UvdgD8jiGI43ScPIX8hfdXC1GSt/P0VYnhPwk=; b=sWTnmecYt+Z9f76XqfBcgawP6Xrt3ZU7RVY2lik+rz6fXN1A79JdFnTZfal9uB68Kw SpweaINuTqHc1zYnBifg7yYF64nn1AzPW5OqhO3imNwDFkLKmk1WXSaLNRg8d9HmBEwU LNeBD9PIlea4xoBQ67yKQgEKlGM7LT2IOqk7IFD4vYE2Pg6VcQL39DRQmIoc+D8TyzXU /vSAyJ7ay9Fb2h2a6thOimA3dtAgH0sMEt/jYlhj+pgh2WMmCYK2/KsqYVqElthCVP3A Qw0TwxUyM+F4d1+UafHGKL0qrFRRrl7NcKBGVwbG0HLDBTjVLgMBS+xSq8VSbYkKs11H vplA== X-Gm-Message-State: ANoB5pkELJwNAdp3g9283C33lEteYdsAnxuBQUm2M94JBQq12pxjvHh2 GF60VgpkOVmi5nM0/7rrPaAK+vsVDz11uFMG+UKQVSlZYEhcn+vWSKLi5zuaiQbDwbH0CmuRGqB pB/l3UMwu+AQB4Iczsh5bhTc5Qv+Yhv4= X-Received: by 2002:a17:906:d103:b0:7ad:9673:8b73 with SMTP id b3-20020a170906d10300b007ad96738b73mr53331286ejz.14.1669811490809; Wed, 30 Nov 2022 04:31:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf7qyX7rOtzoauS2t3ggUtSBOGiD5HrZtS7YXFJP9KiYVpQOqI+HNo8ss8g66js+XKxiFHsfde2bzOdQElS6w0A= X-Received: by 2002:a17:906:d103:b0:7ad:9673:8b73 with SMTP id b3-20020a170906d10300b007ad96738b73mr53331277ejz.14.1669811490644; Wed, 30 Nov 2022 04:31:30 -0800 (PST) MIME-Version: 1.0 References: <20221129214107.25572-1-gcc@hazardy.de> In-Reply-To: <20221129214107.25572-1-gcc@hazardy.de> From: Jonathan Wakely Date: Wed, 30 Nov 2022 12:31:19 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Add error handler for To: =?UTF-8?B?QmrDtnJuIFNjaMOkcGVycw==?= Cc: gcc-patches@gc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000be161805eeaf48f5" X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000be161805eeaf48f5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 29 Nov 2022 at 21:41, Bj=C3=B6rn Sch=C3=A4pers wrote: > > From: Bj=C3=B6rn Sch=C3=A4pers > > Not providing an error handler results in a nullpointer dereference when > an error occurs. Thanks for the patch. This looks small enough to not require legal paperwork, but if you intend to make further contributions (and I hope you do!) please note the process at https://gcc.gnu.org/dco.html or complete the paperwork for a copyright assignment to the FSF, whichever you prefer. I'm going to test and commit the attached patch, which replaces your __backtrace_error_handler with a static member function so that we don't make the name visible in the global namespace. Thanks again! --000000000000be161805eeaf48f5 Content-Type: text/plain; charset="UTF-8"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lb3ls2xt0 Y29tbWl0IDBlMzJkZTMxZjM0YTg4Yjk0MWFjZDJmNDcxYmE2ZThlOTQ1MzcyY2YKQXV0aG9yOiBC asO2cm4gU2Now6RwZXJzIDxiam9lcm5AaGF6YXJkeS5kZT4KRGF0ZTogICBXZWQgTm92IDMwIDEy OjA0OjE2IDIwMjIKCiAgICBsaWJzdGRjKys6IEFkZCBlcnJvciBoYW5kbGVyIGZvciA8c3RhY2t0 cmFjZT4KICAgIAogICAgTm90IHByb3ZpZGluZyBhbiBlcnJvciBoYW5kbGVyIHJlc3VsdHMgaW4g YSBudWxsIHBvaW50ZXIgZGVyZWZlcmVuY2UKICAgIHdoZW4gYW4gZXJyb3Igb2NjdXJzLgogICAg CiAgICBDby1hdXRob3JlZC1ieTogSm9uYXRoYW4gV2FrZWx5IDxqd2FrZWx5QHJlZGhhdC5jb20+ CiAgICAKICAgIGxpYnN0ZGMrKy12My9DaGFuZ2VMb2c6CiAgICAKICAgICAgICAgICAgKiBpbmNs dWRlL3N0ZC9zdGFja3RyYWNlIChzdGFja3RyYWNlX2VudHJ5OjpfU19lcnJfaGFuZGxlcik6IE5l dwogICAgICAgICAgICBzdGF0aWMgZnVuY3Rpb24uCiAgICAgICAgICAgIChzdGFja3RyYWNlX2Vu dHJ5LCBiYXNpY19zdGFja3RyYWNlKTogUGFzcyAmX1NfZXJyX2hhbmRsZXIgdG8KICAgICAgICAg ICAgYWxsIGNhbGxzIHRvIGxpYmJhY2t0cmFjZS4KCmRpZmYgLS1naXQgYS9saWJzdGRjKystdjMv aW5jbHVkZS9zdGQvc3RhY2t0cmFjZSBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9zdGFja3Ry YWNlCmluZGV4IGU3Y2JiZWU1NjM4Li5lYzMzMzVlODlkOCAxMDA2NDQKLS0tIGEvbGlic3RkYysr LXYzL2luY2x1ZGUvc3RkL3N0YWNrdHJhY2UKKysrIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvc3Rk L3N0YWNrdHJhY2UKQEAgLTE1NSwxMSArMTU1LDEzIEBAIF9HTElCQ1hYX0JFR0lOX05BTUVTUEFD RV9WRVJTSU9OCiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBfQWxsb2NhdG9yPiBmcmllbmQgY2xh c3MgYmFzaWNfc3RhY2t0cmFjZTsKIAorICAgIHN0YXRpYyB2b2lkIF9TX2Vycl9oYW5kbGVyKHZv aWQqLCBjb25zdCBjaGFyKiwgaW50KSB7IH0KKwogICAgIHN0YXRpYyBfX2dsaWJjeHhfYmFja3Ry YWNlX3N0YXRlKgogICAgIF9TX2luaXQoKQogICAgIHsKICAgICAgIHN0YXRpYyBfX2dsaWJjeHhf YmFja3RyYWNlX3N0YXRlKiBfX3N0YXRlCi0JPSBfX2dsaWJjeHhfYmFja3RyYWNlX2NyZWF0ZV9z dGF0ZShudWxscHRyLCAxLCBudWxscHRyLCBudWxscHRyKTsKKwk9IF9fZ2xpYmN4eF9iYWNrdHJh Y2VfY3JlYXRlX3N0YXRlKG51bGxwdHIsIDEsIF9TX2Vycl9oYW5kbGVyLCBudWxscHRyKTsKICAg ICAgIHJldHVybiBfX3N0YXRlOwogICAgIH0KIApAQCAtMTkyLDcgKzE5NCw4IEBAIF9HTElCQ1hY X0JFR0lOX05BTUVTUEFDRV9WRVJTSU9OCiAJICByZXR1cm4gX19mdW5jdGlvbiAhPSBudWxscHRy OwogICAgICAgfTsKICAgICAgIGNvbnN0IGF1dG8gX19zdGF0ZSA9IF9TX2luaXQoKTsKLSAgICAg IGlmICg6Ol9fZ2xpYmN4eF9iYWNrdHJhY2VfcGNpbmZvKF9fc3RhdGUsIF9NX3BjLCArX19jYiwg bnVsbHB0ciwgJl9fZGF0YSkpCisgICAgICBpZiAoOjpfX2dsaWJjeHhfYmFja3RyYWNlX3BjaW5m byhfX3N0YXRlLCBfTV9wYywgK19fY2IsIF9TX2Vycl9oYW5kbGVyLAorCQkJCSAgICAgICAmX19k YXRhKSkKIAlyZXR1cm4gdHJ1ZTsKICAgICAgIGlmIChfX2Rlc2MgJiYgX19kZXNjLT5lbXB0eSgp KQogCXsKQEAgLTIwMSw4ICsyMDQsOCBAQCBfR0xJQkNYWF9CRUdJTl9OQU1FU1BBQ0VfVkVSU0lP TgogCSAgICAgIGlmIChfX3N5bW5hbWUpCiAJCSpzdGF0aWNfY2FzdDxfRGF0YSo+KF9fZGF0YSkt Pl9NX2Rlc2MgPSBfU19kZW1hbmdsZShfX3N5bW5hbWUpOwogCSAgfTsKLQkgIGlmICg6Ol9fZ2xp YmN4eF9iYWNrdHJhY2Vfc3ltaW5mbyhfX3N0YXRlLCBfTV9wYywgK19fY2IyLCBudWxscHRyLAot CQkJCQkgICAgJl9fZGF0YSkpCisJICBpZiAoOjpfX2dsaWJjeHhfYmFja3RyYWNlX3N5bWluZm8o X19zdGF0ZSwgX01fcGMsICtfX2NiMiwKKwkJCQkJICAgIF9TX2Vycl9oYW5kbGVyLCAmX19kYXRh KSkKIAkgICAgcmV0dXJuIHRydWU7CiAJfQogICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMjUyLDcg KzI1NSw4IEBAIF9HTElCQ1hYX0JFR0lOX05BTUVTUEFDRV9WRVJTSU9OCiAJaWYgKGF1dG8gX19j YiA9IF9fcmV0Ll9NX3ByZXBhcmUoKSkgW1tsaWtlbHldXQogCSAgewogCSAgICBhdXRvIF9fc3Rh dGUgPSBzdGFja3RyYWNlX2VudHJ5OjpfU19pbml0KCk7Ci0JICAgIGlmIChfX2dsaWJjeHhfYmFj a3RyYWNlX3NpbXBsZShfX3N0YXRlLCAxLCBfX2NiLCBudWxscHRyLAorCSAgICBpZiAoX19nbGli Y3h4X2JhY2t0cmFjZV9zaW1wbGUoX19zdGF0ZSwgMSwgX19jYiwKKwkJCQkJICAgc3RhY2t0cmFj ZV9lbnRyeTo6X1NfZXJyX2hhbmRsZXIsCiAJCQkJCSAgIHN0ZDo6X19hZGRyZXNzb2YoX19yZXQp KSkKIAkgICAgICBfX3JldC5fTV9jbGVhcigpOwogCSAgfQpAQCAtMjcwLDcgKzI3NCw4IEBAIF9H TElCQ1hYX0JFR0lOX05BTUVTUEFDRV9WRVJTSU9OCiAJaWYgKGF1dG8gX19jYiA9IF9fcmV0Ll9N X3ByZXBhcmUoKSkgW1tsaWtlbHldXQogCSAgewogCSAgICBhdXRvIF9fc3RhdGUgPSBzdGFja3Ry YWNlX2VudHJ5OjpfU19pbml0KCk7Ci0JICAgIGlmIChfX2dsaWJjeHhfYmFja3RyYWNlX3NpbXBs ZShfX3N0YXRlLCBfX3NraXAgKyAxLCBfX2NiLCBudWxscHRyLAorCSAgICBpZiAoX19nbGliY3h4 X2JhY2t0cmFjZV9zaW1wbGUoX19zdGF0ZSwgX19za2lwICsgMSwgX19jYiwKKwkJCQkJICAgc3Rh Y2t0cmFjZV9lbnRyeTo6X1NfZXJyX2hhbmRsZXIsCiAJCQkJCSAgIHN0ZDo6X19hZGRyZXNzb2Yo X19yZXQpKSkKIAkgICAgICBfX3JldC5fTV9jbGVhcigpOwogCSAgfQpAQCAtMjk0LDcgKzI5OSw3 IEBAIF9HTElCQ1hYX0JFR0lOX05BTUVTUEFDRV9WRVJTSU9OCiAJICB7CiAJICAgIGF1dG8gX19z dGF0ZSA9IHN0YWNrdHJhY2VfZW50cnk6Ol9TX2luaXQoKTsKIAkgICAgaW50IF9fZXJyID0gX19n bGliY3h4X2JhY2t0cmFjZV9zaW1wbGUoX19zdGF0ZSwgX19za2lwICsgMSwgX19jYiwKLQkJCQkJ CSAgIG51bGxwdHIsCisJCQkJCQkgICBzdGFja3RyYWNlX2VudHJ5OjpfU19lcnJfaGFuZGxlciwK IAkJCQkJCSAgIHN0ZDo6X19hZGRyZXNzb2YoX19yZXQpKTsKIAkgICAgaWYgKF9fZXJyIDwgMCkK IAkgICAgICBfX3JldC5fTV9jbGVhcigpOwo= --000000000000be161805eeaf48f5--