From: Jonathan Wakely <jwakely@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH v2] c++tools: Fix memory leak
Date: Thu, 21 Oct 2021 22:34:37 +0100 [thread overview]
Message-ID: <CACb0b4ktFWan9ex=pE5_xTWat9Qvwf0=bEV4uo-CgGJgMxqptQ@mail.gmail.com> (raw)
In-Reply-To: <2dfa49c9-d55e-8169-616a-ff48a957fb61@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
On Thu, 21 Oct 2021 at 20:38, Jason Merrill wrote:
> On 10/21/21 09:28, Jonathan Wakely wrote:
> > #else
> > buffer = xmalloc (stat.st_size);
> > if (!buffer)
> > return -errno;
> > + struct Deleter { void operator()(void* p) const { free(p); } };
> > + std::unique_ptr<void, Deleter> guard;
>
> Don't you need to initialize guard from buffer?
>
Oops, yes! Updated patch attached.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1622 bytes --]
commit b280f6b5b4339586446eec99e49074e091c27ea5
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu Oct 21 22:32:23 2021
c++tools: Fix memory leak
The allocated memory is not freed when returning early due to an error.
c++tools/ChangeLog:
* resolver.cc (module_resolver::read_tuple_file): Use unique_ptr
to ensure memory is freed before returning.
diff --git a/c++tools/resolver.cc b/c++tools/resolver.cc
index 421fdaa55fe..a1837b3ee10 100644
--- a/c++tools/resolver.cc
+++ b/c++tools/resolver.cc
@@ -23,6 +23,7 @@ along with GCC; see the file COPYING3. If not see
#include "resolver.h"
// C++
#include <algorithm>
+#include <memory>
// C
#include <cstring>
// OS
@@ -114,10 +115,17 @@ module_resolver::read_tuple_file (int fd, char const *prefix, bool force)
buffer = mmap (nullptr, stat.st_size, PROT_READ, MAP_PRIVATE, fd, 0);
if (buffer == MAP_FAILED)
return -errno;
+ struct Deleter {
+ void operator()(void* p) const { munmap(p, size); }
+ size_t size;
+ };
+ std::unique_ptr<void, Deleter> guard(buffer, Deleter{(size_t)stat.st_size});
#else
buffer = xmalloc (stat.st_size);
if (!buffer)
return -errno;
+ struct Deleter { void operator()(void* p) const { free(p); } };
+ std::unique_ptr<void, Deleter> guard(buffer);
if (read (fd, buffer, stat.st_size) != stat.st_size)
return -errno;
#endif
@@ -179,12 +187,6 @@ module_resolver::read_tuple_file (int fd, char const *prefix, bool force)
}
}
-#if MAPPED_READING
- munmap (buffer, stat.st_size);
-#else
- free (buffer);
-#endif
-
return 0;
}
next prev parent reply other threads:[~2021-10-21 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 13:28 [PATCH] " Jonathan Wakely
2021-10-21 19:38 ` Jason Merrill
2021-10-21 21:34 ` Jonathan Wakely [this message]
2021-10-26 14:19 ` [PATCH v2] " Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4ktFWan9ex=pE5_xTWat9Qvwf0=bEV4uo-CgGJgMxqptQ@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).