public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: Sebastian Huber <sebastian.huber@embedded-brains.de>,
	"libstdc++" <libstdc++@gcc.gnu.org>,
	 gcc Patches <gcc-patches@gcc.gnu.org>, RTEMS <devel@rtems.org>
Subject: Re: [PATCH] libstdc++: testsuite: fs rename to self may fail
Date: Thu, 23 Jun 2022 10:25:35 +0100	[thread overview]
Message-ID: <CACb0b4kxMkTf4af2Rz4AVOyFj9WCeFoOgmX5dP6FQfhkLfFdtg@mail.gmail.com> (raw)
In-Reply-To: <orzgi36glh.fsf@lxoliva.fsfla.org>

On Thu, 23 Jun 2022 at 07:26, Alexandre Oliva wrote:
> This feels more and more like a case for xfail until it gets fixed in
> the kernel, where atomic filesystem operations belong :-(
>
> Would a patch to add:
>
> // { dg-xfail-if "::rename is not POSIX-compliant" { target *-*-rtems* } }
>
> to rename.cc tests be acceptable?  I'm afraid I can't go further down
> this rabbit hole, and my choices ATM seem to be limited to XFAIL
> patches, whether accepted by the GCC community or carried internally.


Yes, I think that's definitely the way to go.


  reply	other threads:[~2022-06-23  9:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  6:24 Alexandre Oliva
2022-06-22  6:33 ` Sebastian Huber
2022-06-22  7:01   ` Alexandre Oliva
2022-06-22 10:41     ` Jonathan Wakely
2022-06-23  3:59       ` Alexandre Oliva
2022-06-23  6:26       ` Alexandre Oliva
2022-06-23  9:25         ` Jonathan Wakely [this message]
2022-06-23 11:21           ` Alexandre Oliva
2022-06-23 11:38             ` Jonathan Wakely
2022-06-23 12:41               ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACb0b4kxMkTf4af2Rz4AVOyFj9WCeFoOgmX5dP6FQfhkLfFdtg@mail.gmail.com \
    --to=jwakely@redhat.com \
    --cc=devel@rtems.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=oliva@adacore.com \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).