From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C672B385840F for ; Tue, 22 Mar 2022 16:35:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C672B385840F Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-kIGKTrpHOo-90CFmS1tZHA-1; Tue, 22 Mar 2022 12:35:04 -0400 X-MC-Unique: kIGKTrpHOo-90CFmS1tZHA-1 Received: by mail-ej1-f70.google.com with SMTP id k16-20020a17090632d000b006ae1cdb0f07so8998248ejk.16 for ; Tue, 22 Mar 2022 09:35:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DcyS3j1yb7Ym5v/wIBI874kS00OXHqiVh1D9O54uyIs=; b=OqxklM3L7PAapFgQyTyZH+EtLBo3RuOQnvdM+3p8VS/lgnAeF+1qJcfd/UVm3yx2ga Z5eLLw8b/ACInKAIfdCAGcWpPQpmonP+7BeMHGFqfAAxUWItNIY394xVNJ1HrONpNbuZ o5CnU2yTrxeXguoECpJsjEGUZAxSdVmpcbivEt1c/ZkARF1LO5CFIiQKbyMbYmed91lr tDViEGVVc4wXbAWZuJfqVbUz1HUBiRejPUMxNoE0dem4sgrTST1pPfOrJyeahht3ucEI OSQ0Hqe/7Z34uLIJDepGKj/mgEswNByI1sEoqQc3gRra7mZsYGXBc5sWN50gjKfN5pNj 1TZQ== X-Gm-Message-State: AOAM5311cgtIVl9UflHNokv5UzVf4cN/qfzN3jShG596XvW1f2E90IZH D/8Kewn5MIR4O/2EK8FlxE2OVdKBel2mwzTlyArpycXTGBB2MAk0bW9VDxR4KE7zCYG/gHSkTid 7O4nCui/fJ0eGua/HAnIjo730grGXU/E= X-Received: by 2002:a17:907:6d0e:b0:6d7:c85:5bf5 with SMTP id sa14-20020a1709076d0e00b006d70c855bf5mr27054343ejc.31.1647966903073; Tue, 22 Mar 2022 09:35:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZ5qO59T0ZtDoKDUR3HIVfCpspb0kTlREXBA6fQbhQ9rJLn7EJtzzUA2eFewM+PQyLlJ3NBmptzDQNL63H4E4= X-Received: by 2002:a17:907:6d0e:b0:6d7:c85:5bf5 with SMTP id sa14-20020a1709076d0e00b006d70c855bf5mr27054317ejc.31.1647966902812; Tue, 22 Mar 2022 09:35:02 -0700 (PDT) MIME-Version: 1.0 References: <20220322154159.5116220423@pchp3.se.axis.com> In-Reply-To: <20220322154159.5116220423@pchp3.se.axis.com> From: Jonathan Wakely Date: Tue, 22 Mar 2022 16:34:51 +0000 Message-ID: Subject: Re: [PATCH] libstdc++-v3 testsuite: Call fesetround(FE_DOWNWARD) only if defined To: Hans-Peter Nilsson Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 16:35:08 -0000 On Tue, 22 Mar 2022 at 15:48, Hans-Peter Nilsson via Libstdc++ wrote: > > Ok to commit? OK, thanks. > > ----- 8< ----- > > Without this, for a typical soft-float target such as cris-elf, after > commit r12-7676-g5a4e208022e704 you'll see, in libstdc++.log: > ... > FAIL: 20_util/from_chars/6.cc (test for excess errors) > Excess errors: > /home/hp/tmp/auto0321/gcc/libstdc++-v3/testsuite/20_util/from_chars/6.cc:33: error: 'FE_DOWNWARD' was not declared in this scope > > UNRESOLVED: 20_util/from_chars/6.cc compilation failed to produce executable > ... > > It appears to be a side-effect of that commit changing the > way __cpp_lib_to_chars is defined. (On the bright side, > ./7.cc now passes since that commit.) > > TFM, specifically fenv(3), says that "Each of the macros > FE_DIVBYZERO, FE_INEXACT, FE_INVALID, FE_OVERFLOW, > FE_UNDERFLOW is defined when the implementation supports > handling of the corresponding exception". > > A git-grep shows that this was the only place using a FE_ macro > unconditionally. > > libstdc++-v3: > * testsuite/20_util/from_chars/6.cc (test01) [FE_DOWNWARD]: > Conditionalize call to fesetround. > > diff --git a/libstdc++-v3/testsuite/20_util/from_chars/6.cc b/libstdc++-v3/testsuite/20_util/from_chars/6.cc > index d33484cebfee..fff3450b56c9 100644 > --- a/libstdc++-v3/testsuite/20_util/from_chars/6.cc > +++ b/libstdc++-v3/testsuite/20_util/from_chars/6.cc > @@ -30,7 +30,9 @@ test01() > #if __cpp_lib_to_chars >= 201611L > #if _GLIBCXX_USE_C99_FENV_TR1 > double d; > +#ifdef FE_DOWNWARD > std::fesetround(FE_DOWNWARD); > +#endif > const std::string s = "0.099999999999999999999999999"; > auto res = std::from_chars(s.data(), s.data() + s.length(), d); > VERIFY( res.ec == std::errc{} ); > -- > 2.30.2 >