From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1EA283857022 for ; Fri, 30 Sep 2022 18:13:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EA283857022 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664561600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cIbKGR0Wa7vt8DKaGWdxkpXFn+yscJWHDg9UoSzLZvA=; b=a3Hxyvn7YLjF5dl2xL8Ey/64q38sVl2U8SJGU/LtqU/oVdXnYxmtvEEUcM6lhKOJeKs+8v SXU9I9D5ZzclAF/BI5O2XZU1buQ9ot6garu057Dm2nc+zMhWI+1hvJxhLdWYWbkDRCUo7+ XuwMI+QBi71Nb7USp1xAWnHM7s7hzSA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-341-WNZ71XciP4-_qg8PEs9ghw-1; Fri, 30 Sep 2022 14:13:11 -0400 X-MC-Unique: WNZ71XciP4-_qg8PEs9ghw-1 Received: by mail-qk1-f199.google.com with SMTP id w10-20020a05620a444a00b006ce9917ea1fso4326484qkp.16 for ; Fri, 30 Sep 2022 11:13:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=cIbKGR0Wa7vt8DKaGWdxkpXFn+yscJWHDg9UoSzLZvA=; b=HisOO0wNRIH6XC6TJHGbmK6ggik3768f0aYZaw1+xMEDKB5/JTR81F/CnJxf00aC78 yQKT5F8ZLkbyBJehqDKp6SPrww3iqR+KFWcYapff6b3vg2PyeOA8ibezRPKhSSpUlc52 m2CKntdcy5nZw+gUgZ4KoeOcc2E+sjdhduc6vibi1yKM9M5qP4BH9MRGm9wSDXB88wY/ iseFoaOa15y/Hsn7kpkEu0yoUcHj3GYM4L4NRuG4MAlLjYUTTiT0Y+XI6602Ef+3cJ0U O29eU/e+2VrPFzok41MNpHBnOvBBuEq8JY8OZMGq1CdXuI8sheRv09tBXnOZuJ0a3q2L zekg== X-Gm-Message-State: ACrzQf3CRHaMf711/sFYTLBgN+bOp58kqBgcLe9pClLMBddD4bzSgf02 vFX9oGCFGApfhGfX90/4V/g2GWz8vuQb9JdZI6JMMSbshR3WRLPY62acJc2tMP1MSsICWmNDaKc TT73ywNp/biwLYXFdJ2zDWNQ4IcRX7Ag= X-Received: by 2002:a37:e319:0:b0:6cd:f643:b6d6 with SMTP id y25-20020a37e319000000b006cdf643b6d6mr7074429qki.616.1664561591115; Fri, 30 Sep 2022 11:13:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7pHzjZElle2mNXFD2MUE6eJCT8sx4gGPMZWCJfKVH/eQJ0tPumLuqqJZcwsk/99IkGEbAENV8945zMNOYrxHg= X-Received: by 2002:a37:e319:0:b0:6cd:f643:b6d6 with SMTP id y25-20020a37e319000000b006cdf643b6d6mr7074410qki.616.1664561590906; Fri, 30 Sep 2022 11:13:10 -0700 (PDT) MIME-Version: 1.0 References: <20220930153845.2268381-1-torbjorn.svensson@foss.st.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 30 Sep 2022 19:12:59 +0100 Message-ID: Subject: Re: [PATCH] testsuite: Windows paths use \ and not / To: Jakub Jelinek Cc: =?UTF-8?Q?Torbj=C3=B6rn_SVENSSON?= , "libstdc++" , gcc-patches@gcc.gnu.org, nathan@acm.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000055830b05e9e8f29e" X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000055830b05e9e8f29e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 30 Sept 2022 at 19:07, Jonathan Wakely wrote: > > On Fri, 30 Sept 2022 at 19:04, Jonathan Wakely wrote= : > > > > On Fri, 30 Sept 2022 at 18:55, Jakub Jelinek wrote: > > > > > > On Fri, Sep 30, 2022 at 06:47:07PM +0100, Jonathan Wakely via Gcc-pat= ches wrote: > > > > On Fri, 30 Sept 2022 at 17:26, Jonathan Wakely wrote: > > > > > > > > > > On Fri, 30 Sept 2022 at 17:04, Torbj=C3=B6rn SVENSSON > > > > > wrote: > > > > > > > > > > > > libstdc++-v3/testsuite: > > > > > > > > > > > > * 20_util/bind/ref_neg.cc: Prune Windows paths too. > > > > > > > > > > Please CC the libstdc++ for libstdc++ patches. > > > > > > > > > > OK for trunk, thanks. > > > > > > > > I'm seeing errors now on x86_64-linux: > > > > > > > > ERROR: 20_util/bind/ref_neg.cc: unknown dg option: /\\ for " > > > > dg-prune-output 53 "[/\\](functional|bits/invoke.h):" " > > > > > > > > ERROR: 20_util/bind/ref_neg.cc: unknown dg option: /\\ for " > > > > dg-prune-output 53 "[/\\](functional|bits/invoke.h):" " > > > > > > Bet it should be > > > // { dg-prune-output "\[/\\](functional|bits\[/\\]invoke.h):" } > > > or so. Completely untested. > > > > That fixes the error, but now the regex doesn't match so there are > > still excess errors. It needs to be: > > > > // { dg-prune-output ".*\[/\\](functional|bits\[/\\]invoke.h):.*" } > > > > Without any regex special characters, there's an implicit .* before > > and after the pattern. But when you use any regex special characters > > in the pattern, it stops working. I can't remember why. I figured it > > out once. > > It looks like just adding .* at the start is enough: > > // { dg-prune-output ".*\[/\\](functional|bits\[/\\]invoke.h):" } > > But that's so ugly, I'm tempted to replace that prune with something diff= erent. I'll finish testing this and push it. --00000000000055830b05e9e8f29e Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8osyyvb0 Y29tbWl0IDhkMTBjMjE1ZmNmODQyNWI0YzUxNGUxZDEwYTE1YTYwODZhYTg0NDIKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBGcmkgU2VwIDMwIDE5 OjEwOjI5IDIwMjIKCiAgICBsaWJzdGRjKys6IEZpeCBicm9rZW4gZGctcHJ1bmUtb3V0cHV0CiAg ICAKICAgIFRoZSBuZXcgcGF0dGVybiBpbiB0aGUgZGctcHJ1bmUtb3V0cHV0IGRpcmVjdGl2ZSBk b2Vzbid0IHdvcmsuIEluc3RlYWQKICAgIG9mIGEgbWVzc3kgcmVnZXggZnVsbCBvZiBsZWFuaW5n IHRvb3RocGlja3MsIGp1c3QgbWF0Y2ggb24gdGhlCiAgICBkaWFnbm9zdGljIHRleHQgaW5zdGVh ZCBvZiB0aGUgaGVhZGVyIHBhdGhzLgogICAgCiAgICBsaWJzdGRjKystdjMvQ2hhbmdlTG9nOgog ICAgCiAgICAgICAgICAgICogdGVzdHN1aXRlLzIwX3V0aWwvYmluZC9yZWZfbmVnLmNjOiBGaXgg ZGctcHJ1bmUtb3V0cHV0CiAgICAgICAgICAgIGRpcmVjdGl2ZS4KCmRpZmYgLS1naXQgYS9saWJz dGRjKystdjMvdGVzdHN1aXRlLzIwX3V0aWwvYmluZC9yZWZfbmVnLmNjIGIvbGlic3RkYysrLXYz L3Rlc3RzdWl0ZS8yMF91dGlsL2JpbmQvcmVmX25lZy5jYwppbmRleCAxZTlmM2U3ZmVjZS4uMWQ0 YjFiNjZjNzYgMTAwNjQ0Ci0tLSBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC9iaW5k L3JlZl9uZWcuY2MKKysrIGIvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMF91dGlsL2JpbmQvcmVm X25lZy5jYwpAQCAtNTAsNyArNTAsNyBAQCB2b2lkIHRlc3QwMigpCiAKIC8vIElnbm9yZSB0aGUg cmVhc29ucyBmb3IgZGVkdWN0aW9uL3N1YnN0aXR1dGlvbiBmYWlsdXJlIGluIHRoZSBoZWFkZXJz LgogLy8gQXJyYW5nZSBmb3IgdGhlIG1hdGNoIHRvIHdvcmsgb24gaW5zdGFsbGVkIHRyZWVzIGFz IHdlbGwgYXMgYnVpbGQgdHJlZXMuCi0vLyB7IGRnLXBydW5lLW91dHB1dCAiWy9cXF0oZnVuY3Rp b25hbHxiaXRzL2ludm9rZS5oKToiIH0KKy8vIHsgZGctcHJ1bmUtb3V0cHV0ICJubyB0eXBlIG5h bWVkICd0eXBlJyBpbiAuKnN0ZDo6cmVzdWx0X29mIiB9CiAKIGludCBtYWluKCkKIHsK --00000000000055830b05e9e8f29e--