From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 1AE4539B340E for ; Fri, 18 Jun 2021 21:55:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1AE4539B340E Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-0r7PwcXtPSa7CibzqM0sng-1; Fri, 18 Jun 2021 17:55:30 -0400 X-MC-Unique: 0r7PwcXtPSa7CibzqM0sng-1 Received: by mail-wr1-f69.google.com with SMTP id l6-20020a0560000226b029011a80413b4fso1693574wrz.23 for ; Fri, 18 Jun 2021 14:55:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4zPTy1Akya2L+kH+KJO1mBZM+xTGGJvwIfBa3qwDWbM=; b=U2iSzGH36F3w+nzTlnvr2QEByO6bEQWNt6KXAGSJ8JWwbgAJ6edHvAFYSk/zCpDuzZ Mo80fw/ys/pvpQOByYZxE2JI1DMTKvF3ASIMXEjRPBmZ0/T/dWkc1F84npSxK92l3Oja +Lxa0c2JFHYxR/Obug2VjrTJyQPBpAWgrOmhTHI9cPRBmm7BPFzIWUIKBYFxkV0K2IKu cqMH9XNkRZsmEULXWD+hvFdbISXR39JPvyfdHW7Y1EQwaTdBr7nHb6RXS8T99a2QYYjp vgsx011qcrpTOsBPZ8QDPrxXbJ1MkgqPynj5SogukiS89K3zf6gGVghkNKSK+lwa9/Bs oFiA== X-Gm-Message-State: AOAM531ajJ3UwZLevhC3rJPqqpu0+oTL1kBxM9xsk2ssOPe085YK062K tOLn2l/G4/k8F2FzMEqGvNAm5D9PMRpAqahD8R3VxrwCpE505m/b2TBMoATZXqTMH+jO1OGFLz5 hhSBu91BBciebxCCAxinKtAT7qUCe+2k= X-Received: by 2002:a05:6000:cb:: with SMTP id q11mr14885003wrx.13.1624053328921; Fri, 18 Jun 2021 14:55:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzquzu15k/b8/mw/pjIs0eaLbzq4gEi9YARrGyHuX7scRC3lIuVNC61wC7nf6Nh4Bzd/ansDUyHz3NdOMhBN9Y= X-Received: by 2002:a05:6000:cb:: with SMTP id q11mr14884997wrx.13.1624053328737; Fri, 18 Jun 2021 14:55:28 -0700 (PDT) MIME-Version: 1.0 References: <20210618040010.1668974-1-ppalka@redhat.com> In-Reply-To: <20210618040010.1668974-1-ppalka@redhat.com> From: Jonathan Wakely Date: Fri, 18 Jun 2021 22:55:17 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Implement LWG 3555 changes to transform/elements_view To: Patrick Palka Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 21:55:33 -0000 On Fri, 18 Jun 2021 at 05:04, Patrick Palka via Libstdc++ wrote: > > libstdc++-v3/ChangeLog: > > * include/std/ranges (transform_view::_Iterator::_S_iter_concept): > Consider _Base instead of _Vp as per LWG 3555. > (elements_view::_Iterator::_S_iter_concept): Likewise. OK > --- > libstdc++-v3/include/std/ranges | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges > index f93a880ff8a..bf85b1629f0 100644 > --- a/libstdc++-v3/include/std/ranges > +++ b/libstdc++-v3/include/std/ranges > @@ -1613,11 +1613,11 @@ namespace views::__adaptor > static auto > _S_iter_concept() > { > - if constexpr (random_access_range<_Vp>) > + if constexpr (random_access_range<_Base>) > return random_access_iterator_tag{}; > - else if constexpr (bidirectional_range<_Vp>) > + else if constexpr (bidirectional_range<_Base>) > return bidirectional_iterator_tag{}; > - else if constexpr (forward_range<_Vp>) > + else if constexpr (forward_range<_Base>) > return forward_iterator_tag{}; > else > return input_iterator_tag{}; > @@ -3659,11 +3659,11 @@ namespace views::__adaptor > static auto > _S_iter_concept() > { > - if constexpr (random_access_range<_Vp>) > + if constexpr (random_access_range<_Base>) > return random_access_iterator_tag{}; > - else if constexpr (bidirectional_range<_Vp>) > + else if constexpr (bidirectional_range<_Base>) > return bidirectional_iterator_tag{}; > - else if constexpr (forward_range<_Vp>) > + else if constexpr (forward_range<_Base>) > return forward_iterator_tag{}; > else > return input_iterator_tag{}; > -- > 2.32.0.93.g670b81a890 >