From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 459043858286 for ; Mon, 17 Oct 2022 08:48:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 459043858286 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665996535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cDkQlLZBRn2Nh9CSWD1XAshJJ5siZGj2Zpc94xv+5XM=; b=ilCytpfaHzNbzNdWRYsqMCD46JRvgWmjWIPDFrdKGMI9P4brOC2jaK3rVF3taRquhnCwtE WqnCvQ7cIuf68qO86fRdfmc9YWaBjACF32LbZriBnw3r6Fy03Y/4h+fk81b7zOz0okC9xt A5Z5FRXCNevss/+AcSjPJjlT4Lbl0ZA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-500-ra12v2KpN5mNWVAt0Zj1xA-1; Mon, 17 Oct 2022 04:48:53 -0400 X-MC-Unique: ra12v2KpN5mNWVAt0Zj1xA-1 Received: by mail-qk1-f198.google.com with SMTP id bj1-20020a05620a190100b006eececec791so6870765qkb.15 for ; Mon, 17 Oct 2022 01:48:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sHDEEae0Lc2JZtRu03WxdXLKRkcStDgfuKnH+65V17I=; b=UWsKzo552YClz/CrG4sb1u4t78H0D/eiLjqIx2/4RJ/UB0X1Rf8NapLe7IqJdDE7GN bi8Vll86uirzxwTg8iheLoyk+tdDgArvJnA/oVSeMNLxZtdJzpnxpdp3oXoGgVCMq78/ wuUGNCqCxWOrFKErv5pgRn6UCdXvaReliAmAeCFM1cTgUPVai+PbbrYHnUjFZYP6/QzR J3PRfla5SKNcI5DWjRc8lGSyd3nDwwvQcR02jtHEHH0Ot6Qo0xN6XgYmjykfo2fbI9FJ YZP8NIJQClgjL1FMer5qZ40akHoqgWSYm5lba9VwYP3IC/kHgU/HuWkNYTMwAnreiSFT Y3FA== X-Gm-Message-State: ACrzQf32U97N+dZtnsHBG3IN47IAxyMqhADpdq+YK9dIG+0dhDihgIEs j8vBOxBVTW6K86T9w61DhJnBgmnkp6a0d1wPvSbdHB3o545WEHZvcD6TVC2SLw2flDHNlIvJ/mw XEjdsthKWdbX+4i0xDEW5dyF8CvqiZhU= X-Received: by 2002:a05:622a:19a0:b0:39c:ba70:e475 with SMTP id u32-20020a05622a19a000b0039cba70e475mr7722061qtc.50.1665996533015; Mon, 17 Oct 2022 01:48:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Vycao1gj9HC9XXYeQEf/yko/oWoCCIIvjwTakSL8DSEGbjs8Sd4mrwJQBDLZRBid+qZr4h6Pp5cNDAmri3UI= X-Received: by 2002:a05:622a:19a0:b0:39c:ba70:e475 with SMTP id u32-20020a05622a19a000b0039cba70e475mr7722055qtc.50.1665996532842; Mon, 17 Oct 2022 01:48:52 -0700 (PDT) MIME-Version: 1.0 References: <20221015202518.2687700-1-jwakely@redhat.com> In-Reply-To: <20221015202518.2687700-1-jwakely@redhat.com> From: Jonathan Wakely Date: Mon, 17 Oct 2022 09:48:41 +0100 Message-ID: Subject: Re: [committed] libstdc++: Implement constexpr std::to_chars for C++23 (P2291R3) To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000089fbec05eb370bb3" X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000089fbec05eb370bb3 Content-Type: text/plain; charset="UTF-8" On Sat, 15 Oct 2022 at 21:26, Jonathan Wakely via Libstdc++ wrote: > > libstdc++-v3/ChangeLog: > > * include/bits/charconv.h (__to_chars_10_impl): Add constexpr > for C++23. Remove 'static' from array. > * include/std/charconv (__cpp_lib_constexpr_charconv): Define. I managed to define the feature test macro with the wrong value. Fixed by the attached patch, pushed to trunk. --00000000000089fbec05eb370bb3 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l9cjb2hn0 Y29tbWl0IDBmNDgxNTUwMmQ4ZGFjMDc1NzlkYzdhNWE0MGM1OTdhMTgyOTFiNGMKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBNb24gT2N0IDE3IDA5 OjM4OjAyIDIwMjIKCiAgICBsaWJzdGRjKys6IEZpeCB2YWx1ZSBvZiBfX2NwcF9saWJfY29uc3Rl eHByX2NoYXJjb252CiAgICAKICAgIGxpYnN0ZGMrKy12My9DaGFuZ2VMb2c6CiAgICAKICAgICAg ICAgICAgKiBpbmNsdWRlL3N0ZC9jaGFyY29udiAoX19jcHBfbGliX2NvbnN0ZXhwcl9jaGFyY29u dik6IERlZmluZSB0bwogICAgICAgICAgICBjb3JyZWN0IHZhbHVlLgogICAgICAgICAgICAqIGlu Y2x1ZGUvc3RkL3ZlcnNpb24gKF9fY3BwX2xpYl9jb25zdGV4cHJfY2hhcmNvbnYpOiBMaWtld2lz ZS4KICAgICAgICAgICAgKiB0ZXN0c3VpdGUvMjBfdXRpbC90b19jaGFycy9jb25zdGV4cHIuY2M6 IENoZWNrIGNvcnJlY3QgdmFsdWUuCiAgICAgICAgICAgICogdGVzdHN1aXRlLzIwX3V0aWwvdG9f Y2hhcnMvdmVyc2lvbi5jYzogTGlrZXdpc2UuCgpkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL2lu Y2x1ZGUvc3RkL2NoYXJjb252IGIvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL2NoYXJjb252Cmlu ZGV4IDRiNmNjODNhNTY3Li43YWVmZGQzMjk4YyAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYzL2lu Y2x1ZGUvc3RkL2NoYXJjb252CisrKyBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9jaGFyY29u dgpAQCAtNTEsNyArNTEsNyBAQAogI2VuZGlmCiAKICNpZiBfX2NwbHVzcGx1cyA+IDIwMjAwMkwK LSMgZGVmaW5lIF9fY3BwX2xpYl9jb25zdGV4cHJfY2hhcmNvbnYgMjAyMjAyTAorIyBkZWZpbmUg X19jcHBfbGliX2NvbnN0ZXhwcl9jaGFyY29udiAyMDIyMDdMCiAjZW5kaWYKIAogbmFtZXNwYWNl IHN0ZCBfR0xJQkNYWF9WSVNJQklMSVRZKGRlZmF1bHQpCmRpZmYgLS1naXQgYS9saWJzdGRjKyst djMvaW5jbHVkZS9zdGQvdmVyc2lvbiBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC92ZXJzaW9u CmluZGV4IGJlYzllN2FhNzkyLi4zYzdjNDQwYmQ4MCAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYz L2luY2x1ZGUvc3RkL3ZlcnNpb24KKysrIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL3ZlcnNp b24KQEAgLTMwMiw3ICszMDIsNyBAQAogI2lmIF9fY3BsdXNwbHVzID4gMjAyMDAyTAogLy8gYysr MjMKICNkZWZpbmUgX19jcHBfbGliX2J5dGVzd2FwIDIwMjExMEwKLSNkZWZpbmUgX19jcHBfbGli X2NvbnN0ZXhwcl9jaGFyY29udiAyMDIyMDJMCisjZGVmaW5lIF9fY3BwX2xpYl9jb25zdGV4cHJf Y2hhcmNvbnYgMjAyMjA3TAogI2RlZmluZSBfX2NwcF9saWJfY29uc3RleHByX3R5cGVpbmZvIDIw MjEwNkwKICNpZiBfX2NwcF9jb25jZXB0cyA+PSAyMDIwMDJMCiAjIGRlZmluZSBfX2NwcF9saWJf ZXhwZWN0ZWQgMjAyMjAyTApkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMF91 dGlsL3RvX2NoYXJzL2NvbnN0ZXhwci5jYyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRp bC90b19jaGFycy9jb25zdGV4cHIuY2MKaW5kZXggMzBjNTkxNjU5ZWUuLjEwODU1YjczN2M3IDEw MDY0NAotLS0gYS9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIwX3V0aWwvdG9fY2hhcnMvY29uc3Rl eHByLmNjCisrKyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC90b19jaGFycy9jb25z dGV4cHIuY2MKQEAgLTUsNyArNSw3IEBACiAKICNpZm5kZWYgX19jcHBfbGliX2NvbnN0ZXhwcl9j aGFyY29udgogIyBlcnJvciAiRmVhdHVyZS10ZXN0IG1hY3JvIGZvciBjb25zdGV4cHIgY2hhcmNv bnYgbWlzc2luZyBpbiA8Y2hhcmNvbnY+IgotI2VsaWYgX19jcHBfbGliX2NvbnN0ZXhwcl9jaGFy Y29udiAhPSAyMDIyMDJMCisjZWxpZiBfX2NwcF9saWJfY29uc3RleHByX2NoYXJjb252ICE9IDIw MjIwN0wKICMgZXJyb3IgIkZlYXR1cmUtdGVzdCBtYWNybyBmb3IgY29uc3RleHByIGNoYXJjb252 IGhhcyB3cm9uZyB2YWx1ZSBpbiA8Y2hhcmNvbnY+IgogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL2xp YnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC90b19jaGFycy92ZXJzaW9uLmNjIGIvbGlic3Rk YysrLXYzL3Rlc3RzdWl0ZS8yMF91dGlsL3RvX2NoYXJzL3ZlcnNpb24uY2MKaW5kZXggYWYwNmUx YmYwNTQuLjI1YjFlMDAzNmU4IDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIw X3V0aWwvdG9fY2hhcnMvdmVyc2lvbi5jYworKysgYi9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIw X3V0aWwvdG9fY2hhcnMvdmVyc2lvbi5jYwpAQCAtMTEsNiArMTEsNiBAQAogCiAjaWZuZGVmIF9f Y3BwX2xpYl9jb25zdGV4cHJfY2hhcmNvbnYKICMgZXJyb3IgIkZlYXR1cmUtdGVzdCBtYWNybyBm b3IgY29uc3RleHByIGNoYXJjb252IG1pc3NpbmcgaW4gPHZlcnNpb24+IgotI2VsaWYgX19jcHBf bGliX2NvbnN0ZXhwcl9jaGFyY29udiAhPSAyMDIyMDJMCisjZWxpZiBfX2NwcF9saWJfY29uc3Rl eHByX2NoYXJjb252ICE9IDIwMjIwN0wKICMgZXJyb3IgIkZlYXR1cmUtdGVzdCBtYWNybyBmb3Ig Y29uc3RleHByIGNoYXJjb252IGhhcyB3cm9uZyB2YWx1ZSBpbiA8dmVyc2lvbj4iCiAjZW5kaWYK --00000000000089fbec05eb370bb3--