Re: [committed] libstdc++: Move closing brace outside #endif [PR104866]

[Jonathan Wakely <jwakely@redhat.com>]

On Fri, 11 Mar 2022 at 15:12, Jonathan Wakely wrote:
>
> On Fri, 11 Mar 2022 at 14:28, Detlef Vollmann wrote:
> >
> > Hi Jonathan,
> >
> > On 3/10/22 22:11, Jonathan Wakely wrote:
> >
> > > Tested x86_64-linux, pushed to trunk.
> >
> > Thanks.
> > With this and the other fix I was able to build the complete
> > libstdc++ for AVR based on AVR Libc 2.0 (plus some ad hoc
> > AVR header fixes) from git master 5e28be89.
>
> Nice. I finally figure out that I need to use --enable-libstdcxx *not*
> --enable-libstdc++-v3 to build for AVR, and now I get errors due to
> EOVERFLOW being undefined. Is that what you fixed?
>
> We should make that work. Arguably, all values of std::errc should
> exist, even if the OS <errno.h> doesn't provide a constant. We could
> define the missing ones ourselves, choosing numbers > 1000 (and hope
> the OS uses small numbers for its own errno values).

I opened https://gcc.gnu.org/PR104883 for this.


>
> >
> > And a small example with pmr::string and pmr::vector worked :-)
>
> Great!