From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B35F33857816 for ; Fri, 11 Mar 2022 15:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B35F33857816 Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-571-GN9tgJiuNsej8FQNQ7YklQ-1; Fri, 11 Mar 2022 10:21:43 -0500 X-MC-Unique: GN9tgJiuNsej8FQNQ7YklQ-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-2d07ae11467so71419027b3.12 for ; Fri, 11 Mar 2022 07:21:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eOtyyUj6C4P3U/QTWj0egLLy0XlZb0yEL8K2EYpErqY=; b=7ZmuuD/vmTMDS8NJf7PHqO7RtFHIo5wuShDlYyMYGY2m7ETZ4QRo15lCTNe7DtUR/t tNEp2xdNQAljtg4Z/EfvhehvhWRyaboK+agCMFfYp/81U8GlRnv7b0y2d/bDNGuIV/PR +6zz40+DeRlTNAmPyJJfWpoEpvTUx8fpqkYh4NM1rhSNuX2DFRCDtDcDDqU8eqNJuAJJ PlSRGecRvLh6idJqxPL7vB9f0fK02Py3ylChgAg9BkS9KSEJfxJ8kNmjAsav1CfB1ZFA Mj5SCrpl1gHT2t6jJe5YUVnLTh9yyBwpJYfBZgvPJNBoYZFc+pEVOYzdrn1Pp0flMj2/ v6TA== X-Gm-Message-State: AOAM533AqyyzBCimJrlDSPfNuSADPxQMIzXvLTS0qKfwT/qnjjG78RPL KpmrjY61JFASmmcHf7Iztv0jjOnJaTKofFY3qaj5fXhUqOJSC9wLuzzx5Bi+zJFHbFTEmUQkeR1 vgYnPZzlo4pyZPA4C7tNyoj0C4BMO8SU= X-Received: by 2002:a81:1606:0:b0:2dc:19f9:626a with SMTP id 6-20020a811606000000b002dc19f9626amr8740288yww.346.1647012102605; Fri, 11 Mar 2022 07:21:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJw6u3Pq1LfQEOR/Ae0RBFsUozeyjd4YXWa03MidPEGfFS1ci+ZEDTD8eq/ZIQl+PV3bzCZN7mhBcRIVn/+29Ss= X-Received: by 2002:a81:1606:0:b0:2dc:19f9:626a with SMTP id 6-20020a811606000000b002dc19f9626amr8740265yww.346.1647012102333; Fri, 11 Mar 2022 07:21:42 -0800 (PST) MIME-Version: 1.0 References: <20220310211107.1757824-1-jwakely@redhat.com> <4b5afc64-39f6-db5a-c6ba-144af10c698a@vollmann.ch> In-Reply-To: From: Jonathan Wakely Date: Fri, 11 Mar 2022 15:21:31 +0000 Message-ID: Subject: Re: [committed] libstdc++: Move closing brace outside #endif [PR104866] To: Detlef Vollmann Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 15:21:51 -0000 On Fri, 11 Mar 2022 at 15:12, Jonathan Wakely wrote: > > On Fri, 11 Mar 2022 at 14:28, Detlef Vollmann wrote: > > > > Hi Jonathan, > > > > On 3/10/22 22:11, Jonathan Wakely wrote: > > > > > Tested x86_64-linux, pushed to trunk. > > > > Thanks. > > With this and the other fix I was able to build the complete > > libstdc++ for AVR based on AVR Libc 2.0 (plus some ad hoc > > AVR header fixes) from git master 5e28be89. > > Nice. I finally figure out that I need to use --enable-libstdcxx *not* > --enable-libstdc++-v3 to build for AVR, and now I get errors due to > EOVERFLOW being undefined. Is that what you fixed? > > We should make that work. Arguably, all values of std::errc should > exist, even if the OS doesn't provide a constant. We could > define the missing ones ourselves, choosing numbers > 1000 (and hope > the OS uses small numbers for its own errno values). I opened https://gcc.gnu.org/PR104883 for this. > > > > > And a small example with pmr::string and pmr::vector worked :-) > > Great!