From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 08EC23858412 for ; Mon, 11 Jul 2022 10:19:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08EC23858412 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-590-DzkpPc_ZNoSWo3UqC4aa1Q-1; Mon, 11 Jul 2022 06:19:30 -0400 X-MC-Unique: DzkpPc_ZNoSWo3UqC4aa1Q-1 Received: by mail-qt1-f199.google.com with SMTP id bb14-20020a05622a1b0e00b0031eb88da7d0so736220qtb.3 for ; Mon, 11 Jul 2022 03:19:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4toN/JYllG+/3XyGPvuAJ0LntCZ4YFX5uFPj6IKTYyI=; b=OeHiwvvS8nh7j9pT50wnDG00oc/RfTgj/pqDaaP7RRs0UC/kVRJJ9YkidL0Z7q9vnx s+qjf/Nd/gzKkKgQKRHqwHCj2uRzWCNuqgz/hmRLrtLjYsBCAvBqELxqdXKxEj/zSuIj 4jGA918l+0Xd8eOPYztia8713iE4QcJDD6oZj710iBhNddoa7I5jyIFIOKOi8mQgKAV1 4Zfj3rb96lvjw4QTpcmiS5so4pri+ldK98khdh2NrCOivox4UlfSBcaRHrLIwSo1LawB HGUKYIaCUarX7k5qB6E8II/2625sS9yTxtWV+xpeWir7Hd+hzgT1810j0XwjE/nT2jed GBww== X-Gm-Message-State: AJIora9Ls+klmIzoqlu3TVm8ThxMfaYIHGPYhgoycFkCQa1rLlytEAvh HURY0kcB8EXlcgea2Ws1jwOIISw0KrTn1vwzdO1FyFKLaUHPkyRynvxwi+FwNALQ+WBVCLYFJYg bJWvVPDrDseuittABzHZUr/gsEMEgpa4= X-Received: by 2002:a05:6214:f28:b0:473:5e46:c32a with SMTP id iw8-20020a0562140f2800b004735e46c32amr6467466qvb.43.1657534770399; Mon, 11 Jul 2022 03:19:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uyj4P7N6Qn1eP0hfbcYmAl5FMkzhvb0cftRb9Qu2LPwSD75k6+KfOO/5o9arRl+CLkmNJ+ynAvifV0lWnqmpo= X-Received: by 2002:a05:6214:f28:b0:473:5e46:c32a with SMTP id iw8-20020a0562140f2800b004735e46c32amr6467455qvb.43.1657534770237; Mon, 11 Jul 2022 03:19:30 -0700 (PDT) MIME-Version: 1.0 References: <20220708174133.2462418-1-polacek@redhat.com> In-Reply-To: <20220708174133.2462418-1-polacek@redhat.com> From: Jonathan Wakely Date: Mon, 11 Jul 2022 11:19:19 +0100 Message-ID: Subject: Re: [PATCH] c++: Add __reference_con{struc, ver}ts_from_temporary [PR104477] To: Marek Polacek Cc: GCC Patches , "libstdc++" , Jason Merrill X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 10:19:33 -0000 On Fri, 8 Jul 2022 at 18:41, Marek Polacek wrote: > The patch also adds the relevant class and variable templates to . + template + struct reference_constructs_from_temp orary + : public __bool_constant<__reference_constructs_from_temporary(_Tp, _Up)> This can use bool_constant, as that was added in C++17. __bool_constant is the internal equivalent for pre-C++17. The library parts are fine with that change, thanks for implementing this!