From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [committed] libstdc++: Add #error to some files that depend on a specific standard mode
Date: Thu, 12 Aug 2021 17:15:45 +0100 [thread overview]
Message-ID: <CACb0b4m95NJqkf8ngrMogLj6DU9e7bV59eSMi3A=FnsZfbSeYg@mail.gmail.com> (raw)
In-Reply-To: <405ea661-b191-3e55-28bd-783aef8c97be@gmail.com>
On Thu, 12 Aug 2021 at 15:23, François Dumont wrote:
>
> On 12/08/21 4:04 pm, Jonathan Wakely via Libstdc++ wrote:
> > Give more explicit errors if these files are not built with the correct
> > -std options.
> >
> > libstdc++-v3/ChangeLog:
> >
> > * src/c++98/locale_init.cc: Require C++11.
> > * src/c++98/localename.cc: Likewise.
> > * src/c++98/misc-inst.cc: Require C++98.
> >
> > Tested powerpc64le-linux. Committed to trunk.
> >
> Shouldn't they be moved to src/c++11 ?
Yes, see src/c++98/Makefile.am
# XXX TODO move locale_init.cc and localename.cc to src/c++11
locale_init.lo: locale_init.cc
$(LTCXXCOMPILE) -std=gnu++11 -fchar8_t -c $<
locale_init.o: locale_init.cc
$(LTCXXCOMPILE) -std=gnu++11 -fchar8_t -c $<
localename.lo: localename.cc
$(LTCXXCOMPILE) -std=gnu++11 -fchar8_t -c $<
localename.o: localename.cc
$(LTCXXCOMPILE) -std=gnu++11 -fchar8_t -c $<
I didn't do that years ago because it would have lost the file history
with subversion. With Git, it should be OK because Git will track the
history across the move. I'll add it to my TODO list.
prev parent reply other threads:[~2021-08-12 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 14:04 Jonathan Wakely
2021-08-12 14:22 ` François Dumont
2021-08-12 16:15 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4m95NJqkf8ngrMogLj6DU9e7bV59eSMi3A=FnsZfbSeYg@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).