From: Jonathan Wakely <jwakely@redhat.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Matthias Kretz <m.kretz@gsi.de>,
"libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v3] libstdc++: Improve std::lock algorithm
Date: Wed, 23 Jun 2021 10:17:35 +0100 [thread overview]
Message-ID: <CACb0b4m=WS2h1ad54CcBEr0Y_1F3YECQbOetk-j3M_U1_Q_ZSw@mail.gmail.com> (raw)
In-Reply-To: <CAKdteOYJHRPd5SYM1uvZ1SyUBtYazF6VouC3w+SgOJPLB-6guw@mail.gmail.com>
On Wed, 23 Jun 2021 at 08:21, Christophe Lyon wrote:
> This patch causes GCC build failures for bare-metal targets
> (aarch64-elf, arm-eabi). For instance on arm-eabi, I'm seeing:
>
> In file included from
> /tmp/1229695_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/include/future:38,
> from
> /tmp/1229695_7.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/include/precompiled/stdc++.h:105:
> /tmp/1229695_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/include/mutex:
> In function 'int std::__detail::__try_lock_impl(_Lockable&)':
> /tmp/1229695_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/include/mutex:522:53:
> error: expected primary-expression before ',' token
> 522 | if (unique_lock<_Lockable> __lock{__lockable, try_to_lock})
> | ^
> In file included from
> /tmp/1229695_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/include/future:38,
> from
> /tmp/1229695_7.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libstdc++-v3/include/precompiled/stdc++.h:105:
> /tmp/1229695_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/include/mutex:
> In function 'int std::__detail::__try_lock_impl(_Lockable&)':
> /tmp/1229695_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/include/mutex:522:53:
> error: expected primary-expression before ',' token
> 522 | if (unique_lock<_Lockable> __lock{__lockable, try_to_lock})
> | ^
> make[4]: *** [Makefile:1862:
> arm-none-eabi/bits/stdc++.h.gch/O2ggnu++0x.gch] Error 1
Sigh, __lockable is a macro in newlib:
newlib/libc/include/sys/cdefs.h:#define __lockable
__lock_annotate(lockable)
I'll change the name.
next prev parent reply other threads:[~2021-06-23 9:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 17:31 [committed] " Jonathan Wakely
2021-06-22 9:07 ` Matthias Kretz
2021-06-22 12:51 ` [PATCH v2] " Jonathan Wakely
2021-06-22 13:21 ` Matthias Kretz
2021-06-22 15:20 ` Jonathan Wakely
2021-06-22 16:03 ` Matthias Kretz
2021-06-22 19:51 ` Jonathan Wakely
2021-06-22 20:32 ` [PATCH v3] " Jonathan Wakely
2021-06-23 7:21 ` Christophe Lyon
2021-06-23 9:17 ` Jonathan Wakely [this message]
2021-06-23 9:43 ` Christophe LYON
2021-06-23 10:11 ` Jonathan Wakely
2021-06-23 11:16 ` Christophe LYON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4m=WS2h1ad54CcBEr0Y_1F3YECQbOetk-j3M_U1_Q_ZSw@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=m.kretz@gsi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).