From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 426693851C35 for ; Thu, 2 Sep 2021 21:26:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 426693851C35 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-CdQgI8USNduy9cw10R0Hqw-1; Thu, 02 Sep 2021 17:25:59 -0400 X-MC-Unique: CdQgI8USNduy9cw10R0Hqw-1 Received: by mail-wm1-f70.google.com with SMTP id c4-20020a1c9a04000000b002e864b7edd1so1214682wme.6 for ; Thu, 02 Sep 2021 14:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WTyKKrYwUs/zfPi6Ey8qdGAOMesaI6Q1HygKSlXY8Fc=; b=dhapmH80/OlWr8IO/zsBUci0EqxUvoFgE0yyv16jz05LF2iZHo7sj23QCv42hMu/H1 DyqoHiTRHHRezSp+SmS3hMCPzJYsoKprxzazfwBY0Wdz3ahQxVw41MnZ4hLWasUsRwzT JUGvs+uwH7AFVCgwL+rTmiQT6uC6cBHp06K9VBnlX585uxlcbiipqJsNyujUyUjBcdA4 Aw1rk1mrkSIkllhBkfW/XHdmpHBUqr0zF/OTdPLM9dMipjjwlSbteOQ4fJOXtUZEeZpr EDxw5FPJq0ogqQOV2ZqbcsCzs0tOvgJXPuhHdprn9J1YMaVcUaUe+C0IVeswSDdTW7n0 XXhA== X-Gm-Message-State: AOAM532toOThsnMW+pbaToPESkRbjDp+KYwIROixF9HhnHvgnWwwFFAY v+mYDFD8cpwpokK+fEDIF0b/1JBdelB6pRV6SSuM8SpsBbVJkI8COn7pnu2YxSCrBK5kfCH1Uwt VeJjLoTGyKQmYhjQA5Bx7ZpkW9SILvmg= X-Received: by 2002:a5d:5452:: with SMTP id w18mr260522wrv.221.1630617957803; Thu, 02 Sep 2021 14:25:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweU4MO5uTgwFxFegW04VLR+V9kkSBbiFMx983ESB83XsGUD26qnv45sSw8lSe11SVrEh5SMGPy1h9ucmnqjMM= X-Received: by 2002:a5d:5452:: with SMTP id w18mr260510wrv.221.1630617957458; Thu, 02 Sep 2021 14:25:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Thu, 2 Sep 2021 22:25:46 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Define macro before it is first checked To: Jonathan Wakely Cc: "libstdc++" , gcc Patches , Thomas Rodgers X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 21:26:04 -0000 On Thu, 2 Sept 2021 at 19:00, Jonathan Wakely wrote: > > * include/bits/atomic_wait.h (_GLIBCXX_HAVE_PLATFORM_WAIT): > Define before first attempt to check it. > > Tested x86_64-linux and powerpc64-linux, not committed yet. Actually ignore that ... I tested the wrong patch. This one introduces a new FAIL, which I have a fix for, but it will have to wait for next week. > I think we need this, otherwise __platform_wait_uses_type is false > for all T. > >