From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D9146395B069 for ; Wed, 16 Nov 2022 13:48:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9146395B069 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668606514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mHV3CQFw2Zn7SOvbdHuyo5VkKnfm5vfpbkbjZbsh188=; b=Ek5uAbLQZojZ7Ym9G5PW4XA6CiU561qQWXI1oMuG2O2mb/u20UcH/v5uXe710j0Py1X4Yh 8vw/V2hjN8ov9ugmwdKei3k74bmRAxjjbWW+TsmfpeQQV/8YRs/HFnbqFc5u8jxhd+B+xA vpJA2/1vTZBju9WkNFHlK58hOpiWxlA= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-662-AGjWUdUzMHyTDHAPCX-_Nw-1; Wed, 16 Nov 2022 08:48:33 -0500 X-MC-Unique: AGjWUdUzMHyTDHAPCX-_Nw-1 Received: by mail-ej1-f69.google.com with SMTP id nb1-20020a1709071c8100b007ae4083d6f5so9895105ejc.15 for ; Wed, 16 Nov 2022 05:48:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mHV3CQFw2Zn7SOvbdHuyo5VkKnfm5vfpbkbjZbsh188=; b=seaQErYhNMN+lVP6A7AB7EaY93AC77FWM08ukmNvZq9kkCN04JAziK1z01tHljbP+g JpMaY6GinTSQnudWAvbDmfedwXjst/UHJ5m5wLeq6wLxekRIx/lvpYqrre0ZhdJPoK5+ O+4hWe5ZaG7sQYsbTLWyEZIbqN0VAVnmzIXp+S/BS01Zelgi0+18jevoTFDtbcW4zBUI zb+zjgY8aarMhJEPSA5ilgAEmbn0USCYVh/9lEox6xZW/11BWu1OYFm9i9z02RVqKpmi aKswm7M0Id10k3KtAQTGvR4wvUQczVr6PKud11A+2Y8ts7B4pD8I9cjb1o02bXKjRHFt WhFw== X-Gm-Message-State: ANoB5plsBktqRYczpj5VfbYKSec5Fq085VlrRwf5XWkArocb2AQB11as b3CkuwlW3SOkyRxZvg5fctQY2kN9WJKK1weAY7FQPmpEhNEFEkoX/1sJ4jq3Gqx0GqpBPSfXRWg 1FgxNf79Ks2oaZ5fIhBKIJjsdPK/G3Bc= X-Received: by 2002:a17:907:2b26:b0:7ae:c460:c65f with SMTP id gc38-20020a1709072b2600b007aec460c65fmr17452402ejc.226.1668606512018; Wed, 16 Nov 2022 05:48:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf5B/48ZqJeFoT+sP7Ogrp/BDi2Bpb24RPZDY6Drig55Ufy1fSpU2nN32sg3+/MDG3lNQpsdpneHAYpxcuWdNvM= X-Received: by 2002:a17:907:2b26:b0:7ae:c460:c65f with SMTP id gc38-20020a1709072b2600b007aec460c65fmr17452390ejc.226.1668606511786; Wed, 16 Nov 2022 05:48:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 16 Nov 2022 13:48:20 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Fix up for extended floating point types [PR107649] To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000067bfb305ed96badd" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000067bfb305ed96badd Content-Type: text/plain; charset="UTF-8" On Wed, 16 Nov 2022 at 13:47, Jakub Jelinek wrote: > On Wed, Nov 16, 2022 at 01:45:19PM +0000, Jonathan Wakely wrote: > > > On Mon, 14 Nov 2022 at 13:57, Jakub Jelinek wrote: > > > > > >> Hi! > > >> > > >> As filed by Jonathan in the PR, I've screwed up the requires syntax > > >> in the extended floating point specialization: > > >> - requires(__complex_type<_Tp>::type) > > >> + requires requires { typename __complex_type<_Tp>::type; } > > >> and doing this change resulted in lots of errors because > > >> __complex_whatever > > >> overfloads from extended floating point types were declared after the > > >> templates which used them. > > >> > > >> The following patch fixes that. > > >> > > >> Bootstrapped/regtested on x86_64-linux and i686-linux, additionally > > >> I've tested that with _GLIBCXX_HAVE_FLOAT128_MATH not being defined > > >> while __STDCPP_FLOAT128_T__ defined one can still use > > >> std::complex for basic arithmetic etc., just one > can't > > >> expect std::sin etc. to work in that case (because we don't have any > > >> implementation). > > >> > > >> Ok for trunk? > > >> > > > > > > OK, thanks for the quick fix. > > > > > > > Oh, also no released version of Clang can handle the C++20 rules about > > 'typename' yet, so we get this error: > > > > complex:1843:15: error: no template named 'type' in '__complex_ty > > pe<_Tp>'; did you mean 'ctype'? > > typedef std::__complex_type<_Tp>::type _ComplexT; > > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > It needs a 'typename' after 'typedef'. > > > > I can add that if you want though. > > Can you? Sorry, I have already committed the patch before noticing your > mail. > Yes, no problem, I'll do it. --00000000000067bfb305ed96badd--