From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0254138418AA for ; Mon, 27 Jun 2022 13:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0254138418AA Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-569-kminjEaJPTeAPwRgIVivFw-1; Mon, 27 Jun 2022 09:36:34 -0400 X-MC-Unique: kminjEaJPTeAPwRgIVivFw-1 Received: by mail-ej1-f70.google.com with SMTP id l2-20020a170906078200b006fed42bfeacso2431708ejc.16 for ; Mon, 27 Jun 2022 06:36:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o63Acl4XFWXcfZ87pxTuYGeWh4FTXtJ67cxmvVHDczE=; b=PKkwwVk7LqTJMLpYB126NCNWpvCQuPaSl+JTpvtjSqzdtFN7gd+RgGy9uD3rNhV92+ zXhBvczk6vkWTV4LkffteqfNckjRhJgFeoEFRhnzMg32qhfQZxl1GH0e5QfVItRtjQ1z tcyILnujeW8NtriuB08OmXMeEJ131dhW02ky4vNVOfIknXaBwn0F1UaZiRA2gd0HJfa7 xNbCKEzH54/pgX3blbJZZplQlmholFx2E4DmdpP5uzxOyGRaUIWESTu8hYPN02XuQb5t vE8+uQPrmTi6zbVFLRafS1+hd9eYgcHTGKp1oMIPHalV9/W6e6gt0mKMtvyEjdqY635v Fdtw== X-Gm-Message-State: AJIora9uc3ZdNCU9f9J/0J6ndgt8R/QxvA7z67CcAF9+qguDTvARrNQO QLgbDWpRA336eZG+fXEOArLLJr/v6AimcCEEsR30ARuHY0J7g+IuCGvloKwgVdDD+JJ72XyQbGD GOCRKzyISh/5zAkUTY2yvwDX6honANn4= X-Received: by 2002:a05:6402:190e:b0:435:c4cd:ec2 with SMTP id e14-20020a056402190e00b00435c4cd0ec2mr16319063edz.127.1656336993276; Mon, 27 Jun 2022 06:36:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t//7+uOYLui7nA55NQElC//6o3S6BRd3yUmAGMFZbFLFyzomSTKoQjvLrTUqvdNwKdQ2PqM9Xmzg7Prqwrn/E= X-Received: by 2002:a05:6402:190e:b0:435:c4cd:ec2 with SMTP id e14-20020a056402190e00b00435c4cd0ec2mr16319049edz.127.1656336993132; Mon, 27 Jun 2022 06:36:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 27 Jun 2022 14:36:22 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: testsuite: test symlnks ifdef _GLIBCXX_HAVE_SYMLINK To: Alexandre Oliva Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2022 13:36:37 -0000 On Mon, 27 Jun 2022 at 14:29, Alexandre Oliva wrote: > > On Jun 23, 2022, Alexandre Oliva wrote: > > > libstdc++: testsuite: conditionalize symlink tests > > > libstdc++: testsuite: conditionalize another symlink test > > In the recent patch that introduced NO_SYMLINKS, I missed one of the > testcases that created symlinks. > > Regstrapped on x86_64-linux-gnu, also tested with a cross to > aarch64-rtems6. Ok to install? OK. > > > > for libstdc++-v3/ChangeLog > > * testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc > (test06): Don't create symlinks when NO_SYMLINKS is defined. > --- > .../iterators/recursive_directory_iterator.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libstdc++-v3/testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc b/libstdc++-v3/testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc > index e67e2cf38f754..e2f3613a3d07e 100644 > --- a/libstdc++-v3/testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc > +++ b/libstdc++-v3/testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc > @@ -187,7 +187,7 @@ test05() > void > test06() > { > -#if !(defined __MINGW32__ || defined __MINGW64__) > +#ifndef NO_SYMLINKS > auto p = __gnu_test::nonexistent_path(); > create_directories(p/"d1/d2"); > create_directory_symlink("d1", p/"link"); > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about >