From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 187F5386F0CF for ; Fri, 24 Jun 2022 12:38:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 187F5386F0CF Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-447-byBZIksvMJOgK9pXwZLhFw-1; Fri, 24 Jun 2022 08:38:37 -0400 X-MC-Unique: byBZIksvMJOgK9pXwZLhFw-1 Received: by mail-ed1-f70.google.com with SMTP id b7-20020a056402350700b00435bd1c4523so1806191edd.5 for ; Fri, 24 Jun 2022 05:38:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hz/DCIQjF2k2HNJpxp/FCpM5Apj6x4Q/pv5N1gb8ueQ=; b=1Pop8QMe/m3Z6f9hdSQbR+khYSoHpluvCn1NaaDQV3petxYvgfvdxWJ0K7rz1/sFwY z4Nw50AsuZ6r40z3yF7ZR9s/FJt2c/xD3EGSv7dZQ7laB3u7RlzKkNOjzYDsLGehiJaF L42o158J3Ya8YET0JY5SOBmT4c2BJJGjJKwYe6nmdWBU8c2/hDKtJazHBJ4QZsb5istR F8rp5frEzkJA8u3fFYzXg24VBz6jZW4LBwbmirJoAE52dtmXxCSEgosezKhdO774AbwE G8SPx/vYKwkYOiY2RdYiPoY1DzeNwdW2so9rY+3MnCDkwsKqt1naHtIDySr3/LG0Malo eB3A== X-Gm-Message-State: AJIora9OaQ0LfFp3koU7uLcAzESYA8kJTQ6h1METK+XC3l/utpuJU/qg uJULJqPnmJouhEfMBdzIC1lsANVSPk7lKHP+gPlqDsASw21gKk8ku6WuLLUa8/bdCWZXAa0S95a hvEEaaxGQZvp0Ex95iILAsS3Nh7mQiYU= X-Received: by 2002:a17:907:1ca8:b0:70c:68ce:dade with SMTP id nb40-20020a1709071ca800b0070c68cedademr13218040ejc.723.1656074316342; Fri, 24 Jun 2022 05:38:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sKxyFqUBRdsRPNMQynY4QVp59RAj7hxw5P8I8NvyvL3HDaL5D6550TVFXj0278MPB9OFdRseuYThg8fowKLvQ= X-Received: by 2002:a17:907:1ca8:b0:70c:68ce:dade with SMTP id nb40-20020a1709071ca800b0070c68cedademr13218016ejc.723.1656074316018; Fri, 24 Jun 2022 05:38:36 -0700 (PDT) MIME-Version: 1.0 References: <74ea0c62ebe19db186263053e4051f81d46e9da4.camel@xry111.site> In-Reply-To: From: Jonathan Wakely Date: Fri, 24 Jun 2022 13:38:25 +0100 Message-ID: Subject: Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts To: Xi Ruoyao Cc: Rainer Orth , Jonathan Wakely , "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 12:38:40 -0000 On Fri, 24 Jun 2022 at 13:37, Xi Ruoyao wrote: > > On Fri, 2022-06-24 at 13:41 +0200, Rainer Orth wrote: > > Hi Jonathan, > > > > > > > I'll need some rework as Rainer told me "grep -E" may not work on some > > > > > Solaris systems w/o GNU grep, and the code snippet in extract_symvers.in > > > > > is exactly for Solaris... > > > > > > > > I checked that, and it's not :-) > > > > > > > > The egrep uses in extract_symvers.in are for everything *except* > > > > SunOS. For Solaris we use the scripts/extract_symvers.pl script > > > > instead. > > I misread the case statement :(. > > > > > Your change might break generation of Doxygen API docs on Solaris, but > > > > maybe we can live with that. > > > > > > /usr/xpg4/bin/grep supports the -E flag, so I was going to say that > > > it's acceptable to require that version in the PATH when generating > > > the API docs with doxygen. But in fact that script already assumes GNU > > > > indeed: for a niche/developer-only use, the bar of tool requirements can > > be higher IMO. Besides, /usr/gnu/bin/grep is there, too (or could be; > > both /usr/xpg4/bin/grep and /usr/gnu/bin/grep live in separate packages > > that may or may not be installed). > > > > I just want to make the entry barries for normal builds as low as > > possible. > > Pushed as r13-1242 with ChangeLog fix, as compatibility-related stuff > "resolved" and this does not depend on other patches in the series. Great, thanks!