From: Jonathan Wakely <jwakely@redhat.com>
To: Ken Matsui <kmatsui@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH v10 4/5] libstdc++: Use new built-in trait __is_function for std::is_function
Date: Tue, 8 Aug 2023 21:35:18 +0100 [thread overview]
Message-ID: <CACb0b4mLcfmc0LTxLO2g5hRi1Sm7CqtHE_L+uzOSZcphzzR-HA@mail.gmail.com> (raw)
In-Reply-To: <20230713023731.15571-5-kmatsui@gcc.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
On Thu, 13 Jul 2023 at 03:41, Ken Matsui via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:
> This patch gets std::is_function to dispatch to new built-in trait
> __is_function.
>
> libstdc++-v3/ChangeLog:
>
> * include/std/type_traits (is_function): Use __is_function built-in
> trait.
> (is_function_v): Likewise. Optimize its implementation.
>
> Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
>
OK for trunk (after the compiler change is approved).
> ---
> libstdc++-v3/include/std/type_traits | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/include/std/type_traits
> b/libstdc++-v3/include/std/type_traits
> index 2a14df7e5f9..7ef50a2e64f 100644
> --- a/libstdc++-v3/include/std/type_traits
> +++ b/libstdc++-v3/include/std/type_traits
> @@ -594,6 +594,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> { };
>
> /// is_function
> +#if __has_builtin(__is_function)
> + template<typename _Tp>
> + struct is_function
> + : public __bool_constant<__is_function(_Tp)>
> + { };
> +#else
> template<typename _Tp>
> struct is_function
> : public __bool_constant<!is_const<const _Tp>::value> { };
> @@ -605,6 +611,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> template<typename _Tp>
> struct is_function<_Tp&&>
> : public false_type { };
> +#endif
>
> #define __cpp_lib_is_null_pointer 201309L
>
> @@ -3197,8 +3204,18 @@ template <typename _Tp>
> inline constexpr bool is_union_v = __is_union(_Tp);
> template <typename _Tp>
> inline constexpr bool is_class_v = __is_class(_Tp);
> +
> +#if __has_builtin(__is_function)
> template <typename _Tp>
> - inline constexpr bool is_function_v = is_function<_Tp>::value;
> + inline constexpr bool is_function_v = __is_function(_Tp);
> +#else
> +template <typename _Tp>
> + inline constexpr bool is_function_v = !is_const_v<const _Tp>;
> +template <typename _Tp>
> + inline constexpr bool is_function_v<_Tp&> = false;
> +template <typename _Tp>
> + inline constexpr bool is_function_v<_Tp&&> = false;
> +#endif
>
> #if __has_builtin(__is_reference)
> template <typename _Tp>
> --
> 2.41.0
>
>
next prev parent reply other threads:[~2023-08-08 20:35 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 4:30 [PATCH 00/10] c++, libstdc++: get std::is_object to dispatch to new built-in traits Ken Matsui
2023-03-26 4:30 ` [PATCH 01/10] c++: implement __is_reference built-in trait Ken Matsui
2023-03-26 4:30 ` [PATCH 02/10] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-03-26 4:30 ` [PATCH 03/10] c++: implement __is_function built-in trait Ken Matsui
2023-03-26 4:30 ` [PATCH 04/10] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-03-26 4:30 ` [PATCH 05/10] libstdc++: use std::is_void instead of __is_void in helper_functions.h Ken Matsui
2023-03-26 4:30 ` [PATCH 06/10] libstdc++: remove unused __is_void in cpp_type_traits.h Ken Matsui
2023-03-26 4:30 ` [PATCH 07/10] c++: rename __is_void defined in pr46567.C to ____is_void Ken Matsui
2023-03-26 4:30 ` [PATCH 08/10] c++: implement __is_void built-in trait Ken Matsui
2023-03-26 4:30 ` [PATCH 09/10] libstdc++: use new built-in trait __is_void for std::is_void Ken Matsui
2023-03-26 4:30 ` [PATCH 10/10] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-03-30 18:32 ` [PATCH 0/7] c++, libstdc++: get std::is_object to " Ken Matsui
2023-03-30 18:39 ` [PATCH v2 " Ken Matsui
2023-03-30 18:39 ` [PATCH v2 1/7] c++: implement __is_reference built-in trait Ken Matsui
2023-03-30 18:39 ` [PATCH v2 2/7] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-03-30 18:39 ` [PATCH v2 3/7] c++: implement __is_function built-in trait Ken Matsui
2023-03-30 18:39 ` [PATCH v2 4/7] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-03-30 18:39 ` [PATCH v2 5/7] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-03-30 18:39 ` [PATCH v2 6/7] libstdc++: use new built-in trait __is_void for std::is_void Ken Matsui
2023-03-30 18:39 ` [PATCH v2 7/7] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-04-02 7:53 ` [PATCH v3 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-04-02 7:53 ` [PATCH v3 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-04-02 7:53 ` [PATCH v3 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-04-02 7:53 ` [PATCH v3 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-04-02 7:53 ` [PATCH v3 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-09 17:54 ` Patrick Palka
2023-06-09 23:53 ` Ken Matsui
2023-04-02 7:53 ` [PATCH v3 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-04-02 7:53 ` [PATCH v3 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-11 2:43 ` [PATCH v4 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-11 2:43 ` [PATCH v4 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-06-11 2:43 ` [PATCH v4 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-06-12 18:09 ` François Dumont
2023-06-12 18:13 ` Ken Matsui
2023-06-11 2:43 ` [PATCH v4 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-06-11 2:43 ` [PATCH v4 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-11 2:43 ` [PATCH v4 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-06-11 2:43 ` [PATCH v4 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-12 22:22 ` [PATCH v5 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-12 22:22 ` [PATCH v5 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-06-12 22:22 ` [PATCH v5 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-06-12 22:22 ` [PATCH v5 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-06-12 22:22 ` [PATCH v5 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-12 22:22 ` [PATCH v5 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-06-12 22:22 ` [PATCH v5 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-14 5:10 ` François Dumont
2023-06-14 5:25 ` Ken Matsui
2023-06-12 22:39 ` [PATCH v6 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-12 22:39 ` [PATCH v6 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-06-12 22:39 ` [PATCH v6 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-06-12 22:39 ` [PATCH v6 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-06-12 22:39 ` [PATCH v6 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-12 22:39 ` [PATCH v6 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-06-12 22:39 ` [PATCH v6 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-12 22:47 ` [PATCH v7 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-12 22:47 ` [PATCH v7 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-06-20 16:06 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-06-20 16:07 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-06-20 16:05 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-20 16:05 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-06-20 16:00 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-15 10:49 ` [PATCH v7 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-20 13:19 ` Ken Matsui
2023-06-20 15:32 ` Patrick Palka
2023-06-24 15:12 ` Ken Matsui
2023-07-08 5:08 ` [PATCH v8 " Ken Matsui
2023-07-08 5:08 ` [PATCH v8 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-07-08 5:08 ` [PATCH v8 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-07-12 10:08 ` Jonathan Wakely
2023-07-08 5:08 ` [PATCH v8 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-07-08 5:08 ` [PATCH v8 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-07-12 10:10 ` Jonathan Wakely
2023-07-08 5:08 ` [PATCH v8 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-07-08 5:08 ` [PATCH v8 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-07-13 2:33 ` [PATCH v10 0/5] c++, libstdc++: Make " Ken Matsui
2023-07-13 2:33 ` [PATCH v10 1/5] c++: Implement __is_reference built-in trait Ken Matsui
2023-07-13 2:33 ` [PATCH v10 2/5] libstdc++: Use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-07-13 2:56 ` Ken Matsui
2023-09-04 15:00 ` [PING][PATCH " Ken Matsui
2023-07-13 2:33 ` [PATCH v10 3/5] c++: Implement __is_function built-in trait Ken Matsui
2023-07-13 2:41 ` Ken Matsui
2023-08-22 19:52 ` Patrick Palka
2023-09-04 15:00 ` [PING][PATCH " Ken Matsui
2023-07-13 2:33 ` [PATCH v10 4/5] libstdc++: Use new built-in trait __is_function for std::is_function Ken Matsui
2023-08-08 20:35 ` Jonathan Wakely [this message]
2023-07-13 2:33 ` [PATCH v10 5/5] libstdc++: Make std::is_object dispatch to new built-in traits Ken Matsui
2023-09-01 13:00 ` [PING][PATCH " Ken Matsui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4mLcfmc0LTxLO2g5hRi1Sm7CqtHE_L+uzOSZcphzzR-HA@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kmatsui@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).