From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EAFF13858430 for ; Tue, 16 Nov 2021 11:35:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EAFF13858430 Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-158-RjTNWG1wP6mnd3oLeuCPxQ-1; Tue, 16 Nov 2021 06:35:00 -0500 X-MC-Unique: RjTNWG1wP6mnd3oLeuCPxQ-1 Received: by mail-yb1-f197.google.com with SMTP id z2-20020a254c02000000b005b68ef4fe24so31677360yba.11 for ; Tue, 16 Nov 2021 03:35:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YV5OEsgfyj1TG1I/8BuBuvulY+W7i5bidMBn94doxug=; b=W4hs1pr2ENuMMgObIN2VsaXR++i9xihNx0QOusOitlY9lUN/hWEb1HEY4k/e5YCVsG INfj57lBXk7BW96l5NjaPvSQI8dermAWu+h4+aohj9j35+tPb8q2PNWs3npnt+wKT+aj pI1eVpoE71zgJ+820P+UwFs33i8Qh50XqW9ga4/t0yxptla+Fy5igngwKAxS6mz/V0IJ n0tdIkB3NZbLX7h1HryUM+7sQXslyr5/keu9Db4xKMdB2rCbt5WoTDD7DcTqXRx3pNJB a8sKG4byYAv1KuZWvtXc/J0QByiLDB/BwzrrGWDlqdzH4S3t9gkY0GykmdWM8WEn2vV2 EXAw== X-Gm-Message-State: AOAM530iOTa37c5isPoP0U1E+UfkAJAn3GDdV1PXSlNOG+V5+/UZU6jr 4pUbHYNablm39UvSrE4cSqmFjiMwC1mKkD4/bVyEibsbtFN/ZSWwMnu4uzyWtfJJua05I7fXyCP e1JBwOR8b7d2vpyT+ZMyZlLpzn/NDlaU= X-Received: by 2002:a25:c844:: with SMTP id y65mr7306956ybf.190.1637062500277; Tue, 16 Nov 2021 03:35:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUd2n7FIMhj6f2pT/9dTiz1+57zkHUzc12xM770NpeStU0DL4xIdutDoKfR1CwVN/S7cbmb2PKaO7TLEWXRHo= X-Received: by 2002:a25:c844:: with SMTP id y65mr7306938ybf.190.1637062500107; Tue, 16 Nov 2021 03:35:00 -0800 (PST) MIME-Version: 1.0 References: <20211116002505.2324582-1-ppalka@redhat.com> <87ee7gedjk.fsf@oldenburg.str.redhat.com> <87y25ocu1d.fsf@oldenburg.str.redhat.com> In-Reply-To: <87y25ocu1d.fsf@oldenburg.str.redhat.com> From: Jonathan Wakely Date: Tue, 16 Nov 2021 11:34:48 +0000 Message-ID: Subject: Re: [PATCH 1/5] libstdc++: Import the fast_float library To: Florian Weimer Cc: Jonathan Wakely , "Patrick Palka via Libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 11:35:05 -0000 On Tue, 16 Nov 2021 at 09:46, Florian Weimer via Libstdc++ < libstdc++@gcc.gnu.org> wrote: > * Jonathan Wakely: > > > On Tue, 16 Nov 2021 at 08:01, Florian Weimer wrote: > >> > >> * Patrick Palka via Libstdc: > >> > >> > This copies the fast_float library[1] into the compiled-in library > >> > sources. We're going to use this library in our floating-point > >> > std::from_chars implementation for faster and more portable parsing of > >> > binary32/64 decimal strings. > >> > > >> > [1]: https://github.com/fastfloat/fast_float > >> > > >> > Series tested on x86_64, i686, ppc64, ppc64le and aarch64, does it > >> > look OK for trunk? > >> > >> Missing Signed-off-by:? > > > > That's not needed if Patrick is still covered by an FSF assignment. > > But the submission is not covered by the FSF assignment. > Good point. > > I think we could use Apache as well, because this code isn't going to > > appear in public headers so the problematic clause doesn't apply. But > > MIT is simpler. > > Okay, so you consider dynamic linking only? I think the historic > libstdc++ license is more permissive than Apache or MIT when used with > GCC. There aren't any notification or other requirements. > > Another good point - the Apache license is (once again) problematic here. So it's good we can choose the MIT one.