From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 9BB6D385DC33 for ; Thu, 24 Jun 2021 13:42:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9BB6D385DC33 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-hB_cerubP4i0rEkHXa47Ow-1; Thu, 24 Jun 2021 09:42:48 -0400 X-MC-Unique: hB_cerubP4i0rEkHXa47Ow-1 Received: by mail-wm1-f72.google.com with SMTP id f22-20020a1c6a160000b029018f49a7efb7so3093787wmc.1 for ; Thu, 24 Jun 2021 06:42:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w9kGUtpi8rVbVCZxBXRflfg8+D8ukRwONzO0hCTfNqs=; b=eWGNutXXGnxoUCKZb3SxXHShPCaJ/DVWDUeenoNb6S3+zXOruUbJpHhhqPGJSwpTz4 DAkkC0uOX5QtLHkfGJo2k1pfIlyJVv1UL9zjBEi4cyiB2GcAUx4LyHaff8Clh7hzzHu7 q22BzXJW7heS35mFT43fCvr63n+r/Yowc3wjslVWfOq5gp+Y5YhZg9e72uyakTUlKVGP 80tE/tM+zpTf4MzPLJxHAh21eQKvLUeBLjdTHMSIAZjDAhdvHkhf2Ctz9w4ASEwOHD3x j0PZa6zxaCfQq9hgIkAJQyjYTIOolxct3XoVUlV7MWKzbOV4yzZSXw0JO+S9JWtGoA97 wrHA== X-Gm-Message-State: AOAM530VadFAlSmH4Bww4BjDjctfmUJMyZnbl83hTt5b3olnXS1+MOIl wOY2zJfNmzcuCRFBFS3X/ooEAFC9u0thKbKCf1KLUzWw73DhWOJz2MC8I8ZIQ06KTAZ3Qqy4+jm QLBkxMM/HQ76fIcN1RXnVs2xBXmqqwBU= X-Received: by 2002:a1c:7f96:: with SMTP id a144mr4465181wmd.22.1624542166987; Thu, 24 Jun 2021 06:42:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNSekp7dJaG69NVIIW/vtm7zAmMs+Afnt2fuHFINlHrtBPesbzYFXg9Eb8s/ZFjWg+356xaq5P4421oFb2/po= X-Received: by 2002:a1c:7f96:: with SMTP id a144mr4465145wmd.22.1624542166541; Thu, 24 Jun 2021 06:42:46 -0700 (PDT) MIME-Version: 1.0 References: <270527782.u9WJ3AIrlG@excalibur> In-Reply-To: <270527782.u9WJ3AIrlG@excalibur> From: Jonathan Wakely Date: Thu, 24 Jun 2021 14:42:35 +0100 Message-ID: Subject: Re: [PATCH 00/11] stdx::simd optimizations, corrections, and cleanups To: Matthias Kretz Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 13:42:50 -0000 On Tue, 8 Jun 2021 at 13:10, Matthias Kretz wrote: > > The following patches mostly contain code cleanups and minor corrections. The > major feature in this patchset is the last patch, which should make the use of > stdx::simd much safer wrt. ODR violations involuntarily introduced by linking > TUs that were compiled with different -m and floating-point flags. > > Matthias Kretz (11): > libstdc++: Improve copysign codegen > libstdc++: Remove dead code > libstdc++: Improve fixed_size codegen > libstdc++: Make use of __builtin_bit_cast > libstdc++: Remove incorrect fabs overload > libstdc++: Minor simd_math cleanups > libstdc++: Fix condition when AVX512F ldexp implementation is used > libstdc++: Avoid raising fp exceptions in trunc, floor, and ceil > libstdc++: Ensure unrolled loops inline the lambda > libstdc++: Fix internal names: add missing underscores > libstdc++: Fix ODR issues with different -m flags Thanks! I've pushed all except the bit_cast one (as discussed on IRC) and the ODR one (which I'm still reviewing).