From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D8E513858D1E for ; Mon, 1 May 2023 20:04:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8E513858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682971472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wtwIwqeVYJA5l7ygSguJBlR92GIGiR2Fu9mOmulndzg=; b=YbuXrMaFH7NkyjR85mhGEmrmnpsdVxu+6uC2gPsoz7RKRVz4BYfD9H7AV+clemxyXEglpQ zjTRj2pzmtKMy4oqdRRt3XCLZ3pqB+FeJsMzvcVEWgSqa5XpPOGfEJdpFwvCWHddCee4sI vd+Jjrlikn5O6UEwpz9Em/IMM0bHBp4= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-6YZkkWUtNAyskWh65NtdMQ-1; Mon, 01 May 2023 16:04:29 -0400 X-MC-Unique: 6YZkkWUtNAyskWh65NtdMQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2a83a0b7be1so13261551fa.1 for ; Mon, 01 May 2023 13:04:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682971467; x=1685563467; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wtwIwqeVYJA5l7ygSguJBlR92GIGiR2Fu9mOmulndzg=; b=iwDHWGsgJpKzq45RgHRX8dGuGzTg8T9QZdXJQ2SIkLz6mlVENmeruloxHcpDKDNAQs 82Ks1Om4G/vg2g9d2MsHU7rTyJk2iwSJN/NctnBGI5Baz+dSKTdqPV9fTaOvqLnSLBXz dlOER/fFzk/rhe5tPVd8+WQyaZhZ7Z0XjHDHw6hMmUQVXCCwYHooqBaM44dbVnEPRKgE CEfgpjGEWNld3Vf4wJofNzgT8RCbPBP9jfh9xRmXtDrhI1LTyq4KpF4W/l/eTvHLF7Z0 QPleMM9TyMuParkUWOvhUs/KF9mZ+E7Yy+GKVHKXwTdu/hgrq55wWngXzQ47z8UmQ6Rn WuPA== X-Gm-Message-State: AC+VfDzn5UfpgNdNDREAFmicLL9tPcg3QlAM5tSB1KSrDfkCje5Tp676 YTF/cI89CT8Mq2tV3sj1fcLkU0lL+0gEF8DZRKhmnBrWIGMuMkLm9nLYncQF6n2nHPmfWY71wzO fTIVgGqk0QvpW4gTAVm1hvxdjLIryWPM= X-Received: by 2002:a05:651c:238:b0:2a9:f584:659a with SMTP id z24-20020a05651c023800b002a9f584659amr4279719ljn.23.1682971467371; Mon, 01 May 2023 13:04:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7fqJYKVZZSsQIk3VoCCDuI2C3h34k3+6+diPLy5UsPkr71lxEd4G9cAZKpZeG9G/9S/plpaTFf9uQuwyVKkBI= X-Received: by 2002:a05:651c:238:b0:2a9:f584:659a with SMTP id z24-20020a05651c023800b002a9f584659amr4279709ljn.23.1682971467010; Mon, 01 May 2023 13:04:27 -0700 (PDT) MIME-Version: 1.0 References: <20230501070622.847749-1-tchaikov@gmail.com> In-Reply-To: <20230501070622.847749-1-tchaikov@gmail.com> From: Jonathan Wakely Date: Mon, 1 May 2023 21:04:15 +0100 Message-ID: Subject: Re: [PATCH v1 0/1] Set _M_string_length before calling _M_dispose() To: Kefu Chai Cc: libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000756fbc05faa754ba" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000756fbc05faa754ba Content-Type: text/plain; charset="UTF-8" On Mon, 1 May 2023 at 08:06, Kefu Chai via Libstdc++ wrote: > This patch fixes the false alarm when performing the check introduced by > bf78b43873b0b7e8f9a430df38749b8b61f9c9b8 . A minimal reproducer can be > found at https://godbolt.org/z/7q4nG68xn > > I am pasting the reproducer here just in case: > > #include > #include > #include > > int main() { > unsigned char buf[sizeof(std::string)] ; > std::memset(buf, 0xff, sizeof(buf)); > const char s[] = "1234567890abcdefg"; > std::istringstream in{s}; > std::istreambuf_iterator it{in}, end; > auto* p = new (buf) std::string(it, end); > return 0; > } > > Tested on x86_64-pc-linux-gnu, with "make check-target-libstdc++-v3". > Would be great if this change can be included in thunk, 13.2 and 12 > branches. > The bf78b43873b0b7e8f9a430df38749b8b61f9c9b8 change isn't on the gcc-12 branch. > Kefu Chai (1): > libstdc++: Set _M_string_length before calling _M_dispose() > > libstdc++-v3/include/bits/basic_string.tcc | 1 + > 1 file changed, 1 insertion(+) > > -- > 2.40.1 > > --000000000000756fbc05faa754ba--