From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AD0D9385B52A for ; Wed, 4 Jan 2023 17:15:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD0D9385B52A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672852556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LEgGS7eYU2KVeXVS8uU+kb+ImnBsfCTwco2i0PnYVhw=; b=W/VQqHYyqXHDkTHHV7mWDF0TxVW6WOblL6PTzTliwNLQHVZX1k6bJ334psTXwXxELSRua5 s1NNnr/aBaIrbNvxiWa/rfXLJJglcJhvXthlGXiowH8Sz7Bw6vgw086PqZCCxnqvRlNeG1 w9CNfNCU42fVStxtZRu/nHoQ9LSlZ3w= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-587-bHi_wfBAPNqW6V1Zq13ChQ-1; Wed, 04 Jan 2023 12:15:54 -0500 X-MC-Unique: bHi_wfBAPNqW6V1Zq13ChQ-1 Received: by mail-lj1-f197.google.com with SMTP id bn17-20020a05651c179100b0027905fa8e48so8126307ljb.15 for ; Wed, 04 Jan 2023 09:15:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LEgGS7eYU2KVeXVS8uU+kb+ImnBsfCTwco2i0PnYVhw=; b=1TVX9BtjjiUzupu8aKQ8+gMqdmGv7679AUgcQs3UDAE94HgqH3/jz3p2Eht4c0FQfH qArfK/CAEP1Wp8HMIHtg+8XMV7wexP5zcp7d+SDef4XvWPwXtK496RMIqUB2qDcePUON HoIGd9BHTFFI87JrYfJKx5ElXWXEydSjjnCCxJJKZtlY+MWT4ke4fpY1f82bvcNJ8PBA Vgep7Xt1U+lY6PrZ+Gc5cONtSG5nwWVIMl7ijceDbHnl4ZeUCplqcbBU9AKHqkcMIIci LVcHZQ2KgkAVZYMnVROhkQ7oWcs6H41e1JgHN4L23knp465APskftGGT1MAazKwMQTpA o+Lg== X-Gm-Message-State: AFqh2ko/h4Xd/+7A/9DnivHOk5ON9XlAqnvrRZ3kRmbOCXs7quy9FDAn N5vHEpnMzLJyhsxjWzjTDZt/Yydy9aGCw0oTUbGWfwZymvwZIWqWUlQxPwnOlzYhLfdrE1IYkQw S7HLtwG/Vf73CDLT7kSr54Sa+XPs1IzU= X-Received: by 2002:a05:6512:3da4:b0:4cb:87f:64f5 with SMTP id k36-20020a0565123da400b004cb087f64f5mr1549464lfv.429.1672852553436; Wed, 04 Jan 2023 09:15:53 -0800 (PST) X-Google-Smtp-Source: AMrXdXuJcXWRwOoNjPyOQ9+S8nhiPSxrdiBJ+lEdhjHiiHJ4KEpoPx9EQCSrFk+FvOVg7lVKBU6oTeIUR5yTYiJyMo8= X-Received: by 2002:a05:6512:3da4:b0:4cb:87f:64f5 with SMTP id k36-20020a0565123da400b004cb087f64f5mr1549460lfv.429.1672852553232; Wed, 04 Jan 2023 09:15:53 -0800 (PST) MIME-Version: 1.0 References: <20221224113525.20201-1-iain@sandoe.co.uk> <448810FA-97CC-430A-B9A0-75EDB470C935@sandoe.co.uk> In-Reply-To: From: Jonathan Wakely Date: Wed, 4 Jan 2023 17:15:42 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Export the __gnu_cxx::zoneinfo_dir_override symbol. To: Jakub Jelinek Cc: Iain Sandoe , Jonathan Wakely , "libstdc++" , GCC Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 4 Jan 2023 at 17:14, Jakub Jelinek wrote: > > On Wed, Jan 04, 2023 at 03:17:42PM +0000, Jonathan Wakely via Gcc-patches= wrote: > > On Sat, 24 Dec 2022 at 12:21, Iain Sandoe wrote: > > > > > > > > > > > > > On 24 Dec 2022, at 12:12, Jonathan Wakely wrote: > > > > > > > > > > > > > > > > On Sat, 24 Dec 2022, 11:35 Iain Sandoe via Libstdc++, wrote: > > > > If this is not the right place to export the symbol (or you do not= want > > > > to export it in the general case), I can always add a platform-spe= cific > > > > file for it. So far, tested on x86_64-darwin21, wider testing wil= l > > > > follow over the holidays. > > > > > > > > OK for trunk? > > > > > > > > I'd like to check if this causes the undefined weak symbol to be ex= ported on ELF, > > > > > > I=E2=80=99d expect so, since it=E2=80=99s in the common file. > > > > hppa-hp-hpux* wants this symbol to be defined anyway (see PR 108228), > > so please push your patch to trunk. > > Isn't it wrong though to export it with GLIBCXX_3.4 symbol version? > I mean, if it wasn't exported in GCC 3.4 libstdc++.so, then it shouldn't > be in that symver. Perhaps GLIBCXX_3.4.31 instead? Oops, yes! I didn't notice that! I'll move it. Thanks for catching that.