From: Jonathan Wakely <jwakely@redhat.com>
To: Thomas Rodgers <trodgers@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Reduce header dependencies from PSTL headers [PR92546]
Date: Fri, 18 Mar 2022 10:16:25 +0000 [thread overview]
Message-ID: <CACb0b4mgR-2VWWSCyLq6gasw+oRauQCZ7=hjuehxx7vBXXGAVQ@mail.gmail.com> (raw)
In-Reply-To: <CAMmuTO95j7_+YbcNR+sScMSZ0kdhhr=NWAEXBTE+VksXaJ=W_g@mail.gmail.com>
On Thu, 17 Mar 2022 at 20:44, Thomas Rodgers wrote:
>
> Looks ok to me. I just am curious, does the change to src/c++17/fs_path.cc need to be part of this change (It's not obvious to me that it is related to the other changes in the patch).
It's related. fs_path.cc uses std::array but was not including <array>
directly, it was accidentally relying on it being there via
<algorithm>. After this change, <algorithm> doesn't include
<functional>, so doesn't include <array> and so fs_path.cc needs to be
fixed.
next prev parent reply other threads:[~2022-03-18 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 19:01 Jonathan Wakely
2022-03-17 20:43 ` Thomas Rodgers
2022-03-18 10:16 ` Jonathan Wakely [this message]
2022-03-18 10:46 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4mgR-2VWWSCyLq6gasw+oRauQCZ7=hjuehxx7vBXXGAVQ@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=trodgers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).