From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B1CC63853804 for ; Fri, 18 Mar 2022 10:16:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1CC63853804 Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-Kkk_yneCO_yGOjb8a2lJ3A-1; Fri, 18 Mar 2022 06:16:37 -0400 X-MC-Unique: Kkk_yneCO_yGOjb8a2lJ3A-1 Received: by mail-yb1-f198.google.com with SMTP id y10-20020a5b0d0a000000b00633b9765410so1355904ybp.18 for ; Fri, 18 Mar 2022 03:16:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GG/cPmA/AuF+V65krKDGK6Fnu6O8zhJrFVhZRpVa9tA=; b=SnPrhiCeZEW2LYaGTe4FxnNaMWkkpgK2JU936MjuHgs4aonHMiqZkrVWI3xxmKskxx bJOpi17XxJKB6XPC6nHSX1X8g5YaEQm0erFSXnXTVegjbe8Qb8J5kiH0mOb0XBZ2T5iT 7hnEUDqetE0OQXvif4vPjsvEXMzJ/L0wOXPi0/7T3Ut0ESSFap5M2TqtzFpO9PBcp2io mOQycXp6JJ6Fc2D83k/Jsr9JrZoFYQUPE7bbqvIFMR5+yY5DlYP1AHLeUKvpndWAEZkW Y0UVO8cswzTdHpkVA0hpguus7XfITf++Bev0tC1dVWSAyJXcw29xe6kGU7pKnsz8DeWc tdxA== X-Gm-Message-State: AOAM532r/PlybM1+QZRGt1Elj7tcjTFh+tLpYoYLFfGoJWzI/YrMFee3 5c+LvT3SLWoz6HHDuF3gCCE1x0jtuzpHDoxxewTJXmCHjR0WdpMftmX3UJPZklkPvuA072AOvM7 OFlW9OiGk6+VBQYvkYB+bAjZAe0rTnXU= X-Received: by 2002:a25:fe10:0:b0:625:262f:e792 with SMTP id k16-20020a25fe10000000b00625262fe792mr9062438ybe.365.1647598596620; Fri, 18 Mar 2022 03:16:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+GSTzSr9pkU/jlC6unzetBTuJsuTUv2RrlXs6ORqkTawI02eBcfh2+J/N/F7HB3IJON7U3B1zglSEiul0mGU= X-Received: by 2002:a25:fe10:0:b0:625:262f:e792 with SMTP id k16-20020a25fe10000000b00625262fe792mr9062426ybe.365.1647598596425; Fri, 18 Mar 2022 03:16:36 -0700 (PDT) MIME-Version: 1.0 References: <20220317190133.415743-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 18 Mar 2022 10:16:25 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Reduce header dependencies from PSTL headers [PR92546] To: Thomas Rodgers Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 10:16:39 -0000 On Thu, 17 Mar 2022 at 20:44, Thomas Rodgers wrote: > > Looks ok to me. I just am curious, does the change to src/c++17/fs_path.cc need to be part of this change (It's not obvious to me that it is related to the other changes in the patch). It's related. fs_path.cc uses std::array but was not including directly, it was accidentally relying on it being there via . After this change, doesn't include , so doesn't include and so fs_path.cc needs to be fixed.