From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 810303858D3C for ; Fri, 11 Nov 2022 22:32:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 810303858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668205958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nXd2bgp8BMLzzdZXfZRug5Mr2gVA7f5NH3+1UEMUHA8=; b=EIsRKgr0cUa9T2m7pX3zvcMNFD74Vle1NZoYOzGOr3vB5FemndDN3BKyDinl7gyAvkQpfi zIJj+R7LxKb4GuFpKi3gRV+AOjt2nESjKnN1fubpzWvKunSlBIT5/b59gGyKXs22V43McZ 31DpKIMWEjRSXwJQItBphwONIxvRnEg= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-262-P736245fNfKw_j6tgwBX3Q-1; Fri, 11 Nov 2022 17:32:34 -0500 X-MC-Unique: P736245fNfKw_j6tgwBX3Q-1 Received: by mail-ed1-f69.google.com with SMTP id w17-20020a056402269100b00461e28a75ccso4319590edd.8 for ; Fri, 11 Nov 2022 14:32:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nXd2bgp8BMLzzdZXfZRug5Mr2gVA7f5NH3+1UEMUHA8=; b=WytBUfGtXdWiDRZX6WdgI5ycaZyBmKczWB4u1BowpQoIQNKYoZaFfzoIkYhRSO4EtL R287xP+1Oe/JqdA7xAbkl7gYt/5U1DDMWjIcq8NQvfgJ0Xfgnsay3sjg6DMUIaw0uBVi 51nif+oK2j0duPukDQ1XQ4fzJGwmaLC+c+xLM1rBbHkukKuNWnCoGlSJXtlB+ry0sAbk R/62qAPSF3La9hZKmFp1WecvbMoCqf3on5WwJKezw3ODuZrO19SOeAq4Jy4/JEGVZxcd ANipkdMfHMvBITobNfleXppEhnw9jfxxqxTb9K+OVzRaS0lotYWAOrm8ep680G+aWr14 lvRQ== X-Gm-Message-State: ANoB5plsmu4zdLGteeCh/7ofVrdAhhPWnt/czzpN8AtpkF4dmjDIFcGw kd7BkheyKngn/HgyhtZoceiEANASt7vPfxuv5pbzT3Bd67dyp6ikqqMLFWDjhg5Gdq/6vNdAkhp cC4ARe0AVpUyizdbIPWgvraySwy+Rdgo= X-Received: by 2002:a17:906:6d52:b0:7ad:9673:8b73 with SMTP id a18-20020a1709066d5200b007ad96738b73mr3686877ejt.14.1668205953554; Fri, 11 Nov 2022 14:32:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf6W7CMMYezDIQXZS5D+kdNaCPkTwbO82SPsdlY6NT4OlWbxt9IO+b/bIUk3QiWSDM+nsOO5g5ZRH8qbThCaOCM= X-Received: by 2002:a17:906:6d52:b0:7ad:9673:8b73 with SMTP id a18-20020a1709066d5200b007ad96738b73mr3686863ejt.14.1668205953298; Fri, 11 Nov 2022 14:32:33 -0800 (PST) MIME-Version: 1.0 References: <20221111174424.686786-1-jwakely@redhat.com> In-Reply-To: <20221111174424.686786-1-jwakely@redhat.com> From: Jonathan Wakely Date: Fri, 11 Nov 2022 22:32:22 +0000 Message-ID: Subject: Re: [committed] libstdc++: Fix wstring conversions in filesystem::path [PR95048] To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000428ee205ed3977f5" X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000428ee205ed3977f5 Content-Type: text/plain; charset="UTF-8" On Fri, 11 Nov 2022 at 17:44, Jonathan Wakely via Libstdc++ wrote: > > Tested x86_64-linux and x86_64-w64-ming32 (via Wine). Sigh, I did test on Wine, but then what I pushed didn't include the fix that was found thanks to that testing. This is needed to prevent runtime errors on Windows when constructing paths. Pushed to trunk. --000000000000428ee205ed3977f5 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lad2qmzj0 Y29tbWl0IDgyMTRlYzBjZjMzNDgyZjYwMTM5YWUxOGE0MDU2NzMxN2U2M2MxZmYKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBGcmkgTm92IDExIDIy OjI1OjE0IDIwMjIKCiAgICBsaWJzdGRjKys6IEZpeCA8ZXhwZXJpbWVudGFsL2ZpbGVzeXN0ZW0+ IGZvciBXaW5kb3dzIFtQUjk1MDQ4XQogICAgCiAgICBJIG1lYW50IHRvIGluY2x1ZGUgdGhpcyBj aGFuZ2UgaW4gcjEzLTM5MDktZ2IzMzFiZjMwM2JkYzFlIGJ1dCBJIGZvcmdvdAogICAgdG8gc3lu YyBpdCBmcm9tIHRoZSBtYWNoaW5lIHdoZXJlIEkgZGlkIHRoZSBtaW5ndyB0ZXN0aW5nIHRvIHRo ZSBvbmUKICAgIHdoZXJlIEkgcHVzaGVkIHRoZSBjb21taXQuCiAgICAKICAgIGxpYnN0ZGMrKy12 My9DaGFuZ2VMb2c6CiAgICAKICAgICAgICAgICAgUFIgbGlic3RkYysrLzk1MDQ4CiAgICAgICAg ICAgICogaW5jbHVkZS9leHBlcmltZW50YWwvYml0cy9mc19wYXRoLmggKHBhdGg6Ol9DdnQ6Ol9T X3djb252ZXJ0KToKICAgICAgICAgICAgQ29uc3RydWN0IGNvZGVjdnQgZGlyZWN0bHkgaW5zdGVh ZCBvZiBnZXR0aW5nIGl0IGZyb20gdGhlCiAgICAgICAgICAgIGxvY2FsZS4KCmRpZmYgLS1naXQg YS9saWJzdGRjKystdjMvaW5jbHVkZS9leHBlcmltZW50YWwvYml0cy9mc19wYXRoLmggYi9saWJz dGRjKystdjMvaW5jbHVkZS9leHBlcmltZW50YWwvYml0cy9mc19wYXRoLmgKaW5kZXggNmUyZjQ3 ZjVlNjMuLmE0OTNlMTdhMzdlIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvaW5jbHVkZS9leHBl cmltZW50YWwvYml0cy9mc19wYXRoLmgKKysrIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvZXhwZXJp bWVudGFsL2JpdHMvZnNfcGF0aC5oCkBAIC03OTIsOCArNzkyLDcgQEAgbmFtZXNwYWNlIF9fZGV0 YWlsCiAgICAgICBzdGF0aWMgc3RyaW5nX3R5cGUKICAgICAgIF9TX3djb252ZXJ0KGNvbnN0IGNo YXIqIF9fZiwgY29uc3QgY2hhciogX19sLCBjb25zdCBjaGFyKikKICAgICAgIHsKLQl1c2luZyBf Q3Z0ID0gc3RkOjpjb2RlY3Z0X3V0ZjhfdXRmMTY8d2NoYXJfdD47Ci0JY29uc3QgYXV0byYgX19j dnQgPSBzdGQ6OnVzZV9mYWNldDxfQ3Z0PihzdGQ6OmxvY2FsZXt9KTsKKwlzdGQ6OmNvZGVjdnRf dXRmOF91dGYxNjx3Y2hhcl90PiBfX2N2dDsKIAlzdGQ6OndzdHJpbmcgX193c3RyOwogCWlmIChf X3N0cl9jb2RlY3Z0X2luX2FsbChfX2YsIF9fbCwgX193c3RyLCBfX2N2dCkpCiAJICAgIHJldHVy biBfX3dzdHI7Cg== --000000000000428ee205ed3977f5--