From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 342223881D29 for ; Thu, 12 Jan 2023 12:02:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 342223881D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673524940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92w+LMl5dA8OfFoUMnv12zxDnU2WEehOCT7N6c+VndY=; b=Os66vatueUl90tz6JjS8e09M+AobIomlpb6xtB+DOLHtYgel1tmz+hHymiKLi4vQM9BHIh FJN4Fbl0J35Eq72CZHqll9XP/jnuCdzwZ7dejXW8MJ8oBxwLJOrb66JfsFT1/WuglmEdPE q+FAhQx20hRC65eZdUto9zgs75/TxJk= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-170-VV2InBYwPeKtNJVOn2zIhQ-1; Thu, 12 Jan 2023 07:02:19 -0500 X-MC-Unique: VV2InBYwPeKtNJVOn2zIhQ-1 Received: by mail-lj1-f199.google.com with SMTP id o18-20020a05651c051200b0027a0ee63d4aso4848227ljp.21 for ; Thu, 12 Jan 2023 04:02:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=92w+LMl5dA8OfFoUMnv12zxDnU2WEehOCT7N6c+VndY=; b=EBqPJc0Mdn9f50E+FUjpS7mMRMt94B6H7kKUK7pVBbuSs7ofZFyI6AVgIw+FiWcixI moKyUKIX1YGU5zQ4pKehmtESHwyKL2vGJpzI/xOhPTGBAZcl2xxYjhgOulou+Ige9rw9 GWo4A4dwg8vtKLLo1/urhEm0mTObXGfeBnbSsN+xve10T5+PF+uWXNaxDXah4omAFtVq xCAi5mL450XiwBrrmTc6XN8Y3kKenAy6OLd0TBefWMcYVDpJ3Sdm0MZGaWYhOHq/du1E vrDzOft/vRAtR8Bl9Dq9d8mUbmghP/Eznw22WXg7Pe2D25YfiDjpVDis+3P7cpyBtopP QLhQ== X-Gm-Message-State: AFqh2kpn4E35QiB52t6mj7MUcACHPlCQnoSqA9QHZ8H7Xpg9JUKGBEnw +IORLob5fsT0YoHzCuSc3Le9eIN2WEeupCR6wZvY1dZMSvHV67C95puakm8/Pqxse3d+JMZ/nCk EIGlD2cHlD/HLvfUm4sra83ctl6P3vlM= X-Received: by 2002:a05:651c:201e:b0:27f:f3a4:2927 with SMTP id s30-20020a05651c201e00b0027ff3a42927mr3200766ljo.77.1673524938437; Thu, 12 Jan 2023 04:02:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXvDK2wypfIVlONG3cLZvPdVNoCZj/T2YmZqDL5PCgGBdBlMj+rHGO1xPvFQ6TsE0w+gKIVZpMiOPpO/ITJBu4c= X-Received: by 2002:a05:651c:201e:b0:27f:f3a4:2927 with SMTP id s30-20020a05651c201e00b0027ff3a42927mr3200759ljo.77.1673524937968; Thu, 12 Jan 2023 04:02:17 -0800 (PST) MIME-Version: 1.0 References: <8266b5be-256c-4be2-84db-3a880e849d41@gmail.com> <7a266d31-cf97-6143-d930-6020bc4ed102@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 12 Jan 2023 12:02:06 +0000 Message-ID: Subject: Re: [PATCH] PR 107189 Remove useless _Alloc_node To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 12 Jan 2023 at 12:01, Jonathan Wakely wrote: > > OK for trunk, sorry for not getting to it sooner. P.S. I do think this one would have been OK to commit as obvious, since it's just removing an unused variable and so has no effect on anything. > > On Wed, 4 Jan 2023 at 21:13, Fran=C3=A7ois Dumont via Libstdc++ > wrote: > > > > Still no chance to review ? > > > > On 14/11/22 18:56, Fran=C3=A7ois Dumont wrote: > > > Gentle reminder. > > > > > > Sorry if I should have committed it as trivial but I cannot do it > > > anymore now that I asked :-) > > > > > > > > > On 12/10/22 22:18, Fran=C3=A7ois Dumont wrote: > > >> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189] > > >> > > >> libstdc++-v3/ChangeLog: > > >> > > >> PR libstdc++/107189 > > >> * include/bits/stl_tree.h > > >> (_Rb_tree<>::_M_insert_range_equal): Remove > > >> unused _Alloc_node instance. > > >> > > >> Ok to commit ? > > >> > > >> Fran=C3=A7ois > > > > > >