From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BF6F33857C69 for ; Thu, 11 Jan 2024 10:50:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF6F33857C69 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF6F33857C69 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704970238; cv=none; b=XznvtO7V2oKOnv8T5V530qqca3897MZm5pVFmTDzulBgw6pKfKYX/hQf5Pp94V2wskJ3q2jhkm+y5mfwJnlHhRQXP7POFeEC33XZ1u9Ym7EEHB83ESGzqwjZzoesmIAJdUCckikncGDcID7Zr25Riadgnxj3QZ6BX1yvRS/UemA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704970238; c=relaxed/simple; bh=90A8Va9HfvRfFDeiWfHAeJjpKap5l38RdGQ6E/+NgaQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=YFMj74jTSavBDigyB3bJ2iuS6pVT/AfAnXVarOIP1M8D0rDyMURQmsSxFkh4JNFAulPwCKrZiSKnbJU7olN2qX0JMlao2NnWztNc4LxAWfK6j+FmjNkokJcigGHsJiWsYkbA2PnZky9DpDfCjT5xRbWklTNE58f4kdSnLnExidk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704970236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0UMhGzKl8lC1uZhlL1AtgFIWwE/yfQOWsJRSiXsmBrs=; b=DocIHB2Driov6thT6zBmga0cRpEWfLgI+JgxSFe8wh5oL1J2Q0JAbC2NHCeqWpZCaERt4b Ar3pOEk0qjUXuelyYWPBLjAEKsnqFmeFdh2d4jocmd6U/qVKl5iW+8572s2O0XBHImisCK XqoQ8jbscGEgJr8BZ3/IeLYW1cyT64E= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-ZsQqCXWoMGqWobnwuVk9iw-1; Thu, 11 Jan 2024 05:50:35 -0500 X-MC-Unique: ZsQqCXWoMGqWobnwuVk9iw-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5f325796097so97851187b3.1 for ; Thu, 11 Jan 2024 02:50:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704970234; x=1705575034; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0UMhGzKl8lC1uZhlL1AtgFIWwE/yfQOWsJRSiXsmBrs=; b=WI5YEVF34eGsf2oDkehTAvhbUil6pNwV9pp3OxhYIabnXQBlsnmTwvLzlwR25LcybE WhzT8ubOKlhbA4resnlhQ7hSG+RMD6qYIY0dqg0K/Mb+JPYAHy30zTPr96i5mrEi4JEz cTmv81LLYOpOw/UEuIr7i/SY5/nGOpLmR2ZtC+fyM3pNAyuYCfU051cFsscTmzG9rdF1 jUr+VPRmUS+ANYSOnV2TQcui/gJSurKmhv68Dz6zHgQW1zoEQK6WmSnJdbnT0RqzqHei 1ypqkwVtvFeqKLsoL9lL0ocYT6DjbyCdJs9qH/NiD5zt7bU/Cuxls9+8b0RLASygKD4w 8eug== X-Gm-Message-State: AOJu0YzOASFW6AAd1TygyYRXnNBIH5mXwqIKDH4CJKVIqu6xTbpZjH3U BWXel29vRdbezx1I2mAqQcJ14GUoR8F+ylOi5YGzhGzO7fVrr6pQfw1MzvS655YjWSy+EDnMAvx U0HMgjUehUr/9zE4sJ7P2NvOe96ywDkjy32rUAJ4= X-Received: by 2002:a5b:c0e:0:b0:dbe:a5b7:a8dc with SMTP id f14-20020a5b0c0e000000b00dbea5b7a8dcmr965525ybq.106.1704970234553; Thu, 11 Jan 2024 02:50:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvmECZnVkr2YHytYLG/Icf0fs1Cp+2tBQCkMcFO/MdnKLIrlTig7dw9vE+hF1TvTV/FyMCPIVRTHM/dmQyYjg= X-Received: by 2002:a5b:c0e:0:b0:dbe:a5b7:a8dc with SMTP id f14-20020a5b0c0e000000b00dbea5b7a8dcmr965518ybq.106.1704970234339; Thu, 11 Jan 2024 02:50:34 -0800 (PST) MIME-Version: 1.0 References: <20240111062222.525186-1-kmatsui@gcc.gnu.org> <20240111094038.876653-1-kmatsui@gcc.gnu.org> <20240111094038.876653-2-kmatsui@gcc.gnu.org> In-Reply-To: From: Jonathan Wakely Date: Thu, 11 Jan 2024 10:50:18 +0000 Message-ID: Subject: Re: Re: [PATCH v2 2/2] libstdc++: Use using instead of typedef in opts-common.h To: Ken Matsui Cc: Jonathan Wakely , Ken Matsui , gcc-patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 11 Jan 2024 at 10:12, Ken Matsui wrote: > > On Thu, 11 Jan 2024 at 09:55, Jonathan Wakely wrote: > > On Thu, 11 Jan 2024, 09:43 Ken Matsui, <[1]kmatsui@gcc.gnu.org> wrote: > > > > > libstdc++-v3/ChangeLog: > > > > > * src/filesystem/ops-common.h (stat_type): Use using. > > > > > Signed-off-by: Ken Matsui <[2]kmatsui@gcc.gnu.org> > > > --- > > > libstdc++-v3/src/filesystem/ops-common.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > diff --git a/libstdc++-v3/src/filesystem/ops-common.h > > > b/libstdc++-v3/src/filesystem/ops-common.h > > > index d78a54754c2..e302d8caae6 100644 > > > --- a/libstdc++-v3/src/filesystem/ops-common.h > > > +++ b/libstdc++-v3/src/filesystem/ops-common.h > > > @@ -118,7 +118,7 @@ namespace __gnu_posix > > > inline int close(int fd) > > > { return ::_close(fd); } > > > > > - typedef struct ::__stat64 stat_type; > > > + using stat_type = struct ::_stat64; > > > > You've removed an underscore, is that intentional? Has this been compiled > > + tested with mingw? > This is totally unintentional. I'll fix it. I've tested it with Linux > and do not have a mingw environment to test it with. Would you have any > suggestions on how to test it? If your linux distro has prebuilt packages for mingw-w64-g++ then it's pretty easy to build a new compiler from trunk. I can give you a simple recipe for doing it on Fedora. In the meanwhile, I can test your updated patch for you.