public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Add test for std::con/disjunction's short circuiting
Date: Wed, 31 Aug 2022 10:41:24 +0100	[thread overview]
Message-ID: <CACb0b4mrCL=Gq9fzmTtq71KEaws7y1Tzq_Z7o_W3xYF=mzz4_A@mail.gmail.com> (raw)
In-Reply-To: <20220830171416.54524-1-ppalka@redhat.com>

On Tue, 30 Aug 2022 at 18:14, Patrick Palka via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> Tested on x86_64-pc-linux-gnu, does this look OK for trunk?

Yes, thanks for adding this.

>
> libstdc++-v3/ChangeLog:
>
>         * testsuite/20_util/logical_traits/requirements/short_circuit.cc: New test.
> ---
>  .../requirements/short_circuit.cc             | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 libstdc++-v3/testsuite/20_util/logical_traits/requirements/short_circuit.cc
>
> diff --git a/libstdc++-v3/testsuite/20_util/logical_traits/requirements/short_circuit.cc b/libstdc++-v3/testsuite/20_util/logical_traits/requirements/short_circuit.cc
> new file mode 100644
> index 00000000000..b6a8091cdb0
> --- /dev/null
> +++ b/libstdc++-v3/testsuite/20_util/logical_traits/requirements/short_circuit.cc
> @@ -0,0 +1,32 @@
> +// { dg-do compile { target c++17 } }
> +
> +#include <type_traits>
> +
> +template<class T> struct A { using type = typename T::type; };
> +using invalid = A<void>;
> +
> +// [meta.logical]/3: For a specialization conjunction<B_1, ..., B_n>, if
> +// there is a template type argument B_i for which bool(B_i::value) is false,
> +// then instantiating conjunction<B_1, ..., B_n>::value does not require the
> +// instantiation of B_j::value for j > i.
> +
> +static_assert(!std::conjunction_v<std::false_type, invalid>);
> +static_assert(!std::conjunction_v<std::false_type, invalid, invalid>);
> +static_assert(!std::conjunction_v<std::false_type>);
> +
> +static_assert(!std::conjunction_v<std::true_type, std::false_type, invalid>);
> +static_assert(!std::conjunction_v<std::true_type, std::false_type, invalid, invalid>);
> +static_assert(!std::conjunction_v<std::true_type, std::false_type>);
> +
> +// [meta.logical]/8: For a specialization disjunction<B_1, ..., B_n>, if
> +// there is a template type argument B_i for which bool(B_i::value) is true,
> +// then instantiating disjunction<B_1, ..., B_n>::value does not require the
> +// instantiation of B_j::value for j > i.
> +
> +static_assert(std::disjunction_v<std::true_type, invalid>);
> +static_assert(std::disjunction_v<std::true_type, invalid, invalid>);
> +static_assert(std::disjunction_v<std::true_type>);
> +
> +static_assert(std::disjunction_v<std::false_type, std::true_type, invalid>);
> +static_assert(std::disjunction_v<std::false_type, std::true_type, invalid, invalid>);
> +static_assert(std::disjunction_v<std::false_type, std::true_type>);
> --
> 2.37.2.490.g6c8e4ee870
>


      reply	other threads:[~2022-08-31  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 17:14 Patrick Palka
2022-08-31  9:41 ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACb0b4mrCL=Gq9fzmTtq71KEaws7y1Tzq_Z7o_W3xYF=mzz4_A@mail.gmail.com' \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ppalka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).