From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 02BF43858280 for ; Wed, 31 Aug 2022 09:41:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 02BF43858280 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661938897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ti0rDM8QFRMofN+LLupKsOTRaTg8nv0Rgt9HifbzGG0=; b=MfHayAqU2OHWtjfxWAx1tjupyWf+Y+lFse84b1Z7H/rTgYuFp5X2zdU5AftSOAD/TUBDOS G48NbVw0r+Gbi/xlbb2HhKdwHzF3tpMEVWiYkDRgQ7sLloMi+uePoOm39CggA9Wtd/cGjb C9ARX2rNqx0RPCjLp5+eJL0hZ479kV8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-119-uDSPh1frNRK__YamFb-aLA-1; Wed, 31 Aug 2022 05:41:36 -0400 X-MC-Unique: uDSPh1frNRK__YamFb-aLA-1 Received: by mail-qk1-f197.google.com with SMTP id x22-20020a05620a259600b006b552a69231so11280382qko.18 for ; Wed, 31 Aug 2022 02:41:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=ti0rDM8QFRMofN+LLupKsOTRaTg8nv0Rgt9HifbzGG0=; b=Fr1XRIA+oskFKlcHZdlcNUX5nGyBZ1ifmZUXNIsrMuOfTfDcQJs391Z3uTIpQygbTe H2spRHUiquvnDh5xoH/cyk0El+mQw6kwEoe6CT8Y2+zW/GM8XVrOJu7UrWKBtGVjGuEg 9VBxLmc/1IFM/KSm6rq6/bkBz8kZMzAPjUtlOfB0htDW1942sDB8y9FWcdfpaYGag0jX BP/+kb2sVdGQm3rn7DqvZgfzy1EUiMxdiCnY4USMNh35MrD+LUXMbXyyM4UYiXSyXVtY 7v3QYan5USN4R0AOBZn/fe4fm8rfBe7eOIXxANWaOFkJpOSVaWbMvSXAy/43qk+uI5/X zKGw== X-Gm-Message-State: ACgBeo0ZkzRPWwvcPaoF8nm/KoxQtZCZfSEn7x7hLnhMQXwxltBVx1Sp mTWTMIHy17ePX3odW3TP3oBXD4PSGhI7a9zUlPa902dOscUd4P6M6gK1G42odR+If1cbJ1t/+ft 6WqLA4/6P+W+m4NXqiW4ZgmzYCJwGuLE= X-Received: by 2002:a05:620a:884:b0:6bc:2056:1005 with SMTP id b4-20020a05620a088400b006bc20561005mr14832930qka.293.1661938895706; Wed, 31 Aug 2022 02:41:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR6zAHqjlKh3fhBMSn8aiok5KF5bj51xF7N1ifAG4pT7bdREeEnmAz2XzRhO/qmAMCNyALeVCr2uN2OghB+P0AY= X-Received: by 2002:a05:620a:884:b0:6bc:2056:1005 with SMTP id b4-20020a05620a088400b006bc20561005mr14832919qka.293.1661938895490; Wed, 31 Aug 2022 02:41:35 -0700 (PDT) MIME-Version: 1.0 References: <20220830171416.54524-1-ppalka@redhat.com> In-Reply-To: <20220830171416.54524-1-ppalka@redhat.com> From: Jonathan Wakely Date: Wed, 31 Aug 2022 10:41:24 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Add test for std::con/disjunction's short circuiting To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 30 Aug 2022 at 18:14, Patrick Palka via Libstdc++ wrote: > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? Yes, thanks for adding this. > > libstdc++-v3/ChangeLog: > > * testsuite/20_util/logical_traits/requirements/short_circuit.cc: New test. > --- > .../requirements/short_circuit.cc | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 libstdc++-v3/testsuite/20_util/logical_traits/requirements/short_circuit.cc > > diff --git a/libstdc++-v3/testsuite/20_util/logical_traits/requirements/short_circuit.cc b/libstdc++-v3/testsuite/20_util/logical_traits/requirements/short_circuit.cc > new file mode 100644 > index 00000000000..b6a8091cdb0 > --- /dev/null > +++ b/libstdc++-v3/testsuite/20_util/logical_traits/requirements/short_circuit.cc > @@ -0,0 +1,32 @@ > +// { dg-do compile { target c++17 } } > + > +#include > + > +template struct A { using type = typename T::type; }; > +using invalid = A; > + > +// [meta.logical]/3: For a specialization conjunction, if > +// there is a template type argument B_i for which bool(B_i::value) is false, > +// then instantiating conjunction::value does not require the > +// instantiation of B_j::value for j > i. > + > +static_assert(!std::conjunction_v); > +static_assert(!std::conjunction_v); > +static_assert(!std::conjunction_v); > + > +static_assert(!std::conjunction_v); > +static_assert(!std::conjunction_v); > +static_assert(!std::conjunction_v); > + > +// [meta.logical]/8: For a specialization disjunction, if > +// there is a template type argument B_i for which bool(B_i::value) is true, > +// then instantiating disjunction::value does not require the > +// instantiation of B_j::value for j > i. > + > +static_assert(std::disjunction_v); > +static_assert(std::disjunction_v); > +static_assert(std::disjunction_v); > + > +static_assert(std::disjunction_v); > +static_assert(std::disjunction_v); > +static_assert(std::disjunction_v); > -- > 2.37.2.490.g6c8e4ee870 >