From: Jonathan Wakely <jwakely@redhat.com>
To: Bill Schmidt <wschmidt@linux.ibm.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH v2] libstdc++: Add support for POWER9 DARN instruction to std::random_device
Date: Fri, 5 Nov 2021 18:16:07 +0000 [thread overview]
Message-ID: <CACb0b4ms0Dc3rs-ELt2-1SA+YzWV648GEFmS8FyxxtapCpci7A@mail.gmail.com> (raw)
In-Reply-To: <016e938f-d115-7e0d-1d2f-cf9495708e41@linux.ibm.com>
On Fri, 5 Nov 2021 at 13:20, Bill Schmidt wrote:
>
> On 11/5/21 7:44 AM, Jonathan Wakely wrote:
> > On Thu, 4 Nov 2021 at 20:44, Bill Schmidt wrote: For posterity: This
> was discussed briefly on IRC, and Segher approved with some simplifications
> and a request to implement a fail/retry check. Here's what I have now. No
> more assembler check
> > On Thu, 4 Nov 2021 at 20:44, Bill Schmidt wrote:
> >
> > For posterity: This was discussed briefly on IRC, and Segher
> approved with some
> > simplifications and a request to implement a fail/retry check.
> >
> >
> > Here's what I have now. No more assembler check in configure, and it
> uses the 64-bit __builtin_darn() and truncates it to 32-bit, or retries (up
> to 100 times) if it fails.
> >
> > I'm doing some more testing now.
> >
> Those changes look good from my perspective. Thanks again for this work!
> (Not a maintainer, blah blah...)
>
I changed the number of retries to 10 and pushed it to trunk.
prev parent reply other threads:[~2021-11-05 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 16:47 [PATCH] " Jonathan Wakely
2021-10-20 9:12 ` Jonathan Wakely
2021-10-20 13:00 ` [PATCH v2] " Jonathan Wakely
2021-11-03 15:01 ` Jonathan Wakely
2021-11-03 15:02 ` Jonathan Wakely
2021-11-04 20:44 ` Bill Schmidt
2021-11-05 12:44 ` Jonathan Wakely
2021-11-05 13:20 ` Bill Schmidt
2021-11-05 18:16 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4ms0Dc3rs-ELt2-1SA+YzWV648GEFmS8FyxxtapCpci7A@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).